From patchwork Thu Mar 2 14:47:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 63459 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp4274478wrd; Thu, 2 Mar 2023 06:53:36 -0800 (PST) X-Google-Smtp-Source: AK7set9mTliMMS0fvghQgww4jZ46yGn3fq3u4THD6WkXhfERwgvPINpKj6UXtSpRlKE9SiPi7Nbp X-Received: by 2002:aa7:9530:0:b0:5a8:a0df:a624 with SMTP id c16-20020aa79530000000b005a8a0dfa624mr9166693pfp.22.1677768816226; Thu, 02 Mar 2023 06:53:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677768816; cv=none; d=google.com; s=arc-20160816; b=L71Cf2+ZwIuUPkWtFLHr7y3mp/FcOgJqq8LXTGt21Pbd+QVbIJinbJIVdqGSoAzIBL JJWTJmUX41Lu1dDAA6MToBLmEbNZCx8cRswj6nG6GJCmltrJO89vJ2J1rUrHwOoT2ABo utDV3j6b82aT7tr4XM8j5q+vi+Dn4cltEsUzllvhc6z+E60BkFgRMoN2pvg4b+2kEdLc 8/UTqqjoNjvuux9xfk0C+zrSK2qafg3V6EFaNqH72M4yPjda99Oyfz/dvCEDprX0k1HS DrZyBNq+EFhgKuwLKWkocyvA8GpBTo15ng8BujYAXSCbCgBoK0lVGYUjRCzu1KRxtfDO O8/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=FS31aWbXLfnzm0y3kH5qaGkuGR4UR6nobSrtjnQw4EU=; b=IaKGG5Y5xgyghJaHqi/nvM9omCTVy4OQ5SEg2awCAAmZEHVuj0j9dU6zQ/+HaJhbVn cliSFFlnxq8B87I2RuS5ofYgsWZyBD0v40kAnDHNYtYDABI0My9PEQDpCurbd04OabEB VODbLGlSvIXGXoQ97aynYoxYNW6XiyWFF6ChFmi1IWEIZ8tHrJwgwpbNKqy80ojm18uN ZwWbKysFYS0CkuG4eE8GjnJUslApGzCB1TtT84kxOw9RP06PrsVmbedonuIIiU5MZ9oF hRGH5jj6LEKZ3jq9Il464hp+yzqQQhb9L5ofNPuwvl+OKs7ZiU59gaWOz6upN2HrvikJ VpsQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h27-20020a63121b000000b00503005a4f2fsi14909054pgl.857.2023.03.02.06.53.22; Thu, 02 Mar 2023 06:53:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230264AbjCBOsm (ORCPT + 99 others); Thu, 2 Mar 2023 09:48:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230114AbjCBOrz (ORCPT ); Thu, 2 Mar 2023 09:47:55 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01D5D126E4 for ; Thu, 2 Mar 2023 06:47:52 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXkDf-000456-Sz; Thu, 02 Mar 2023 15:47:43 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pXkDe-001Lse-U4; Thu, 02 Mar 2023 15:47:42 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pXkDd-001Zqg-9d; Thu, 02 Mar 2023 15:47:41 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Hans de Goede , Mark Gross Cc: kernel@pengutronix.de, Greg Kroah-Hartman , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 22/29] platform/x86: intel: mrfld_pwrbtn: Convert to platform remove callback returning void Date: Thu, 2 Mar 2023 15:47:25 +0100 Message-Id: <20230302144732.1903781-23-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> References: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1729; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=OG41i3sS4T3dTQzV9HEPZLUvI3D2MnBGxhm9QPceSMg=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkALbg9lEKjeaVD8wtq8wL8UjqxJ46eyp20lTtD SxmsWXcMW6JATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAC24AAKCRDB/BR4rcrs CfO/B/45kD3W0vEHIuGJdqj5KAIbCyTqJQwNCcmkpfQ2ddVpoxDCvGlVsIDKPTIlc1/f/uuxzUo hJPaNhNuZZRXrzrMV9YFpmRDCkTch8BTjxbNzvLCLlSTSamAJ6HR12FHq2MFa47d25NiSqvnGnT v/QTQ8K6JY//DpGdP8V16Aqk5X+y6DVH/NrykmbJCRre8PgQiUg9dEyOH4iOwD1mID8qDBuT9+o xkaV6NqSXmqhUVleqmOY4EKwY6aWmE17+SwfHiOURWk44d4XHAbtlpe2/Idoc97GMXaKlHr9FWm A+ulnzE5JhONxJ+5eidaNgqCnxIUCMu8Np14DYcKwK0mhoby X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759268114299713982?= X-GMAIL-MSGID: =?utf-8?q?1759268114299713982?= The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/platform/x86/intel/mrfld_pwrbtn.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/intel/mrfld_pwrbtn.c b/drivers/platform/x86/intel/mrfld_pwrbtn.c index d58fea51747e..549a3f586f3b 100644 --- a/drivers/platform/x86/intel/mrfld_pwrbtn.c +++ b/drivers/platform/x86/intel/mrfld_pwrbtn.c @@ -78,13 +78,12 @@ static int mrfld_pwrbtn_probe(struct platform_device *pdev) return 0; } -static int mrfld_pwrbtn_remove(struct platform_device *pdev) +static void mrfld_pwrbtn_remove(struct platform_device *pdev) { struct device *dev = &pdev->dev; dev_pm_clear_wake_irq(dev); device_init_wakeup(dev, false); - return 0; } static const struct platform_device_id mrfld_pwrbtn_id_table[] = { @@ -98,7 +97,7 @@ static struct platform_driver mrfld_pwrbtn_driver = { .name = "mrfld_bcove_pwrbtn", }, .probe = mrfld_pwrbtn_probe, - .remove = mrfld_pwrbtn_remove, + .remove_new = mrfld_pwrbtn_remove, .id_table = mrfld_pwrbtn_id_table, }; module_platform_driver(mrfld_pwrbtn_driver);