From patchwork Thu Mar 2 14:47:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 63450 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp4273977wrd; Thu, 2 Mar 2023 06:52:26 -0800 (PST) X-Google-Smtp-Source: AK7set/ZNaLiQq72pc31QRMmdA6c5DL5Jlz0VfvriWq9CDTyfbV4O76N7FkRMveLIAN3BvmcqXR8 X-Received: by 2002:aa7:9821:0:b0:5aa:9ef7:4f7f with SMTP id q1-20020aa79821000000b005aa9ef74f7fmr10481071pfl.9.1677768745880; Thu, 02 Mar 2023 06:52:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677768745; cv=none; d=google.com; s=arc-20160816; b=UQpmiuHWSQHSwonH+NymgOLPk3lpjmZgnU7m825+ZSBm3MKufRf+kOEET7+xYZ9kto 39EodTUoXww4NWg2nkBoaQhwhLvBCYodOCpx7aibFD4hobzQ404iF8UBC541q08aU100 moLR5huqSfwqqIUAlyeOacycjhpUyk7QGqo9tf/vRpjKgYPqni/yNn1IXd8h5YeIt0Br 9qRAzlZT75fvfKAkjkXy/fTfUd8sGQ1VPazViTRimTzATHsopOxwoLYNYwkKlXOTQa34 dX8u2YhIA/MxzjSlH9bq6Gid16dgPjSXClA0s8OhLI2I8KW9/5WcpUbHRMy3NLFcwbnq XBxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=BY1GjzQdjsCr0AOMmGTtclzcSYTxWYhADMhfvijIXLA=; b=gXCbjEpiMWVTKqklwGW5xofGId9a7bKoLALTg4ABM95An+HRV6FYLto4XGCiawPrdI K1JIYbPTFCJgoR7q8thP7kH7k/Mrey804atA7nc0d1vMqxfWMp4lsSyWQe2b+FeYD9kF MJ4EaiJniPCxzvmXyCbKAbNflIvABwCAiD0i2jiQk36WdZzKlJUELAkjRV/0uTsCenZ5 YM4adsuSwqWN0uZJK+TeJ+c8Ju0BX+txPKWG6LguPRZZgrir3iYxyOm98VvoNEKYkO25 XRMnbk9ldUNP1E5E3xQ1VMJKlG/0CyhCVVYBfzNjDN28zxdLnHZpeLB8q2BRHqk1axXV Pv1Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 127-20020a630585000000b004fb359820cfsi1309282pgf.573.2023.03.02.06.52.12; Thu, 02 Mar 2023 06:52:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229494AbjCBOrv (ORCPT + 99 others); Thu, 2 Mar 2023 09:47:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229971AbjCBOrt (ORCPT ); Thu, 2 Mar 2023 09:47:49 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 35F7F3E614 for ; Thu, 2 Mar 2023 06:47:47 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXkDZ-0003r6-VC; Thu, 02 Mar 2023 15:47:38 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pXkDY-001Lqs-Vp; Thu, 02 Mar 2023 15:47:36 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pXkDY-001ZpN-DZ; Thu, 02 Mar 2023 15:47:36 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: "Lee, Chun-Yi" , Hans de Goede , Mark Gross Cc: kernel@pengutronix.de, Greg Kroah-Hartman , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 01/29] platform/x86: acer-wmi: Convert to platform remove callback returning void Date: Thu, 2 Mar 2023 15:47:04 +0100 Message-Id: <20230302144732.1903781-2-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> References: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1687; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=Bm3IBa63g4dbgofO/bfNR14JENf89OQOoGmeXdiQOJc=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkALaFAqKKBbmCSVfcZrLlnzJ+gOTOoySP5usQ4 WnoEH90y2qJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAC2hQAKCRDB/BR4rcrs CabdB/0cg/Acoa8r2+suMRlOz0PBSjcB5VhhGvP3dYKuJ6A6dX4ci2tjWdyuwCSLSgMfbjT4G2H qKb6IyhR/ePsmIFeOd1uk42EcKfvfQ4foviGVtnN+Ca7oiq8mKAK4wOs9ApfiED0NqIpjZbHMVr r/hgcFtd3wUb8TtGZ/PLXHbHPG0q5PqLK+Doo2pCAFpFnLm8w468D5aRf7g21oDk3uLQdZ09AcJ pg+miSkuaMYOaMdihp2t7QzuqgVP6t7yLsmym+/LtkZMjsJobC6leuiuzFLZU6frDPCBjef9KmN xRqert54tYxk+AqnYb3G1YHhCmFnekROZJvSI3sMktGkxpt0 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759268040584672620?= X-GMAIL-MSGID: =?utf-8?q?1759268040584672620?= The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/platform/x86/acer-wmi.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c index ee67efdd5499..377a0becd1a1 100644 --- a/drivers/platform/x86/acer-wmi.c +++ b/drivers/platform/x86/acer-wmi.c @@ -2258,7 +2258,7 @@ static int acer_platform_probe(struct platform_device *device) return err; } -static int acer_platform_remove(struct platform_device *device) +static void acer_platform_remove(struct platform_device *device) { if (has_cap(ACER_CAP_MAILLED)) acer_led_exit(); @@ -2266,7 +2266,6 @@ static int acer_platform_remove(struct platform_device *device) acer_backlight_exit(); acer_rfkill_exit(); - return 0; } #ifdef CONFIG_PM_SLEEP @@ -2334,7 +2333,7 @@ static struct platform_driver acer_platform_driver = { .pm = &acer_pm, }, .probe = acer_platform_probe, - .remove = acer_platform_remove, + .remove_new = acer_platform_remove, .shutdown = acer_platform_shutdown, };