From patchwork Thu Mar 2 14:47:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 63454 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp4274196wrd; Thu, 2 Mar 2023 06:52:58 -0800 (PST) X-Google-Smtp-Source: AK7set9JDlxwg1ljsZ3A5p4IPRB22F8zJuVWytCzB2NTaVBrm7icjKid9keIpGI42hnop9n4KRdJ X-Received: by 2002:a17:902:e541:b0:19c:b4e3:c65b with SMTP id n1-20020a170902e54100b0019cb4e3c65bmr13743063plf.8.1677768778347; Thu, 02 Mar 2023 06:52:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677768778; cv=none; d=google.com; s=arc-20160816; b=y9kIOX14LdUbeMEyskcNExyIhEKPKyUMwHve8AQf/wuvyApz+sxggea8w+chBiTJGe 4cbw6v8SbN8nIj3cdxfrR2wm1Bqt++iVuZJ+eJzYnL/qOs3Fuu1zRPLi7G1H1D7ne4RG I3LSZ99HooolA3u/kIQZjd8Jj8QzHtEs32aRGvRddOKyjyj+XWiG3SfN+2M60MBxxbDn X+k8k9efo4ChPn7x3rTRM3AXYQS0su9BS6jX0YMEKFxsG+bEHLKuPbJsbGq4ufeLnRAK AvrY5HunQrH4JB9HMIQosp6nzU3x050TPqXiSZtMpswNtWZzt+NpZJHZQ7W+aVc5cssX 3KOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=CG7UA0O75wiGePLwH2n39njJ9sCDKH1xEm6qVulYbSU=; b=yqplEBW8nhtVKuXEyuZa1SxaRiLkDau0x7TwQtzF4fMhAapT0Zrw357i1q++HoDQzE Z4kJ1Ix4CSrwdxV7It+LW4IuHu1vg9WHrjNYXhSpvMnv4S/s8tRA7xCapFf35MdeBaLp SKSu0gwuOf7VmqCcVjcLB/dkLhVMYT/03S1hkYT0NdQiG38bQTlmQ6Vuew6+/Z6u8xZg e9hU57YWgeJVSXoHg4ulcitfqYpyqTDh93rufuHITWS/7dANPaIIk0iGCquC7H6T3AhE HefMnoqjnYbsw9x4KA4CXCsZ3hzLRMnd71q9SRpfXNM8VH5mllQX35kXZxQB2CRl8l6o E4HA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j64-20020a638b43000000b004fbd23110d5si16079309pge.546.2023.03.02.06.52.44; Thu, 02 Mar 2023 06:52:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230148AbjCBOsH (ORCPT + 99 others); Thu, 2 Mar 2023 09:48:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38492 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230029AbjCBOru (ORCPT ); Thu, 2 Mar 2023 09:47:50 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79AA946080 for ; Thu, 2 Mar 2023 06:47:48 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXkDd-0003uq-5f; Thu, 02 Mar 2023 15:47:41 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pXkDc-001Lrr-AU; Thu, 02 Mar 2023 15:47:40 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pXkDb-001ZqA-GP; Thu, 02 Mar 2023 15:47:39 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Ike Panhc , Hans de Goede , Mark Gross Cc: kernel@pengutronix.de, Greg Kroah-Hartman , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 14/29] platform/x86: ideapad-laptop: Convert to platform remove callback returning void Date: Thu, 2 Mar 2023 15:47:17 +0100 Message-Id: <20230302144732.1903781-15-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> References: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1806; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=pDk7jwubfCsGp7anhhTuGzgHcgasJat6lH0VGQp+ErA=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkALa+07KJdRSyk7nfg3tmGNvagCT7Zx6blt9rM yrKEDFTZruJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAC2vgAKCRDB/BR4rcrs CcFRCACclEPioKPU5ApA2tnEvuiryygWnK4+p6CHzE9W0Rov296G9pkCAcSYHNEKnNJAq33u0cH jMwJr6GJGSl3WNksR7vwutRP4E6TiCDBaTNVIMrrAMaudkVd8hHzjhWCKfYUOz2w8p7AGRy1wMR +fL1++K0uV+wNHu7eyvz/czEwiCgeBcMLACR2D1JkuzF24iKEJst9a0+E7icT6O639hZO/YBIM6 qWcHbDhvF5QXoHEnHODu6s4ohwIGomD8HxxDW+pDFTN6hHr48MRlSX93dvqU7w5egCnYMh1fWR2 WZpQmBzZxeBNnyhuNELTqGvCjmUgcT2gOSsPfaMn5CxjnSWo X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759268074614390605?= X-GMAIL-MSGID: =?utf-8?q?1759268074614390605?= The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/platform/x86/ideapad-laptop.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c index 0eb5bfdd823a..b5ef3452da1f 100644 --- a/drivers/platform/x86/ideapad-laptop.c +++ b/drivers/platform/x86/ideapad-laptop.c @@ -1921,7 +1921,7 @@ static int ideapad_acpi_add(struct platform_device *pdev) return err; } -static int ideapad_acpi_remove(struct platform_device *pdev) +static void ideapad_acpi_remove(struct platform_device *pdev) { struct ideapad_private *priv = dev_get_drvdata(&pdev->dev); int i; @@ -1942,8 +1942,6 @@ static int ideapad_acpi_remove(struct platform_device *pdev) ideapad_input_exit(priv); ideapad_debugfs_exit(priv); ideapad_sysfs_exit(priv); - - return 0; } #ifdef CONFIG_PM_SLEEP @@ -1970,7 +1968,7 @@ MODULE_DEVICE_TABLE(acpi, ideapad_device_ids); static struct platform_driver ideapad_acpi_driver = { .probe = ideapad_acpi_add, - .remove = ideapad_acpi_remove, + .remove_new = ideapad_acpi_remove, .driver = { .name = "ideapad_acpi", .pm = &ideapad_pm,