From patchwork Thu Mar 2 14:47:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 63439 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp4273464wrd; Thu, 2 Mar 2023 06:51:18 -0800 (PST) X-Google-Smtp-Source: AK7set8IRZ5lZATYd4ebZK++BS1t4HyHClfwraFglD3aSRt/Mz6/Hc8XTLFp70a4i8jESv9uGJpm X-Received: by 2002:a62:3281:0:b0:5a8:b419:9a51 with SMTP id y123-20020a623281000000b005a8b4199a51mr8655643pfy.26.1677768678628; Thu, 02 Mar 2023 06:51:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677768678; cv=none; d=google.com; s=arc-20160816; b=d8Qk4gFOBe7VVCUUVFf+KIlRoUTIJe2T9KYywSgS/4dLFf0bvkznnR+O5xAHz94EQV q39VwdlEHvcIAyDSwt7u10AGIfFKn8oe0gawOirFJnEVg86zxnQwSketa1ZOdjUAmD5H /6mnDvPEX+E2Dyr7cj5Cbxrc9n6DltXoIAHpqcF8P9m0/275jOaQP0Ou6Ta8hQo6mD5h O3SdQR0U7bbSjOi/jSJGFhm98n5vyx1RXWNL0oI5vND7G79PVC4KP4tdKutzbKhPV4iM keU/ubADngAHqa03oCVB15wkd9gh2y5eMjc3623rpCwfRPGlddUS3TzScl/+D9sZYz09 ZoCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=au3i0fTw6stwW9A8SxUQgQ2FLW0z8xninP1QnomJDto=; b=oSbFSmTfWwI+Wm+z51qR7MaR80sGPF7hIyc8y8RV7xMFsdbMJOanoHYWJugjkRAlVo oGDINLckoYrsCsVc1YakLEnLXZJ5FAI4HoRRTQRTI+KK6coBj8UaQRDKUi+Ab/H3PVHL hIiaoz5eN0umax5QadXvqNoIxkO1fpmWa1+ipQvgHcYgfOTIrKxrvV4JiTItfmsa2mvP P1ZKfZ9lGUvtzyVVNb3dXklVweKbpYk9PcTZzaIsNcoWwdvyUccZwdk+/CrxQKNuoLok T6rkAPbsBBzhqrFRibRMx3nqOKPzHC93ICmiU2K3FUNaEsPiEAbWG3KVlVXgR7hTi94Y Rw6w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z11-20020aa7888b000000b005a911448f76si16311122pfe.43.2023.03.02.06.49.51; Thu, 02 Mar 2023 06:51:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230126AbjCBOr4 (ORCPT + 99 others); Thu, 2 Mar 2023 09:47:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38468 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230019AbjCBOru (ORCPT ); Thu, 2 Mar 2023 09:47:50 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0738243937 for ; Thu, 2 Mar 2023 06:47:48 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXkDb-0003sE-TX; Thu, 02 Mar 2023 15:47:39 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pXkDb-001LrT-6Z; Thu, 02 Mar 2023 15:47:39 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pXkDa-001Zpp-D6; Thu, 02 Mar 2023 15:47:38 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Stuart Hayes , Hans de Goede , Mark Gross Cc: kernel@pengutronix.de, Greg Kroah-Hartman , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 09/29] platform/x86: dell: dcdbas: Convert to platform remove callback returning void Date: Thu, 2 Mar 2023 15:47:12 +0100 Message-Id: <20230302144732.1903781-10-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> References: <20230302144732.1903781-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1626; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=zWMnGRQm3Ty/zUvYwolgkenvaIlIv2W9jAYb7LshPlE=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkALal8iQzvOAk8kcRYck9HCN5PPyQOMhn4YqQ1 zNd2tx5CJSJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAC2pQAKCRDB/BR4rcrs CeOaCACCKUaaSpf8mPOFmwqSBnGsfK1pAU9t+R+XcdOeiK7oH7DLlQjM4lsfX9IDAVUpyg86Esf bgF1ndsG5SnGTJLNwxHwgozXPEj/r+fLMtml0IHpd6sQdCGnT9emqgKsYnWCO2oDb0cjs/GwZum C7hKUxmiWtjiTKtGUdurGVHS0YoKrdmVGWIRwfHzzzMfyCkg70M+6fk0bgK4jwpKVukAQJcRAYt hETFxolMfdkaoZ8O1yQhS5iXKL714j3Jx0L1xoA/AMShWEEl4ouKYJB249jbKkhCDp0ZFQ9TQud TcD/9LNcoHt8pPWct25/+HWmVNnad/al2gHPIuRTk/1f5Q1i X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759267970063892272?= X-GMAIL-MSGID: =?utf-8?q?1759267970063892272?= The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/platform/x86/dell/dcdbas.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/platform/x86/dell/dcdbas.c b/drivers/platform/x86/dell/dcdbas.c index 0ecb7b164750..76787369d7fa 100644 --- a/drivers/platform/x86/dell/dcdbas.c +++ b/drivers/platform/x86/dell/dcdbas.c @@ -698,12 +698,10 @@ static int dcdbas_probe(struct platform_device *dev) return 0; } -static int dcdbas_remove(struct platform_device *dev) +static void dcdbas_remove(struct platform_device *dev) { unregister_reboot_notifier(&dcdbas_reboot_nb); sysfs_remove_group(&dev->dev.kobj, &dcdbas_attr_group); - - return 0; } static struct platform_driver dcdbas_driver = { @@ -711,7 +709,7 @@ static struct platform_driver dcdbas_driver = { .name = DRIVER_NAME, }, .probe = dcdbas_probe, - .remove = dcdbas_remove, + .remove_new = dcdbas_remove, }; static const struct platform_device_info dcdbas_dev_info __initconst = {