Message ID | 20230302134922.1120217-2-linux@rasmusvillemoes.dk |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp4246226wrd; Thu, 2 Mar 2023 05:58:46 -0800 (PST) X-Google-Smtp-Source: AK7set+dzJwetJg6D8SWT2a4onY38o56dWE7fTqScXAHY+il/akPLXnx7UQqUeWuJ+nDNZlE5dWq X-Received: by 2002:a17:90b:3847:b0:230:c723:f37d with SMTP id nl7-20020a17090b384700b00230c723f37dmr11449767pjb.40.1677765526082; Thu, 02 Mar 2023 05:58:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677765526; cv=none; d=google.com; s=arc-20160816; b=jl7z1P2r6Z/SeiTGZOTu8pKhBHeJcAEIdO8BKlU8HtLXn+jOCPSmIh8VuGJE1dLten iSyo2iWW7yYcAeaUP2exG2jP0Hvd+nmCG87Z/f5hKGTgeoZwc/RD6Ebr7KsJvYt8GD9l 44mrO99nrMAfaRJuiOP9hks8Otbxk5bq/fcP2B2P90UxrB06GJeWa5H0eeWtZgTj9nz6 8YdK+RQJ6uPOfE8D03eIVSwJzDhfInP2bE+/utOZTdOVhuBAj22PDXLkr5zGwMkcMWwZ nwssAH1IO4ULcZ6dzEfiIJ9DsbSjbop02Iir1oql+vR4rKt0ksdjiqCVoLE9BB6nOwAb Wq7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=DFDandIs/wWW0RZ0s4trhSYP6hO5Cu+0LMuOOdJjn54=; b=Y5C0hGGMBJmBS6fFY0qBwZ+1V5OnmGj77TBFIi8CaZprgTExvbuBwSCfDKN1Baszb0 AbfEjJDozApcHuONqLB1NAYzsBHCiL/isg8C+xiE5Y/r+kZ1NIdSZfaUprowlfIqCsVl WV2uWQke89BR+sjZ87Iua/3cfhXPNGzY2CiSJuRMx6bhmcHjkymu7V0xQ+uKDC6uhfW4 iriURwz8eXjqKqkLz9DOnBMyouqklPD+fxc2Yyn+ZBtEnqGuyiVhCPRDvI5RUuKRPuWw d/KvzS0ynkvDbFbY8BdHlM90BeiY+ncF5G9RBGSPilf8v/JBeT+QkzsiDyw8dYgD3Z3C +Dvw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@rasmusvillemoes.dk header.s=google header.b=fXbfjLWD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p14-20020a63fe0e000000b00502eaf31c6bsi14307777pgh.43.2023.03.02.05.58.33; Thu, 02 Mar 2023 05:58:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@rasmusvillemoes.dk header.s=google header.b=fXbfjLWD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229947AbjCBNtn (ORCPT <rfc822;davidbtadokoro@gmail.com> + 99 others); Thu, 2 Mar 2023 08:49:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229941AbjCBNta (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 2 Mar 2023 08:49:30 -0500 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48E0015C8A for <linux-kernel@vger.kernel.org>; Thu, 2 Mar 2023 05:49:27 -0800 (PST) Received: by mail-lj1-x231.google.com with SMTP id g18so15524778ljl.3 for <linux-kernel@vger.kernel.org>; Thu, 02 Mar 2023 05:49:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DFDandIs/wWW0RZ0s4trhSYP6hO5Cu+0LMuOOdJjn54=; b=fXbfjLWD5wow0IgUIsNvtmgvsgvdaB+VuwBS8lvjPc9Lx2VeB4mNsRb9vqa/bnJYay SbpWcIAMNi27+vEfM8hjGIha5uuKybpDkJyt5r8v06Oj6Xa0HVL/2JuQ60O7B1bcSc5f cplg3BMrFPEGJ7q+C70RFKNoVB0FgDZUn99JM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DFDandIs/wWW0RZ0s4trhSYP6hO5Cu+0LMuOOdJjn54=; b=I4MWCwd+2pr1Kigv28VDVYoplX0VPocYSGqGzXnx8IrGhDLSPfaGcnKGZAXfgmIKlV VuTOJ8tIkYyV0sD7RdnS/0xKTdcrvT67oW6RgD+/li88StsWFUGTOITjgfekHG0JBsmo 8BJHrq3cvroaJiruHjnd7NHmJWGuOtG//0AYTIIOnF/fnDYZC+P2tDP/KklJ2O1ddvv7 o5G8XmvEwIUXO1Fyn0Sl44YCnCAzD5D6coU9gN0qm6hGFXN1z3j9l9opu6jt/PvHGJQJ dOlgZPOcAJEiDRu5nHgd91kxxqtCRVxQzvE2+6kiZS6iT6E0BFYjcg6ZHXR5ApCE60WM 2mVQ== X-Gm-Message-State: AO0yUKVcFx7fhQkl9EHige5tsX3XTXiC1/TQlfjXYLlQS6CuNKr5FvP7 G7R9RFjUSRG8+323XmO4UK6eOg== X-Received: by 2002:a2e:90d6:0:b0:295:c333:2a24 with SMTP id o22-20020a2e90d6000000b00295c3332a24mr3176109ljg.19.1677764965697; Thu, 02 Mar 2023 05:49:25 -0800 (PST) Received: from prevas-ravi.prevas.se ([81.216.59.226]) by smtp.gmail.com with ESMTPSA id s16-20020ac25ff0000000b004cb3e97bff8sm2139088lfg.284.2023.03.02.05.49.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Mar 2023 05:49:25 -0800 (PST) From: Rasmus Villemoes <linux@rasmusvillemoes.dk> To: Cosmin Tanislav <cosmin.tanislav@analog.com>, Lars-Peter Clausen <lars@metafoo.de>, Michael Hennerich <Michael.Hennerich@analog.com>, Jonathan Cameron <jic23@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> Cc: devicetree@vger.kernel.org, Rasmus Villemoes <linux@rasmusvillemoes.dk>, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] dt-bindings: iio: ad74413r: allow setting sink current for digital input Date: Thu, 2 Mar 2023 14:49:20 +0100 Message-Id: <20230302134922.1120217-2-linux@rasmusvillemoes.dk> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230302134922.1120217-1-linux@rasmusvillemoes.dk> References: <20230302134922.1120217-1-linux@rasmusvillemoes.dk> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759264664290600603?= X-GMAIL-MSGID: =?utf-8?q?1759264664290600603?= |
Series |
iio: ad74413r: allow setting sink current for digital input
|
|
Commit Message
Rasmus Villemoes
March 2, 2023, 1:49 p.m. UTC
Depending on the actual hardware wired up to a digital input channel,
it may be necessary to configure the ad74413r to sink a small
current. For example, in the case of a simple mechanical switch, the
charge on the external 68 nF capacitor (cf. the data sheet's Figure
34) will keep the channel as reading high even after the switch is
turned off again.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
.../devicetree/bindings/iio/addac/adi,ad74413r.yaml | 10 ++++++++++
1 file changed, 10 insertions(+)
Comments
On Thu, 02 Mar 2023 14:49:20 +0100, Rasmus Villemoes wrote: > Depending on the actual hardware wired up to a digital input channel, > it may be necessary to configure the ad74413r to sink a small > current. For example, in the case of a simple mechanical switch, the > charge on the external 68 nF capacitor (cf. the data sheet's Figure > 34) will keep the channel as reading high even after the switch is > turned off again. > > Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> > --- > .../devicetree/bindings/iio/addac/adi,ad74413r.yaml | 10 ++++++++++ > 1 file changed, 10 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml: patternProperties:^channel@[0-3]$:properties:drive-strength-microamp: '$ref' should not be valid under {'const': '$ref'} hint: Standard unit suffix properties don't need a type $ref from schema $id: http://devicetree.org/meta-schemas/core.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230302134922.1120217-2-linux@rasmusvillemoes.dk The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
diff --git a/Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml b/Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml index 9eb3ecc8bbc8..fcae300182f7 100644 --- a/Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml +++ b/Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml @@ -101,6 +101,16 @@ patternProperties: When not configured as a comparator, the GPO will be treated as an output-only GPIO. + drive-strength-microamp: + $ref: /schemas/types.yaml#/definitions/uint32 + description: | + For channels configured as digital input, this configures the sink + current. + minimum: 0 + maximum: 1800 + default: 0 + multipleOf: 120 + required: - reg