| Message ID | 20230301100930.3519883-1-kumaravel.thiagarajan@microchip.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp3546262wrd;
Wed, 1 Mar 2023 02:12:13 -0800 (PST)
X-Google-Smtp-Source:
AK7set+Mf9B79vn4Xz02H6be38X/AupSGgPcIxQx+MVc1a90cM1k/ArFywldXLn13bKLyKiJnv7w
X-Received: by 2002:a62:5bc6:0:b0:5d3:81b4:db5c with SMTP id
p189-20020a625bc6000000b005d381b4db5cmr5189488pfb.4.1677665532964;
Wed, 01 Mar 2023 02:12:12 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1677665532; cv=none;
d=google.com; s=arc-20160816;
b=ww2ajSbssHyPrV1RB81RIf8IBTZfvrk3lPzHTTAO4yjHNsYMzEGA2I/XPkLiclkX0u
3Rh8ZrnD/tpuNcHMn58u7YSRS0rSIJmq/5mkc6SROJy0vWQgwuj06wywSeoBYfbF16d/
HcbnMiSIJ7kkdyRzASOKQyzV6TgR/BF7WGSUIbD8j8j75IGIgfml97dK9saCUovWxx+0
fAW38uZAXlzH8Cj4YuPXc77OyE5GY+nVuMU/+b3wk+ySjui6AeMHl/myW1dUFZXNTvlN
RJu70co5IsLfFQ2dqnP9Y7skxeBgZ2MCfKoA0zibxpQqFMxAMlXXL7gQPo6hmatc/5BF
Ymgg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from:dkim-signature;
bh=XBMXEQwK+MGoPWMbK7Hl3VCsJYkLfyUvflqIH/DYYmI=;
b=xFGYg9MH6N7I2MYIJ8QcGS9SwnqP28RdIP/Nt5qrXnfvf0wZ25CMS+HlM/6XdK3emu
WH6zej/yuiBAfX+KuwnNBCgG6W+UqYgpFbDCdXl7n179uJEgy8PBCzodiCXNFuppAeNg
4IueV+m09D0xWS8XoanE59KXIk7nY7g3N/Zm5xAcp4dEqSv4oRBZ23vgez7T0JjEaowk
dT255xIFswNgv+8DeCv/ihwW8IT3VgZoQ2bRa6YoErt1HXuf6Py+m7Pe8K31desV/81h
iUIg7nWb+KsyYd5b5xRs4AZMss8zM0gyryZXsfXD+UTEhNCem7AFb+YKvcnI3YPjbRJh
CqgA==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@microchip.com header.s=mchp header.b=bwbpNxDt;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE)
header.from=microchip.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
w4-20020a056a0014c400b005a8ee84ba02si12414288pfu.310.2023.03.01.02.12.00;
Wed, 01 Mar 2023 02:12:12 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@microchip.com header.s=mchp header.b=bwbpNxDt;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE)
header.from=microchip.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S229712AbjCAKJ5 (ORCPT <rfc822;dipsyhu@gmail.com> + 99 others);
Wed, 1 Mar 2023 05:09:57 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58514 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229834AbjCAKJg (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Wed, 1 Mar 2023 05:09:36 -0500
Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com
[68.232.154.123])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01FAA196B3;
Wed, 1 Mar 2023 02:09:32 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp;
t=1677665372; x=1709201372;
h=from:to:cc:subject:date:message-id:mime-version:
content-transfer-encoding;
bh=L21mfnwG2tG1rkVD0UVEhu+U7/OYan2vtpwho9OQe+k=;
b=bwbpNxDtBXrb9qxsNI91JHsQ1sCCqKKpymZAfToxGFJnjfhlLjIpcfzY
Acj5Fu/N1+Eb/allR1o/d9e/qympgc6rc1HCDJq9lO100AVZPKzYuxpvD
z4V9NEmwhUznM1/KBOnp+m8N8+pMOD8xXm/s+ECV+HBojn90q/oFuF4JS
cx0N+U7pO9S7atYrcB2JTEmMrts87PRsCr/hkfyIAixbyoghQ3cmkNeLD
fKuUwHM1l1JTr0dg/JKb74XzupyB/IR/NfihtIl2ZPWC21wq/QGS14vcx
FroZGSL1M7y2TGhlGbIYYlGNkXpkXhYDT5PBOGEbjCM/qf3LJF0EQ+d42
Q==;
X-IronPort-AV: E=Sophos;i="5.98,224,1673938800";
d="scan'208";a="202983394"
Received: from unknown (HELO email.microchip.com) ([170.129.1.10])
by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256;
01 Mar 2023 03:09:20 -0700
Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by
chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2507.16; Wed, 1 Mar 2023 03:09:17 -0700
Received: from CHE-LT-UNGSOFTWARE.microchip.com (10.10.115.15) by
chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server id
15.1.2507.16 via Frontend Transport; Wed, 1 Mar 2023 03:09:14 -0700
From: Kumaravel Thiagarajan <kumaravel.thiagarajan@microchip.com>
To: <gregkh@linuxfoundation.org>
CC: <jirislaby@kernel.org>, <andriy.shevchenko@linux.intel.com>,
<ilpo.jarvinen@linux.intel.com>, <deller@gmx.de>,
<geert+renesas@glider.be>, <phil.edworthy@renesas.com>,
<matthew.gerlach@linux.intel.com>, <linux-serial@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH tty-next] serial: 8250_pci1xxxx: Disable SERIAL_8250_PCI1XXXX
config by default
Date: Wed, 1 Mar 2023 15:39:30 +0530
Message-ID: <20230301100930.3519883-1-kumaravel.thiagarajan@microchip.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1759159814083440371?=
X-GMAIL-MSGID: =?utf-8?q?1759159814083440371?=
|
| Series |
[tty-next] serial: 8250_pci1xxxx: Disable SERIAL_8250_PCI1XXXX config by default
|
|
Commit Message
Kumaravel Thiagarajan
March 1, 2023, 10:09 a.m. UTC
Disable SERIAL_8250_PCI1XXXX config by default
Signed-off-by: Kumaravel Thiagarajan <kumaravel.thiagarajan@microchip.com>
---
drivers/tty/serial/8250/Kconfig | 1 -
1 file changed, 1 deletion(-)
Comments
On Wed, Mar 01, 2023 at 03:39:30PM +0530, Kumaravel Thiagarajan wrote: > Disable SERIAL_8250_PCI1XXXX config by default Why? Please read the kernel documentation for how to write a good changelog text. > > Signed-off-by: Kumaravel Thiagarajan <kumaravel.thiagarajan@microchip.com> What commit id does this fix? thanks, greg k-h
On Wed, Mar 01, 2023 at 12:25:06PM +0100, Greg KH wrote: > On Wed, Mar 01, 2023 at 03:39:30PM +0530, Kumaravel Thiagarajan wrote: > > Disable SERIAL_8250_PCI1XXXX config by default > > Why? > > Please read the kernel documentation for how to write a good changelog > text. Kumaravel, hint for you: Take what Linus had written in the discussion of Greg's pull request. It mainly explains it all. > > Signed-off-by: Kumaravel Thiagarajan <kumaravel.thiagarajan@microchip.com> > > What commit id does this fix? Another hint: this lacks so called Fixes tag. You may read about it in the documentation.
> -----Original Message----- > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Sent: Wednesday, March 1, 2023 9:23 PM > On Wed, Mar 01, 2023 at 12:25:06PM +0100, Greg KH wrote: > > On Wed, Mar 01, 2023 at 03:39:30PM +0530, Kumaravel Thiagarajan wrote: > > > Disable SERIAL_8250_PCI1XXXX config by default > > > > Why? > > > > Please read the kernel documentation for how to write a good changelog > > text. > > Kumaravel, hint for you: Take what Linus had written in the discussion of > Greg's pull request. It mainly explains it all. Thank you, Andy. I will do this. > > > > Signed-off-by: Kumaravel Thiagarajan > > > <kumaravel.thiagarajan@microchip.com> > > > > What commit id does this fix? > > Another hint: this lacks so called Fixes tag. You may read about it in the > documentation. Thank you for this too. I somehow missed this. Regards, Kumar
diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig index 978dc196c29b..cbf11147dc89 100644 --- a/drivers/tty/serial/8250/Kconfig +++ b/drivers/tty/serial/8250/Kconfig @@ -299,7 +299,6 @@ config SERIAL_8250_PCI1XXXX tristate "Microchip 8250 based serial port" depends on SERIAL_8250 && PCI select SERIAL_8250_PCILIB - default SERIAL_8250 help Select this option if you have a setup with Microchip PCIe Switch with serial port enabled and wish to enable 8250