From patchwork Tue Feb 28 13:55:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 62506 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp3031121wrd; Tue, 28 Feb 2023 06:04:35 -0800 (PST) X-Google-Smtp-Source: AK7set9ERyzsgLgBLgGAdKiE3mCeD9402bOrYnfWeGCujdIG20vcNfyWUnF5FOT01sDZHS4T2Ze2 X-Received: by 2002:a17:907:6e14:b0:8ea:5f7d:8fec with SMTP id sd20-20020a1709076e1400b008ea5f7d8fecmr3583365ejc.36.1677593075026; Tue, 28 Feb 2023 06:04:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677593075; cv=none; d=google.com; s=arc-20160816; b=NoumYmrlFUD2txTaWlN4U/hlhov5QF6eb/TWsQk45/6X1i50b+9RLRtwcn6w09qRIl r3/BWo8NR2PDJLRWR2A11ta8yn87CFe8kUxqT+vl0ZvDL9efiWJax+klc6zDn4DB/g2E RixIgZYEhtwCVLW4WcgmcK4uZ39Qjsa/BN6z8L774S71OdS0KYKNpKgIaVV+yzOV1Htv 992bYXdxW7QsWBzXdaTVEISxZGSitaYUAD8E7Je7yE2TF7O5viuGiy4A/PenL3TRWXkY b4L17Rv4m4EV9rh7Dq44vUSvfjmdsvDA2y+MleDaTWJJ0W9BaKfnz185ZgalMm+hhLu3 b4Ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=O7+O1kKSy+uWznDTb7JHVKvwAgPzJFp/5DKHS/EQre4=; b=kik3+Ep+qbTyWCYNc3RkX5NKeTkt9o3N2o8tWJWvPa4qjK59w8SEz8p/zaE4rHMjOA subYJ0YEr3pJXXeX+0ooOJl7aCAssfT6l/6nFfY81AEqYUdu3AxNM68O1wSMSMtrtyOp jMYxeUhfTSxNRi8isU/UfDl65qespOGNfJ3V4ivZ4apWS/vIvWrgyLJnTGMp5SsWWzQT CEQmTR9gg9+YWVhhNkouJPjYVwmS2EByVP8lITYhH/HiK0E50IUqIo3BgCGxjHbhFq2U CD3X7R86xkNSQB1NnRDkAYbg1kzchx4WOOZRZXt4X7T2mwgl83Ju7N+lW7osULiaOtuu tgDw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e17-20020a170906045100b008b79a5e743esi11304534eja.253.2023.02.28.06.04.11; Tue, 28 Feb 2023 06:04:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229524AbjB1N4N (ORCPT + 99 others); Tue, 28 Feb 2023 08:56:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229730AbjB1N4M (ORCPT ); Tue, 28 Feb 2023 08:56:12 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 782CF303E0 for ; Tue, 28 Feb 2023 05:55:51 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pX0Ru-0007wr-FS; Tue, 28 Feb 2023 14:55:22 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pX0Rr-000sd5-Fv; Tue, 28 Feb 2023 14:55:19 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pX0Rq-0011dd-QM; Tue, 28 Feb 2023 14:55:18 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Thierry Reding , Munehisa Kamata , Jiancheng Xue , yuanjian , Rob Herring Cc: linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 1/4] pwm: hibvt: Explicitly set .polarity in .get_state() Date: Tue, 28 Feb 2023 14:55:05 +0100 Message-Id: <20230228135508.1798428-2-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230228135508.1798428-1-u.kleine-koenig@pengutronix.de> References: <20230228135508.1798428-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=851; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=wc4XckGFK16wdwJ/Xdl4epfiuvV/IHKkEC7JDlgUzKg=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBj/ges5DcD7InG+a9Dcii0vkRG0Z2rq8uudNNyL 1Dofr+8NjmJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCY/4HrAAKCRDB/BR4rcrs CTpaB/9LfzC8uQW9dLE0QEXLyQCUYsDAve9IntGqd6uLK6z8NZWmNYwkIkLnjwGQwqfIhpFtqp6 Xnc1NpZ0eQ5nAt2aPVu1lQRlXyI68NBtxE/xNf3sOpgrXpEU8CrGcSZ6BIiQ15g89hDuJAE/Bo1 vv76KL8LkxsVwcKgkTmBsKvhtNTZt+z0mC+6qCy+H9IIZZNfI0exVgaqF6OdjkEnJxz37AihCQf BJCrCJpn/98xLdjb08QXoRntq11gc4c7LU13hCJTPuQpkvQPqmqgS7FRLjjPp856CDHszepDKBp 7u17LXuJL6J6y2+sXxOnD3qxOrzjdnsblZ9FVgRlbt/iD0AQ X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759083836220713336?= X-GMAIL-MSGID: =?utf-8?q?1759083836220713336?= The driver only both polarities. Complete the implementation of .get_state() by setting .polarity according to the configured hardware state. Fixes: d09f00810850 ("pwm: Add PWM driver for HiSilicon BVT SOCs") Signed-off-by: Uwe Kleine-König --- drivers/pwm/pwm-hibvt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pwm/pwm-hibvt.c b/drivers/pwm/pwm-hibvt.c index 12c05c155cab..1b9274c5ad87 100644 --- a/drivers/pwm/pwm-hibvt.c +++ b/drivers/pwm/pwm-hibvt.c @@ -146,6 +146,7 @@ static int hibvt_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm, value = readl(base + PWM_CTRL_ADDR(pwm->hwpwm)); state->enabled = (PWM_ENABLE_MASK & value); + state->polarity = (PWM_POLARITY_MASK & value) ? PWM_POLARITY_INVERSED : PWM_POLARITY_NORMAL; return 0; }