Message ID | 20230228114306.3328235-16-shikemeng@huaweicloud.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2791592wrd; Mon, 27 Feb 2023 19:44:12 -0800 (PST) X-Google-Smtp-Source: AK7set/mQJzGpZKAOi42ML+i+zf8B7KaBfzFMKQeSrgqIrzCRUHxJG22Sb6Bmp8JhKIByr0PZHhV X-Received: by 2002:a05:6402:500b:b0:4af:62ad:60a2 with SMTP id p11-20020a056402500b00b004af62ad60a2mr2027203eda.0.1677555852101; Mon, 27 Feb 2023 19:44:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677555852; cv=none; d=google.com; s=arc-20160816; b=KYlB77AlsXqneg8/acfZFRHZiCxulrA4N8jSaQsdWu1RHhiTB/4wsa8KLzuSz+3SWW 957MEs9XTuZjraZOB3H1yoEPMMy1mE2KPWQe+nzoH7i7mvFqkQRPimDMHdGpb++zJLWX FXrD+fEDG28RQO1rkyHh5Eqe98fyv2GrbcX9d9u1Jtp5xykeC0qDWLCjjGfpP7skeVTX IZS+tdsElaKpybJGvU6dZPSYQruVJg8AUGlZ2hFJ6VeavLpDQ8kiyOnZUhdCFYs1u8X2 6+mfyUJTrXMVdzb97VHE47vieHjbeNXHAu+kMVCnPEZo6fLTYQrN8Sj+XUCjqp696dRi v+rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=ulkPseg6nUOHD8UcQ/QCQ3CsypGqjnYVoYPydNZDjf0=; b=r2iqnPfN9jpqm8LErYkPUoA3FU1IJpTlNXcQMODbMOZa48SvWLzKLnjrLzuSl+EqP5 IWP3SHN5VKhZzdxidI9WqsSCjrsXCLX7wQ6dvRDKbp5GTH0OLEQc/B//GTZD8jir49a7 VAo/EQrQwlgDYWaAuLNGKm4zdgfzweqP9oxGhvZar19wEp718312/cJXnU0B6Jjp5uTy c2F+mxNgm4lPF9xaGUyJTgl8fKCwZTQxRrBttz5YLN+uA9F9Lg7Fx+mCtijrzvpxkE3t 3HkHPoY+HkPlD8h8tbDEgizhSpITn0y3aohyzIT6QDy1bcsN+JJqioBZwnJFTHp+tOpJ 94lQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bf3-20020a0564021a4300b004a0a7d851f5si10606189edb.634.2023.02.27.19.43.49; Mon, 27 Feb 2023 19:44:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230283AbjB1Dm1 (ORCPT <rfc822;liqunnana@gmail.com> + 99 others); Mon, 27 Feb 2023 22:42:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230169AbjB1Dlj (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 27 Feb 2023 22:41:39 -0500 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 659C4241E6; Mon, 27 Feb 2023 19:41:38 -0800 (PST) Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4PQjpQ02wxz4f3pBq; Tue, 28 Feb 2023 11:41:34 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP2 (Coremail) with SMTP id Syh0CgDnjOrod_1jpDeZEQ--.58449S17; Tue, 28 Feb 2023 11:41:35 +0800 (CST) From: Kemeng Shi <shikemeng@huaweicloud.com> To: tytso@mit.edu, adilger.kernel@dilger.ca, jack@suse.cz, ojaswin@linux.ibm.com, ritesh.list@gmail.com Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, shikemeng@huaweicloud.com Subject: [PATCH v2 15/20] ext4: remove unnecessary exit_meta_group_info tag Date: Tue, 28 Feb 2023 19:43:01 +0800 Message-Id: <20230228114306.3328235-16-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20230228114306.3328235-1-shikemeng@huaweicloud.com> References: <20230228114306.3328235-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: Syh0CgDnjOrod_1jpDeZEQ--.58449S17 X-Coremail-Antispam: 1UD129KBjvdXoW7XFWUGrW5WF4rKr45Aw47Jwb_yoWDZwbEya yxJF48Wr48Jr1fJa10g39xtr48tF4rAr1DXF43t3y3XF1DWrs5u3WkArnxZrZruay7AFyY yr93JryxJF1IqjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbqxFF20E14v26rWj6s0DM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M280x2IEY4vEnII2IxkI6r1a6r45M28IrcIa0xkI8V A2jI8067AKxVWUAVCq3wA2048vs2IY020Ec7CjxVAFwI0_Xr0E3s1l8cAvFVAK0II2c7xJ M28CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW7JVWDJwA2z4x0Y4vE2I x0cI8IcVCY1x0267AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK 6I8E87Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4 xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8 JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20V AGYxC7MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAF wI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUtVW8ZwCIc4 0Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r4j6ryUMIIF0xvE2Ix0cI8IcVCY1x0267AK xVW8Jr0_Cr1UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVW8JV WxJwCI42IY6I8E87Iv6xkF7I0E14v26r4UJVWxJrUvcSsGvfC2KfnxnUUI43ZEXa7sRiVb yDUUUUU== X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_00,DATE_IN_FUTURE_06_12, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759044804962841018?= X-GMAIL-MSGID: =?utf-8?q?1759044804962841018?= |
Series |
Some bugfix and cleanup to mballoc
|
|
Commit Message
Kemeng Shi
Feb. 28, 2023, 11:43 a.m. UTC
We goto exit_meta_group_info only to return -ENOMEM. Return -ENOMEM directly instead of goto to remove this unnecessary tag. Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> Reviewed-by: Ojaswin Mujoo <ojaswin@linux.ibm.com> --- fs/ext4/mballoc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index c637d0a89e2e..1175c81f8e2d 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@ -3069,7 +3069,7 @@ int ext4_mb_add_groupinfo(struct super_block *sb, ext4_group_t group, if (meta_group_info == NULL) { ext4_msg(sb, KERN_ERR, "can't allocate mem " "for a buddy group"); - goto exit_meta_group_info; + return -ENOMEM; } rcu_read_lock(); rcu_dereference(sbi->s_group_info)[idx] = meta_group_info; @@ -3123,7 +3123,6 @@ int ext4_mb_add_groupinfo(struct super_block *sb, ext4_group_t group, group_info[idx] = NULL; rcu_read_unlock(); } -exit_meta_group_info: return -ENOMEM; } /* ext4_mb_add_groupinfo */