Message ID | 20230228112238.2312273-20-daniel.lezcano@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2956207wrd; Tue, 28 Feb 2023 03:27:58 -0800 (PST) X-Google-Smtp-Source: AK7set9yEhkfx7MlQQwcRn9ttvcu5enPE+gIe3AILQLJF0u1qVLGcFsWdR5L14pRYJbMArKMO2kE X-Received: by 2002:a17:90b:4b04:b0:229:649a:9a05 with SMTP id lx4-20020a17090b4b0400b00229649a9a05mr3038971pjb.11.1677583677852; Tue, 28 Feb 2023 03:27:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677583677; cv=none; d=google.com; s=arc-20160816; b=h/VR33bl+WBmxlDiKE6Gc2WX/Pu6i/Oz3gl9/9EjpJ1mbx/TZchmIoXkYzb/0V1Gum Fcdywaf89drLh5ahJc5FxBJdMs8aToOeDpd0ydhNTZW48DrGDcjaBq1yRco6FY1pgRWt OQob/OeSBLv6E7RFxELgpA6dE2ofdBlc6b3z2Sv1z2k1/N+z0NV5vDEqkhzooIVXoIwf FOsHToUEC42QQUUFkqT0cCRk659/j4XP8D9cEm+4cifXOf0nIdEdUjMIXtpX2c737RjY I+u5PFD2m0Qs5ay4h6I7ebYjlmr39nciE8YeKwcnVDyosHSEIYsRelwiA4HRmMAqorPH vYIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=FS5MMzUrtYY5N2w5QCadh2L/6Lyuv9jfcaqNKoRqTRU=; b=h/Kx1zD4IZrWH+ZET2u9mMbTF0PJVHMkvTDFFor3pWot+BG++JMxJDtcwz9ZgA+cnE +WeJzlnqC4xEtLi5dBdenWk3zjx6Kj2LRQCQwyuGyulEtU4+tWdi6Tid3Z19nflAncZR Slf6d9JJXKPdeY0ocfeqlmGO342qBzgnTlMdGqEFOMtHx0Tz2qWsFpk344EFS9Sh/DbK sxovFL3c6Fbigbc3CXIv08EgadifFN9nLjpQTqTHqMa1ijnRVjji1nfaLTQnv6iAxBhU XewRrK4t9Kh3sn/ZpxJx8fgoE98z76Zjcs7P+kVhozPWs9sGKQo47JrnoxugvNuPiWmC U8vA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wmROP6Ay; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 31-20020a63135f000000b004faeaf65ba0si9364476pgt.800.2023.02.28.03.27.44; Tue, 28 Feb 2023 03:27:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wmROP6Ay; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231589AbjB1LZE (ORCPT <rfc822;brysonjbanks@gmail.com> + 99 others); Tue, 28 Feb 2023 06:25:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231586AbjB1LYV (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 28 Feb 2023 06:24:21 -0500 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0BD022DCD for <linux-kernel@vger.kernel.org>; Tue, 28 Feb 2023 03:23:49 -0800 (PST) Received: by mail-wr1-x42d.google.com with SMTP id r18so9357083wrx.1 for <linux-kernel@vger.kernel.org>; Tue, 28 Feb 2023 03:23:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1677583423; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FS5MMzUrtYY5N2w5QCadh2L/6Lyuv9jfcaqNKoRqTRU=; b=wmROP6AyQSd/5lYDaTnJSUSDXdhXDdPFq6dWXSe77IejOrFttF3d59ytNrebe9bWZD 7G9JvxGcOZeqMgxxKGV78ZWGnj3tWGl5eHJp0AcWtzyoe3qEdHGW6yN3eVOEs00SdMev 1IXw0FeceljNrRpqTqA3WpAol75g+SiSq2TGI265YAs4USbddI0OBs2VZkN0y81+KQJC ag97hXN8hnVLeuV73nCVIlwWV1IJwsGLMorSpUivU/zZYBwtgadH+UPfQvbdnBvBiY/w nya+SL8nqgkYI8Z5tKMI0O3fcuoPiU9Z1AjYwN6Z44iSGmqj9rWQctC5xBwHXC8HoLf1 f5Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677583423; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FS5MMzUrtYY5N2w5QCadh2L/6Lyuv9jfcaqNKoRqTRU=; b=2FUBuTBEz1Nr1VGDS+5j+Jhj+xq4NrQWR0d1MjEYOQWKITzjp56M7ofsluIhJEqCMG qJS5idgsnq28qJ2/LNqs7p/ofQu5mY7vnIUGr1d96zGe4gwslaQtNc7nnGxEVlKCdSnI KOn5O7ewCZgYHRNzJf7cWXZhO6kCCcevCTM8oHRagFJo7O1t22Ny3wOsz8BwyY5ZdxYb dObclxENDALT7Sql8R/PWO/VTxqPszczAS5ulUwtaWfRkz+DA0hAEJIMu0qE3zXHs+uY Spti4H6NyMYLbdYDOTFMEGJf/dYV04phyFDH0fWkmEq2yd4O9NRW3pJfhJlBUlreOF1a gSqg== X-Gm-Message-State: AO0yUKXpMBpzoTuD2a+EkPwDpQ1jWPZLVnOHCF0rNNdVMqsj2Z1YNckS dpyH67tMdz5XiqDhLjC2A7Kjvw== X-Received: by 2002:a5d:63c6:0:b0:2c9:e34e:7d0 with SMTP id c6-20020a5d63c6000000b002c9e34e07d0mr2243434wrw.3.1677583422966; Tue, 28 Feb 2023 03:23:42 -0800 (PST) Received: from mai.box.freepro.com ([2a05:6e02:1041:c10:6830:6390:2815:b6a5]) by smtp.gmail.com with ESMTPSA id z5-20020a5d6545000000b002c5501a5803sm9598130wrv.65.2023.02.28.03.23.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Feb 2023 03:23:42 -0800 (PST) From: Daniel Lezcano <daniel.lezcano@linaro.org> To: rafael@kernel.org, daniel.lezcano@linaro.org Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Kaestle <peter@piie.net>, Hans de Goede <hdegoede@redhat.com>, Mark Gross <markgross@kernel.org>, platform-driver-x86@vger.kernel.org (open list:ACER ASPIRE ONE TEMPERATURE AND FAN DRIVER) Subject: [PATCH v4 19/19] thermal/drivers/acerhdf: Remove pointless governor test Date: Tue, 28 Feb 2023 12:22:38 +0100 Message-Id: <20230228112238.2312273-20-daniel.lezcano@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230228112238.2312273-1-daniel.lezcano@linaro.org> References: <20230228112238.2312273-1-daniel.lezcano@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759073982396909664?= X-GMAIL-MSGID: =?utf-8?q?1759073982396909664?= |
Series |
Self-encapsulate the thermal zone device structure
|
|
Commit Message
Daniel Lezcano
Feb. 28, 2023, 11:22 a.m. UTC
The thermal zone parameter specifies the bang-bang governor. The Kconfig selects the bang-bang governor. So it is pointless to test if the governor was set for the thermal zone assuming it may not have been compiled-in. Remove the test and prevent another access into the thermal internals. Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> Acked-by: Peter Kaestle <peter@piie.net> --- drivers/platform/x86/acerhdf.c | 7 ------- 1 file changed, 7 deletions(-)
diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c index 61f1c3090867..71b9c1f922d9 100644 --- a/drivers/platform/x86/acerhdf.c +++ b/drivers/platform/x86/acerhdf.c @@ -697,13 +697,6 @@ static int __init acerhdf_register_thermal(void) if (ret) return ret; - if (strcmp(thz_dev->governor->name, - acerhdf_zone_params.governor_name)) { - pr_err("Didn't get thermal governor %s, perhaps not compiled into thermal subsystem.\n", - acerhdf_zone_params.governor_name); - return -EINVAL; - } - return 0; }