From patchwork Tue Feb 28 15:24:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 62524 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp3080140wrd; Tue, 28 Feb 2023 07:27:44 -0800 (PST) X-Google-Smtp-Source: AK7set/QrIm6ICS7uQQ2cMiHgrOnj/SYh1t85vL3u9h5CT0J+Gqpd4mOU6bDyvgHN9LnY1Xd7QD3 X-Received: by 2002:a17:906:ac6:b0:8af:5403:992d with SMTP id z6-20020a1709060ac600b008af5403992dmr2901222ejf.28.1677598064640; Tue, 28 Feb 2023 07:27:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677598064; cv=none; d=google.com; s=arc-20160816; b=eNLh68zByG4j90o/nMfI3NjjEMYZ8uOgqd3tuDDJuKboyn7eGJc0+OBqXRrWpFHNhg AHafgVomFpeEt0czbG3dCykIphrJhrPzccjgM5CqrvBeIs7dnP+Q/T7vdwca4kPADoDl a2wtrJYgwrbPvOLwuUdLEqBQkDShzeGG0XnsPQnWFMCFvVmkfxfjC02g5qir85qqDEbj sF1RQw0vEnMv4RYimE9B7sRuQIAIaBGZ91i9NQ9tZ1lWKG3ARlx+w1aXmmXqVt7uz9fu RdOtklITPBYe1+Kv6/3qfJeDWclGEJPRuOEegLJvV0pu6bxlo2LYMgWDPcuJQ4DfnXyC 5tQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=Ouo8uuwT0BL/iQ4qXVVvn9es2W+dnKtqVS64weaqnUQ=; b=rqFM3hTgxg5Yur3+KxcYLixvwq/iJBOTy4/kbeMM0bFI3mboOSuVGDZuwTXZmzmVRn lTMChp/G64FPecK+fJnM6A+VPwyHkZUzR7BTlDL6q4X42LH4vXUuC2nLMam23NDd+r5G d8+WqV5u9a7HnSnacI8dslUjbttEho8rEf3Pb/FdSmvrwZRikX3uYtOddCls3zfsf/Zq tL2IXxktklmxMw5zyLaXEslpW+jAHHm8XMosvg2HNyC01id0KcO1ZWBcyBrQazgswVeB XpFKxAaGXJGqfSqCxRDexfyTdEi8uTyoHpzpywfhFe4j4l9NMQu73S7XX8d7qf/ZjH3F 9nVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MXojN0LQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s25-20020a170906961900b008b177beb99esi9969551ejx.363.2023.02.28.07.27.22; Tue, 28 Feb 2023 07:27:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MXojN0LQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229982AbjB1PZB (ORCPT + 99 others); Tue, 28 Feb 2023 10:25:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40078 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229749AbjB1PYm (ORCPT ); Tue, 28 Feb 2023 10:24:42 -0500 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66F0B241CF for ; Tue, 28 Feb 2023 07:24:40 -0800 (PST) Received: by mail-lf1-x135.google.com with SMTP id bi9so13729751lfb.2 for ; Tue, 28 Feb 2023 07:24:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1677597880; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Ouo8uuwT0BL/iQ4qXVVvn9es2W+dnKtqVS64weaqnUQ=; b=MXojN0LQNc12UfetxbjfKcOeN3fOc8ssW4PDbnrCCAwiuiISZAMi8iZJXruAU5Dzsy dheXR6o+/1DWsozRRmd1phRIQHszUZRdmmxGq1r8y+oqBrrOQfenBMSxH2R/soLlXnqE Ru3OgG5WZFHRniWrMaM4viC7ymV85fEM3Yqt+jjhDOYCXafe6GAE5RMKckfrde+LaEZM sEaIq0VvYpgS6s00z9zH7TqnM4r3dVoyzB2f/vOlIR99WPnLJiO3BfvZ/RJUhhJ2rxCB 4+QXRnpXxmxvzjrU333C8uJn6Po1Ep6EmbDT1P0YzJgsN/2kedLNS/zfO4qIdqjeM+Om SkAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677597880; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ouo8uuwT0BL/iQ4qXVVvn9es2W+dnKtqVS64weaqnUQ=; b=LKUhjvmfJKEf3x2uJeuW44paSYsywLTAkwNy8L3TdYr1HjA2eIP4uWoQIDQ2/3TqjE Fn8O4t1lTWTprEQBYTz2Xp7NoCKXul2QB79/iy1uxsVea15tt1axPgvowrhOdxLb+/cq TRcallPXzWR1a+dGxC9hHG+JQU5OdXS50ARYENRNpov5T5Ih6DhzY3aqO4xVI2JT7QNn M53vhP0iE/RYZwWm90hf73eTMiLdcU2uuzqy5igAi/Rmp84VY5KHkf98QVKMrJm7YzlW TyIw56aIA8PAsZ2Mo9eYbMG32BU3x5Lcxf3cyN+OSfwG8CnVbTuxXw+j+5rVQfPScfPe ne5Q== X-Gm-Message-State: AO0yUKVyCOe/oXpbcqlfFNh9MX1beettOkZ9G+JnZOaICLcDt2btpFJy ZZEqsv5N9wiiKmHS/ZNg4DKArw== X-Received: by 2002:a19:520c:0:b0:4e1:27d5:1245 with SMTP id m12-20020a19520c000000b004e127d51245mr737241lfb.49.1677597879962; Tue, 28 Feb 2023 07:24:39 -0800 (PST) Received: from [192.168.1.101] (abym99.neoplus.adsl.tpnet.pl. [83.9.32.99]) by smtp.gmail.com with ESMTPSA id h17-20020ac250d1000000b004db3aa3c542sm1363688lfm.47.2023.02.28.07.24.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Feb 2023 07:24:39 -0800 (PST) From: Konrad Dybcio Date: Tue, 28 Feb 2023 16:24:28 +0100 Subject: [PATCH 04/18] media: venus: firmware: Leave a clue for homegrown porters MIME-Version: 1.0 Message-Id: <20230228-topic-venus-v1-4-58c2c88384e9@linaro.org> References: <20230228-topic-venus-v1-0-58c2c88384e9@linaro.org> In-Reply-To: <20230228-topic-venus-v1-0-58c2c88384e9@linaro.org> To: Stanimir Varbanov , Vikash Garodia , Andy Gross , Bjorn Andersson , Mauro Carvalho Chehab , Dikshita Agarwal , Bryan O'Donoghue , Dikshita Agarwal , Mansur Alisha Shaik , Jonathan Marek Cc: Mauro Carvalho Chehab , Stanimir Varbanov , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Vikash Garodia , Konrad Dybcio X-Mailer: b4 0.12.1 X-Developer-Signature: v=1; a=ed25519-sha256; t=1677597872; l=1076; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=LhE7R96rM2LJyxG+NTkMKHvW3mNwrGGFDkZtGywlnuE=; b=oMSaelWO7J6BsFG1tAJQU96xUGll1OWl5vsqn0f7Yz13BEhTSShoDxY6os/RVoqCN/DUbBRzdvqv rwCrO1vsBpSJEGD31GNpS9AHeprFsLKg7QRhIilIkuW86fl1zSp8 X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759089068185732173?= X-GMAIL-MSGID: =?utf-8?q?1759089068185732173?= Leave a clue about where the seemingly magic values come from, as it is not obvious and requires some digging downstream.. Signed-off-by: Konrad Dybcio reviewed-by: Dikshita Agarwal --- drivers/media/platform/qcom/venus/firmware.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/media/platform/qcom/venus/firmware.c b/drivers/media/platform/qcom/venus/firmware.c index 61ff20a7e935..1bb6406af564 100644 --- a/drivers/media/platform/qcom/venus/firmware.c +++ b/drivers/media/platform/qcom/venus/firmware.c @@ -241,6 +241,13 @@ int venus_boot(struct venus_core *core) return ret; if (core->use_tz && res->cp_size) { + /* + * Clues for porting using downstream data: + * cp_start = 0 + * cp_size = venus_ns/virtual-addr-pool[0] (yes, addr not size) + * cp_nonpixel_start = venus_sec_non_pixel/virtual-addr-pool[0] + * cp_nonpixel_size = venus_sec_non_pixel/virtual-addr-pool[1] + */ ret = qcom_scm_mem_protect_video_var(res->cp_start, res->cp_size, res->cp_nonpixel_start,