From patchwork Fri Apr 7 20:14:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 81026 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp514284vqo; Fri, 7 Apr 2023 13:33:04 -0700 (PDT) X-Google-Smtp-Source: AKy350aJi59FJ73PrICicemL9X06lHu+0wjZ5qc8a0M2d10Kb1iMTF7xt6X6ZqZY0r980dnM9dTn X-Received: by 2002:a17:906:39cf:b0:933:be1:8f4f with SMTP id i15-20020a17090639cf00b009330be18f4fmr696683eje.9.1680899584638; Fri, 07 Apr 2023 13:33:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680899584; cv=none; d=google.com; s=arc-20160816; b=YC8ZN6yhDOO/W6V3zdAElrqikFigHFW8WUAfjRLcviR5190h41RS2E4JgvqJvpvMyX j6CGVomn/zGw926uB1ItuBnCP9df3OLUncSKFdWloTCRSVq6pgY3rOB27rVgAeiJ7FHU 78FgSx8JzIMLCO8YkJIeERm7rPupX3RJpVEsoyvCoPl3hdevUuMCtY+l38BdfC47urDL RroEboGXRssdVpw2SeRgdhiiMtMJT8z3F1L9h5quflsiKS1VwrzCMaYw6vxEDQsqfE5+ ATYp9nHiWG8AFQevojeC5OUKv7yoyLk1fkwgfLgF3dgs7CcpcGZJPtuU7HiCUO1Aw0o9 15kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=H3nsx7fTooCsHlb+iQOPq8i6PDjNQ7J7ivbonnB4f0g=; b=XXG0/aHaomnMMrmCqzzpAIs5FLoendkeE76SI7NGrXm1TOB9g9mQYwRZVpDnXyYpNl mA/Rv3Ho8ecGbRc3vWvNRPTaAp8pV+i4DOnI7UowjlIXmCWoDBfhIryoeZcAqQBN8h9z JqDhtTQnW0B6p1OEWVpx7wTKCL+QBkzUUDlbkrnd0gl/WU9FsN2J7nZ9iqiLrxMCm9UB qzXPRxGj+XxEQA7WJHD3voKzvDFrzi+x+mWB2BU6+q35YWaX7QOhjy0hEahFMndxpV5/ PrCJlitTHGSeOyqsfDGdJKMhz7qc+jTgYUiJhSSlhJGHGjWXjPYojQd97KmOKQa8nAtH 9cew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Z8vc6jpc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t22-20020a170906949600b0094404d7e622si862002ejx.770.2023.04.07.13.32.40; Fri, 07 Apr 2023 13:33:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Z8vc6jpc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229758AbjDGUPC (ORCPT + 99 others); Fri, 7 Apr 2023 16:15:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229887AbjDGUOw (ORCPT ); Fri, 7 Apr 2023 16:14:52 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D459F1BC5 for ; Fri, 7 Apr 2023 13:14:50 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id q16so55678061lfe.10 for ; Fri, 07 Apr 2023 13:14:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680898489; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=H3nsx7fTooCsHlb+iQOPq8i6PDjNQ7J7ivbonnB4f0g=; b=Z8vc6jpcWix01rDMGNR5PCpgd+r96K1dnJUCfKV7qM4GZtoljfuq7IBcdUCo8ooyTU m09IsKdPTF2AKqu3wDIoxrpIJ8iimjjuBgdfli5PSAJi4Tdz/NzUZ7PAlF7X4whGoxRO Sy5JfXLxQdxKeD/S3e7nmrHx6iId8R8ukvPQLr6wNPkms9xuBl8ZMViBwX1TLxVjuI4V GALzUti2PrVQRe0isUUqcBJHR7D6pSxQvB9wVtwHSrRLXGb5ga2HrKejmx/ZCkix8ww/ mMWnEHkPy6gLSUeb74HQOjDfgBZVmINA/OB7JUDSapX6vYWtGqZYoiq30nUyIvIMAej7 PGUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680898489; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H3nsx7fTooCsHlb+iQOPq8i6PDjNQ7J7ivbonnB4f0g=; b=DiAHFZVzLLaW7SiXTdjdhsG86LazPn44fDee5aySnIbBcLeizJArITrB7oZy2lQ6xn DqvjtJQxuzRCu3lvbZMa2xqZzeEIXjwiJZjadzoZ0xzzYy3yl4f7OQFq2YDlvaadMYF/ PBOML3g/kTswhAc2LBB7CjgwyQqZzDYS46oMlh84iThJ/9Ds0kVeKOqVh8okvGVVvKrT KAmWSj1V/D8TzNusKsLl3EoUz2AyvLtbgKY2G+C5bB4LrP2OPrUHEnGxoed/b10OMHPQ iUbqyKEdjV5RBvQIaMWUMcir+bKxWztarNmAs1KTDAWzeGzcLenBZqitsZaEjvY32C94 4S/A== X-Gm-Message-State: AAQBX9f8BIGovHx+bT1/qcfMeYxv31FgwzbVD2sRWZ+1ZWQyKbzCCis4 Ys3Dg2Q+6afZXg8/VOmqlbh0aA== X-Received: by 2002:ac2:447b:0:b0:4db:4fe8:fd0f with SMTP id y27-20020ac2447b000000b004db4fe8fd0fmr909089lfl.25.1680898489225; Fri, 07 Apr 2023 13:14:49 -0700 (PDT) Received: from [192.168.1.101] (abxh37.neoplus.adsl.tpnet.pl. [83.9.1.37]) by smtp.gmail.com with ESMTPSA id u3-20020ac243c3000000b004eaf6181a32sm842436lfl.75.2023.04.07.13.14.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Apr 2023 13:14:48 -0700 (PDT) From: Konrad Dybcio Date: Fri, 07 Apr 2023 22:14:45 +0200 Subject: [PATCH v8 3/8] interconnect: qcom: rpm: Drop unused parameters MIME-Version: 1.0 Message-Id: <20230228-topic-qos-v8-3-ee696a2c15a9@linaro.org> References: <20230228-topic-qos-v8-0-ee696a2c15a9@linaro.org> In-Reply-To: <20230228-topic-qos-v8-0-ee696a2c15a9@linaro.org> To: Andy Gross , Bjorn Andersson , Georgi Djakov , Dmitry Baryshkov Cc: Bryan O'Donoghue , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio , Marijn Suijten X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1680898484; l=2285; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=yBC75Q6TJYtH1vX8QL0awOafuPHjdn2hOETxfU8AhgI=; b=/scUAZfnDk4668871iclpkfz/2TI7qD1M2Yecgm/4Pk9iR0T4KISIAjnhu3EULS0UwQUZguCML7F 1VbPKaQFBp3iVjwy0cty4n9Ihl/9mgDe+MLW6lysH+x5AHLXOnm7 X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762550962965178117?= X-GMAIL-MSGID: =?utf-8?q?1762550962965178117?= The QoS-setting functions do not care about the bandwidth values passed. Drop them. Signed-off-by: Konrad Dybcio --- drivers/interconnect/qcom/icc-rpm.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/interconnect/qcom/icc-rpm.c b/drivers/interconnect/qcom/icc-rpm.c index 8dce3dcff8da..7d62c0bf2722 100644 --- a/drivers/interconnect/qcom/icc-rpm.c +++ b/drivers/interconnect/qcom/icc-rpm.c @@ -50,7 +50,7 @@ #define NOC_QOS_MODE_FIXED_VAL 0x0 #define NOC_QOS_MODE_BYPASS_VAL 0x2 -static int qcom_icc_set_qnoc_qos(struct icc_node *src, u64 max_bw) +static int qcom_icc_set_qnoc_qos(struct icc_node *src) { struct icc_provider *provider = src->provider; struct qcom_icc_provider *qp = to_qcom_provider(provider); @@ -95,7 +95,7 @@ static int qcom_icc_bimc_set_qos_health(struct qcom_icc_provider *qp, mask, val); } -static int qcom_icc_set_bimc_qos(struct icc_node *src, u64 max_bw) +static int qcom_icc_set_bimc_qos(struct icc_node *src) { struct qcom_icc_provider *qp; struct qcom_icc_node *qn; @@ -150,7 +150,7 @@ static int qcom_icc_noc_set_qos_priority(struct qcom_icc_provider *qp, NOC_QOS_PRIORITY_P0_MASK, qos->prio_level); } -static int qcom_icc_set_noc_qos(struct icc_node *src, u64 max_bw) +static int qcom_icc_set_noc_qos(struct icc_node *src) { struct qcom_icc_provider *qp; struct qcom_icc_node *qn; @@ -187,7 +187,7 @@ static int qcom_icc_set_noc_qos(struct icc_node *src, u64 max_bw) NOC_QOS_MODEn_MASK, mode); } -static int qcom_icc_qos_set(struct icc_node *node, u64 sum_bw) +static int qcom_icc_qos_set(struct icc_node *node) { struct qcom_icc_provider *qp = to_qcom_provider(node->provider); struct qcom_icc_node *qn = node->data; @@ -196,11 +196,11 @@ static int qcom_icc_qos_set(struct icc_node *node, u64 sum_bw) switch (qp->type) { case QCOM_ICC_BIMC: - return qcom_icc_set_bimc_qos(node, sum_bw); + return qcom_icc_set_bimc_qos(node); case QCOM_ICC_QNOC: - return qcom_icc_set_qnoc_qos(node, sum_bw); + return qcom_icc_set_qnoc_qos(node); default: - return qcom_icc_set_noc_qos(node, sum_bw); + return qcom_icc_set_noc_qos(node); } }