From patchwork Tue Feb 28 13:44:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 62491 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp3021811wrd; Tue, 28 Feb 2023 05:47:56 -0800 (PST) X-Google-Smtp-Source: AK7set/71fMeeeMWYNrMQ+bS0AdgF/BEnVqN07HD+UjVfi+6+puqGryzKlfOM9YTXNnp5jUH/7Hl X-Received: by 2002:a17:906:770d:b0:8aa:c038:c768 with SMTP id q13-20020a170906770d00b008aac038c768mr3156140ejm.66.1677592075954; Tue, 28 Feb 2023 05:47:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677592075; cv=none; d=google.com; s=arc-20160816; b=u4tpiqbEpr1E8IYTaO8DUZyFDxtmp9Kt+T6Im/439dlrFdlNbdmGMtPUBKXGW7Yt/E IRjAnTV7yVZfJ5SGijL9yzH77qCQ93k5xrJNexNXK0RtFVB7qsO72uM1lm3DpcyIh5i/ WHvzNx0seK6jHsZmnK14nto7U1FH59wd9FUiWd4b938BfMF+MYBVjdj7Uocb9RMYXiQa of1ij07RE40ZZVIPCcoCIjXCf0wQfw5H9ZcNK6hfKai5qadqjj1HmjQgZhSoxdZ9JD4Z 3+ONlqC7TPH0jYO46gG3mGNrQGEmk6oOKcqjVkFYLRUWLpp5xdCtA5KnWYFnR+n10pPL 0IHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=uIPKe9kvABQ+Ey2gP511WJDAmlrhCcezY7A3+lbIVq4=; b=RNCqaa79pmc8TFXExAopeo0adQnhm7V30L8YgnOX1GTlXkGHzW1Kt6gOtYnBnqqxWg N6u1LUHbky8fxugu7E+u3pmEULDIgy/V5UWO4got7DbvYDhw8fhePeMzuDkDkjAzlrxN bFLm8D6pFx6AK9VwnO4DiU/l7zFb22Ro66KXBjDI23Sx3wus/0OhHt4uICJtGadZh999 IuAxPUT1HQQAqXl0jSU7dIowJQizXx/jEmr114D/cNhJeluLWifkllQrFmMm9ubPQnyJ Nzw6GnY2PdR2fHyn/6MHGJShIDsdVXddtOalM6H4NBq8IpVHX0l811cErtOJ62tLPu62 qrVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=mmnuvUb7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d14-20020a170906344e00b008d606b1bbbcsi2665804ejb.311.2023.02.28.05.47.32; Tue, 28 Feb 2023 05:47:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=mmnuvUb7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229676AbjB1Now (ORCPT + 99 others); Tue, 28 Feb 2023 08:44:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229616AbjB1Noe (ORCPT ); Tue, 28 Feb 2023 08:44:34 -0500 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11A7C2B624 for ; Tue, 28 Feb 2023 05:44:32 -0800 (PST) Received: by mail-lj1-x22b.google.com with SMTP id z5so10278753ljc.8 for ; Tue, 28 Feb 2023 05:44:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1677591871; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=uIPKe9kvABQ+Ey2gP511WJDAmlrhCcezY7A3+lbIVq4=; b=mmnuvUb7ShBT7sGOwNvaIXYzsFxwbz68OC33QDMbahsMtSJGVkhyiUUsbDgagUsJKz BMD1L4VstyjnjnSfRdFKdT8kQJYhS9cX8QhIj0tLgNM7o+1f4ax8eVQYf2TWfUvYxd+L QZG7etTt1Kwz16Yzi5Z4I8NvqgsjJqV552a08gCQNa+EYkuuzMuFM4jScmbzuNJwPzJ4 lANXLfOH/LNuTBoL2+b5btLZrbo46ZM0+oVeiUYpSFbyRYQ5VhhP807mATciJSGKoN7x IoyizFp4FEmS61QfGVovQ5NJ/zVg7Dxk8aYaFp9fhKNWOdXvyP3oCvupea8aepDBcRQd eb7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677591871; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uIPKe9kvABQ+Ey2gP511WJDAmlrhCcezY7A3+lbIVq4=; b=DfKjKRl/Zmu1diyNRfC4lOcidNq6nGiGvIfgbg2CxsTchyeG4sHUqtxhyKE5a2EZBO 4K0QH1W9eN6iv+tMJx7F5+9aOXEiC7S4pkDM6JrwUWBitlJyBt2gUOjIGOC6s6lXh3TD ffJ3ZoWV0ilpkXmQcrdcnAzI5LtvAG5fgZwmcvNMZtCiCs1ExD5OuIP8truhvA9mpPao QnliVOweRRuxuApR9/wXeBnIP56sydhd25WI0CTArlMFT/3tSejn3NzFavgt7OW4ar5t zqgJDzOx6ytbPtE9HB7TbOk1213vyRuhCxlCHfq2i6iiOKrQb+dq+d7lMLtzxcD31JGG vQ9g== X-Gm-Message-State: AO0yUKW/JVwwQ0tTgBDoAoYcWlrDD/kpmY9bmsDyxnRrf8fSI9Ur6paA 5I95djHdTy91d6UQ+ORo9ED3Sg== X-Received: by 2002:a2e:978e:0:b0:293:480c:884 with SMTP id y14-20020a2e978e000000b00293480c0884mr988418lji.37.1677591871659; Tue, 28 Feb 2023 05:44:31 -0800 (PST) Received: from [192.168.1.101] (abym99.neoplus.adsl.tpnet.pl. [83.9.32.99]) by smtp.gmail.com with ESMTPSA id j20-20020a2e3c14000000b00295a583a20bsm1203975lja.74.2023.02.28.05.44.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Feb 2023 05:44:31 -0800 (PST) From: Konrad Dybcio Date: Tue, 28 Feb 2023 14:44:05 +0100 Subject: [PATCH v6 8/9] interconnect: qcom: rpm: Don't use clk_get_optional for bus clocks anymore MIME-Version: 1.0 Message-Id: <20230228-topic-qos-v6-8-3c37a349656f@linaro.org> References: <20230228-topic-qos-v6-0-3c37a349656f@linaro.org> In-Reply-To: <20230228-topic-qos-v6-0-3c37a349656f@linaro.org> To: Andy Gross , Bjorn Andersson , Georgi Djakov , Dmitry Baryshkov Cc: Bryan O'Donoghue , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.12.1 X-Developer-Signature: v=1; a=ed25519-sha256; t=1677591861; l=1105; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=Trwtp2UuhUI4fi7Cq6Zwq0fwVJM3gAyEwBU7IiWKQN0=; b=vT4iRKkPmPZTOxukV1H7aZoMisskXyxQ5Umd/5Gwko7beejzqOY3tg7ko07CqrbGLPx9NUWWuRUr KC9l5pcJDKn5QubaimNr6SkAqeopFK3yme5C+lflb0Yg3GjT1tc4 X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759082788943036862?= X-GMAIL-MSGID: =?utf-8?q?1759082788943036862?= Commit dd42ec8ea5b9 ("interconnect: qcom: rpm: Use _optional func for provider clocks") relaxed the requirements around probing bus clocks. This was a decent solution for making sure MSM8996 would still boot with old DTs, but now that there's a proper fix in place that both old and new DTs will be happy about, revert back to the safer variant of the function. Fixes: dd42ec8ea5b9 ("interconnect: qcom: rpm: Use _optional func for provider clocks") Signed-off-by: Konrad Dybcio --- drivers/interconnect/qcom/icc-rpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/interconnect/qcom/icc-rpm.c b/drivers/interconnect/qcom/icc-rpm.c index 48eb4394b84e..77346a2ab82b 100644 --- a/drivers/interconnect/qcom/icc-rpm.c +++ b/drivers/interconnect/qcom/icc-rpm.c @@ -517,7 +517,7 @@ int qnoc_probe(struct platform_device *pdev) } regmap_done: - ret = devm_clk_bulk_get_optional(dev, qp->num_bus_clks, qp->bus_clks); + ret = devm_clk_bulk_get(dev, qp->num_bus_clks, qp->bus_clks); if (ret) return ret;