Message ID | 20230226225406.979703-20-daniel.lezcano@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2147075wrd; Sun, 26 Feb 2023 15:49:52 -0800 (PST) X-Google-Smtp-Source: AK7set+O9M80BcVakjvpaVsIk338dWK1eO3eVlNZ1uIlDJUb5f0ZXu7keqExsnh3EnVAOF29k03z X-Received: by 2002:a17:902:bb0f:b0:197:8e8e:f15 with SMTP id im15-20020a170902bb0f00b001978e8e0f15mr24460335plb.6.1677455392017; Sun, 26 Feb 2023 15:49:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677455392; cv=none; d=google.com; s=arc-20160816; b=NiT5pEGiPmZ7VqNoxbhWO39c2cQyI+un+bv157lv9BDKb2NCn2cAqSp3+qlP7e2ya4 OmnMXFueUB2gvOQyqgExcfPlt/MYe1qKT0cahx7seRc3HGZfabxzefKq6uTDGcCZGV/j U1LJ0yc3LKc1WKfJQl367P3y7JzAdFXxKdFX6bTkT0k3BCd/VtQE5cHj20K1jqAzb3aE J5TaaugCaJ5nKl2oe0DKWlcEx5AkY8wosptOKVm8p4p5HgC5mGNMw9zPUHVEH6Zn+EaF 3eExU3PT2GK6k1rhvQGg/Q2LfYtAZF6IfS/9ukDGv/0210RDI7Gt89UUCLjW71wp9n84 3mkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=FS5MMzUrtYY5N2w5QCadh2L/6Lyuv9jfcaqNKoRqTRU=; b=wavPZvGsmX40PyYH0MV1omqXRknam8WucJv4q/VhmQ34Yd9PU8JUmk8Su40Nm4YSFh xDZ5cWVbB3L5iooj3iGVisZ+1mN6n2/ml7XuRgfMuh5Pds8snYtnLn2e8lsnTw89VElp xb9BbaMlKfZ0CsmoZVR0qSPEdnk4h28v4MYjqw2UYICzP1mgoNv3H+oEUhXMxgsHodqy 6pHvD97IMI6Mjs50hWRbk1kzb3yVfiQiJE62VCzbm1mqh4R3ErPoDnJxfEpnkVIn2jG8 NJPN2Y+IqwbV5/8OaZCUypRUrs2p6P4QsA0bD60TqXnE9dPOyXSxfQ8m6Ly5mvw7Yo4D flpQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DgprYmeH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u6-20020a170902b28600b0019ced5b1a21si5341145plr.482.2023.02.26.15.49.36; Sun, 26 Feb 2023 15:49:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DgprYmeH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230001AbjBZW4v (ORCPT <rfc822;tertiaryakionsight@gmail.com> + 99 others); Sun, 26 Feb 2023 17:56:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229701AbjBZWzx (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sun, 26 Feb 2023 17:55:53 -0500 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E8E51A649 for <linux-kernel@vger.kernel.org>; Sun, 26 Feb 2023 14:55:33 -0800 (PST) Received: by mail-wr1-x42f.google.com with SMTP id bt28so4408526wrb.8 for <linux-kernel@vger.kernel.org>; Sun, 26 Feb 2023 14:55:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FS5MMzUrtYY5N2w5QCadh2L/6Lyuv9jfcaqNKoRqTRU=; b=DgprYmeHBjj1QzTvylKGYwPam1q6cXCND0PzN/JHv1fIlxg+oS9gS+MrmgNuKZAI+1 O0pEW4qREyxsNftF17Uw8vvkC+iavEQR9LTDHma6fBAAyP36KS2OJNzs/bhwnmNz8TH6 3CFZBmKkQA2h6kzBDu5TuqiyoaFEthZxnHPJNj5QLUWeprwFH7S/p8ZP3z9iQceNrZTv E8vzBjUCBo2dogzXpNgzLOy4cJkNhNk8YRP7IG8g3OKyfPto5PBgvwl88Mtkg2D53HP5 8mRk5vBC6uc9vttrEFYbzXzvaTZnKXgYxFHXX4P9LEItr7jTuyw3BusYV0zir1MY1pYQ /9iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FS5MMzUrtYY5N2w5QCadh2L/6Lyuv9jfcaqNKoRqTRU=; b=OH2xIQRSiFIAhvM+YmAvVetEpSqRMMM54hIsCgFSBt+fWzIfochVa8bWYFcdhhneTJ yGzwKqawb39kVmvjhSxQqaqOUcLj0sHuBOuUsXqEv1qvmLntXh047ozb/Sekskto7ZfB kUAJrhNGeFwDoUHRgoQ44F/3HTtOOHeeP50qP4+yzv0TMeKeQgl4LKo/qmJKh8UxPrLt jwKCRBswcZulXdBbKMVM1yiT7H50oZkByo4frbZO+kBVMCW/RF0TVY9jIHo2xOwrqA77 fn3JXyUoXbG3PfWwQP94rSvQ0Ayqpj/BnH33xyNSEGuJDKSUU2LfpSKiRjt2gspI2oLr T50A== X-Gm-Message-State: AO0yUKVo8KtaeviomwGwI4YY1PsdozuB7qqOq1YRo3nTdnWPQxkTOToz ELUYj95K8y5dYzHkjCp5JO77qA== X-Received: by 2002:a05:6000:1110:b0:2c8:42b5:8030 with SMTP id z16-20020a056000111000b002c842b58030mr6254219wrw.62.1677452123541; Sun, 26 Feb 2023 14:55:23 -0800 (PST) Received: from mai.box.freepro.com ([2a05:6e02:1041:c10:8baa:6b32:391b:62de]) by smtp.gmail.com with ESMTPSA id d10-20020a05600c3aca00b003eb369abd92sm6138074wms.2.2023.02.26.14.55.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Feb 2023 14:55:23 -0800 (PST) From: Daniel Lezcano <daniel.lezcano@linaro.org> To: rafael@kernel.org, daniel.lezcano@linaro.org Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Kaestle <peter@piie.net>, Hans de Goede <hdegoede@redhat.com>, Mark Gross <markgross@kernel.org>, platform-driver-x86@vger.kernel.org (open list:ACER ASPIRE ONE TEMPERATURE AND FAN DRIVER) Subject: [PATCH v3 19/20] thermal/drivers/acerhdf: Remove pointless governor test Date: Sun, 26 Feb 2023 23:54:05 +0100 Message-Id: <20230226225406.979703-20-daniel.lezcano@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230226225406.979703-1-daniel.lezcano@linaro.org> References: <20230226225406.979703-1-daniel.lezcano@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758939465161248277?= X-GMAIL-MSGID: =?utf-8?q?1758939465161248277?= |
Series |
Self-encapsulate the thermal zone device structure
|
|
Commit Message
Daniel Lezcano
Feb. 26, 2023, 10:54 p.m. UTC
The thermal zone parameter specifies the bang-bang governor. The Kconfig selects the bang-bang governor. So it is pointless to test if the governor was set for the thermal zone assuming it may not have been compiled-in. Remove the test and prevent another access into the thermal internals. Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> Acked-by: Peter Kaestle <peter@piie.net> --- drivers/platform/x86/acerhdf.c | 7 ------- 1 file changed, 7 deletions(-)
diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c index 61f1c3090867..71b9c1f922d9 100644 --- a/drivers/platform/x86/acerhdf.c +++ b/drivers/platform/x86/acerhdf.c @@ -697,13 +697,6 @@ static int __init acerhdf_register_thermal(void) if (ret) return ret; - if (strcmp(thz_dev->governor->name, - acerhdf_zone_params.governor_name)) { - pr_err("Didn't get thermal governor %s, perhaps not compiled into thermal subsystem.\n", - acerhdf_zone_params.governor_name); - return -EINVAL; - } - return 0; }