From patchwork Sun Feb 26 22:54:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Lezcano X-Patchwork-Id: 61680 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2131281wrd; Sun, 26 Feb 2023 14:56:48 -0800 (PST) X-Google-Smtp-Source: AK7set/c5O8V+iqntoQEXg9qJ5ul1FTi4V2mrrRT3pWxgKLxqSqL2egYDe+eavRBC0GfTkY6+t11 X-Received: by 2002:a05:6a00:2ca:b0:5de:a362:ecf1 with SMTP id b10-20020a056a0002ca00b005dea362ecf1mr12415270pft.0.1677452207726; Sun, 26 Feb 2023 14:56:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677452207; cv=none; d=google.com; s=arc-20160816; b=PrCS250rS1FsNN/WEjKdVKGXR6Smhbx2h5dRqCYwDMbd3yBRP8i9drGofJ6KqtHiwW lbh/M9LrnklgujaWg4WzeDjda+YGkJECb3fnz1ObBUaUVTgtV3nbUsP4P/g9Wkd0X8Xa nQlEoDzCqj6FcCte1rpmQpBJ1iNCpZVSEk0hb6iCL4eYQTXZSluVRU7L2cKAz/Kq+qdD Jm8jJQD46eSTYXC8BolG1vvCWDjWpHxA5EvLVz6kk2zEFVY5pprS/1vINha5V4laPE/n RLG2roSaQuBVE6/ZWVezxULK7TdhVGjH8/xCC8CTjH/w96CFlJHr4eI4RB5603el1jUI hY+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=C2s/AS9OMV5i6t0w60QjnkUP8k7sKtqb93EMncEZug0=; b=Bzakk70zzTKwWP2gKwXnXL27lXtco6+EEKQQLdQhVXqBeSKCPIFrFS3Dcdkw+j0AOE dV739JbN3oiU9KtVsTA1sA58kfQAz0VGN0mRqhFoqmWh0dx8M0HiagomCynRV1tRDBLr U91iwDCAcbDurZkIk6aPP3UFtmELAQ727HYktSxVIERfjLGC7doleTROkEMUHbBakCWS vzRUfHMgmIDdrWkQJrAygVroVF9tRLPz761l9dELdzUqF1sltG/aYF2XXhSrIXCzAuNV y4z0V/f2Cac55MDFdTkwjapdBQM5IV/HFYUSTcBmu7C+U3cWa/83yrJTGOhwYvlhBxcv QK5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=RrXcIqzc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 66-20020a621845000000b00593ac87bbadsi4942863pfy.202.2023.02.26.14.56.34; Sun, 26 Feb 2023 14:56:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=RrXcIqzc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229915AbjBZW4M (ORCPT + 99 others); Sun, 26 Feb 2023 17:56:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229719AbjBZWzw (ORCPT ); Sun, 26 Feb 2023 17:55:52 -0500 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9026318B2E for ; Sun, 26 Feb 2023 14:55:21 -0800 (PST) Received: by mail-wm1-x32a.google.com with SMTP id fm20-20020a05600c0c1400b003ead37e6588so5920877wmb.5 for ; Sun, 26 Feb 2023 14:55:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=C2s/AS9OMV5i6t0w60QjnkUP8k7sKtqb93EMncEZug0=; b=RrXcIqzcrWf2lNRMsPY+D8nUU5rGWSM/ctrK4w2nFXbnQIS281ZCN9hQiySwkMaUmg upw/yejus11mTRnMf9kyQ8gqoPpRUayc7Le6DAYr8ShIyNEV8dg63GJFOplB+8exl3wJ Em6nycsPTYfFl+zDoWh5qQ9+mHwo48EJhqJK0rjys+U3DHccFifM5dHgsYx+C/EWFYRc cbKjrnTFV1f9nQ4eHFai6JIqCKWyRn/dQWMKYr/8MrIJLqCcfaP4SlVyfdiQOaLEvGGb cVnH3W/4JRlsSbhTSaUAhTampVjDhPKyEAtrQ7rClYMgA3/L96CQykGpc6QpVg+ie+VQ ICRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=C2s/AS9OMV5i6t0w60QjnkUP8k7sKtqb93EMncEZug0=; b=BcCNETphevytZiiVaU1jV/Izgk6NX+EdBM4hyQcERI0I0oJpJMlrgqZi/q8cA6ohQ/ 9DYiuo0jHo4DOKdreXk/JQ6aZVKPjStSGPeS6m3cQuNDct3V7wT3vZDaOj50FH2Kw9T6 ZjiUQqL2fb9Cjp6iNY5YfxXgyMov6UEJdZ65O2RnCPmcE+FpFtIREvoQ30fVOltesJX6 4sw3rM/+Tx8pB8iw7Lcqr9j1pdMVrbJatky3H6Es7H0P+crDU3Zf5sKMkvAlTKeOXcxv XCODvg+bABQWqjBTIMEv7KeqzgZNO6FeQHo3asEfpK1uc9pIkRBmVrWKJGwTl2Wd3DrB /26g== X-Gm-Message-State: AO0yUKXaLn+fV+Rf5EVzkSWqyl19zinXIy2NrnB5HfS++7dLeL+W4sDj 8PodgqtQ/bfeIbaS9D0fWnItcA== X-Received: by 2002:a05:600c:3089:b0:3eb:29fe:734a with SMTP id g9-20020a05600c308900b003eb29fe734amr6436608wmn.39.1677452121129; Sun, 26 Feb 2023 14:55:21 -0800 (PST) Received: from mai.box.freepro.com ([2a05:6e02:1041:c10:8baa:6b32:391b:62de]) by smtp.gmail.com with ESMTPSA id d10-20020a05600c3aca00b003eb369abd92sm6138074wms.2.2023.02.26.14.55.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Feb 2023 14:55:20 -0800 (PST) From: Daniel Lezcano To: rafael@kernel.org, daniel.lezcano@linaro.org Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Amit Kucheria , Zhang Rui , Thierry Reding , Jonathan Hunter , =?utf-8?q?Niklas_S=C3=B6derlund?= , AngeloGioacchino Del Regno , Jernej Skrabec , Florian Fainelli , linux-tegra@vger.kernel.org (open list:TEGRA ARCHITECTURE SUPPORT) Subject: [PATCH v3 17/20] thermal/tegra: Do not enable the thermal zone, it is already enabled Date: Sun, 26 Feb 2023 23:54:03 +0100 Message-Id: <20230226225406.979703-18-daniel.lezcano@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230226225406.979703-1-daniel.lezcano@linaro.org> References: <20230226225406.979703-1-daniel.lezcano@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758936126207789603?= X-GMAIL-MSGID: =?utf-8?q?1758936126207789603?= The code enables the thermal zone after setting it up. But the thermal zone is already enabled by thermal_of_zone_register() function. Signed-off-by: Daniel Lezcano --- drivers/thermal/tegra/tegra30-tsensor.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/thermal/tegra/tegra30-tsensor.c b/drivers/thermal/tegra/tegra30-tsensor.c index 3506c3f3c474..e38902abf207 100644 --- a/drivers/thermal/tegra/tegra30-tsensor.c +++ b/drivers/thermal/tegra/tegra30-tsensor.c @@ -346,7 +346,7 @@ static int tegra_tsensor_enable_hw_channel(const struct tegra_tsensor *ts, { const struct tegra_tsensor_channel *tsc = &ts->ch[id]; struct thermal_zone_device *tzd = tsc->tzd; - int err, hot_trip = 0, crit_trip = 0; + int hot_trip = 0, crit_trip = 0; u32 val; if (!tzd) { @@ -401,12 +401,6 @@ static int tegra_tsensor_enable_hw_channel(const struct tegra_tsensor *ts, val |= FIELD_PREP(TSENSOR_SENSOR0_CONFIG0_INTR_THERMAL_RST_EN, 1); writel_relaxed(val, tsc->regs + TSENSOR_SENSOR0_CONFIG0); - err = thermal_zone_device_enable(tzd); - if (err) { - dev_err(ts->dev, "ch%u: failed to enable zone: %d\n", id, err); - return err; - } - return 0; }