From patchwork Sun Feb 26 05:39:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 61563 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1809300wrd; Sat, 25 Feb 2023 21:40:53 -0800 (PST) X-Google-Smtp-Source: AK7set9N1R4NvjuTEwDos77C4rgxofdSXTthhgAcwxQqqfg5vMsh8AMEPE6QwDCNbr3FLLRtqTM/ X-Received: by 2002:a05:6a20:a11b:b0:cc:d96c:1090 with SMTP id q27-20020a056a20a11b00b000ccd96c1090mr3442285pzk.2.1677390053283; Sat, 25 Feb 2023 21:40:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677390053; cv=none; d=google.com; s=arc-20160816; b=BuAgmT4RJAf4NJ1gmz1S/i6Ega4sVqZ/rSO5dBztsT2fZ+rkp4A8cM0nLS0oNqzbSX W71gNOY6satDHa1aYfxhxqPsM7c/le3jwOhw+6fPveZEx2lyWqiWeLPu/QiaRlsV6Hxc DDLV+tarxJVUMDT6FX7xJYqHhBIYiyYUlUStPgUWOua9cD0/IX6fAYEN0ktR7EhuV+3d CqG1qB2Ig+NcvDfSBFXvNCFIr1oHLxNwyacSJfEjRhKG49VcB/nbWP9vv7gGvqsAjhHS IUw+VtW7cpOE+fJByFxVNHppr8ufHLJ1d/oph9A5QO2E1DB9R6ncjCjACyf7XNRUJyYT ZUHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=AyoTZxblYHrDgUuDfRxaCtNtUrEUy/+HCnPw8W0zpKM=; b=Swi9WkRbMcZQsG+vYnthU1TVFYk7hrrK19ZqBRjB7vsoDCF7yh351gdy/482pkyBvh BVU3yMKmC38M04wvDDP7blvlTwZf+P0m19u+/DLlWpNUeVUqI+0XnM2FhIqzh8wOBO22 13i6ZPQamti3wBW+n92MqWJ26vASqkz2YDfPePkYXEnIY7EVtbcXo0XINJ9hGTA8clMW rMWyWOWYBCPX/8Q1esOBNshjhIrV+u/weTuuThMuLIMTROZGiObCoxPz+CG/lgI/Ej1w sllbw/HvhDRByNeetXQBtu3ipbGbu/ocyTFDQINpHxGvLEXtA61lWVxtH1NjDccsuFxs jviQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=vE34UtPh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f12-20020a65550c000000b00502fd2d2901si3659484pgr.343.2023.02.25.21.40.41; Sat, 25 Feb 2023 21:40:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=vE34UtPh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229643AbjBZFkB (ORCPT + 99 others); Sun, 26 Feb 2023 00:40:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229543AbjBZFj6 (ORCPT ); Sun, 26 Feb 2023 00:39:58 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4FF4F136E9 for ; Sat, 25 Feb 2023 21:39:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=AyoTZxblYHrDgUuDfRxaCtNtUrEUy/+HCnPw8W0zpKM=; b=vE34UtPha3vYcnY3CA1tx0eYDv n5+ZoUMoM6RFCuvENArB8yc9DIMT16fw+tSYZXAiWj1fA3D8ax7rXYNf5JYgfIB/YUQ9COkgHC8fL D7Zn3Qj2Qzg1sTL2ybUR4J4lDFS9LUprVbfxWKgURB8slpOt7OeittRhl5gPi46p1CGdTxgpPen/R pykahEiooe9Gcp+Gp/o/ASPVPptdRQzhM5li4XeEutcdEg7cS+Opmi9546ZCBAoBHeY48PvDqqz8g M7kn8FEuRWX2UhxnFgjCD8RPWXbAmr5IycK2as91NO5EzsI9qPoMKjXmDD/dcLemmrAYWBNtuPHK7 x/lzHb8g==; Received: from [2601:1c2:980:9ec0::df2f] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pW9lL-006qYL-37; Sun, 26 Feb 2023 05:39:55 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Andrew Jeffery , Corey Minyard , openipmi-developer@lists.sourceforge.net, Arnd Bergmann , Greg Kroah-Hartman Subject: [PATCH 1/8] ipmi: ASPEED_BT_IPMI_BMC: select REGMAP_MMIO instead of depending on it Date: Sat, 25 Feb 2023 21:39:46 -0800 Message-Id: <20230226053953.4681-2-rdunlap@infradead.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230226053953.4681-1-rdunlap@infradead.org> References: <20230226053953.4681-1-rdunlap@infradead.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758870952275832362?= X-GMAIL-MSGID: =?utf-8?q?1758870952275832362?= REGMAP is a hidden (not user visible) symbol. Users cannot set it directly thru "make *config", so drivers should select it instead of depending on it if they need it. Consistently using "select" or "depends on" can also help reduce Kconfig circular dependency issues. Therefore, change the use of "depends on REGMAP_MMIO" to "select REGMAP_MMIO", which will also set REGMAP. Fixes: eb994594bc22 ("ipmi: bt-bmc: Use a regmap for register access") Signed-off-by: Randy Dunlap Cc: Andrew Jeffery Cc: Corey Minyard Cc: openipmi-developer@lists.sourceforge.net Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Acked-by: Corey Minyard --- drivers/char/ipmi/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff -- a/drivers/char/ipmi/Kconfig b/drivers/char/ipmi/Kconfig --- a/drivers/char/ipmi/Kconfig +++ b/drivers/char/ipmi/Kconfig @@ -162,7 +162,8 @@ config IPMI_KCS_BMC_SERIO config ASPEED_BT_IPMI_BMC depends on ARCH_ASPEED || COMPILE_TEST - depends on REGMAP && REGMAP_MMIO && MFD_SYSCON + depends on MFD_SYSCON + select REGMAP_MMIO tristate "BT IPMI bmc driver" help Provides a driver for the BT (Block Transfer) IPMI interface