Message ID | 20230223180531.15148-5-enachman@marvell.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp452585wrd; Thu, 23 Feb 2023 10:08:38 -0800 (PST) X-Google-Smtp-Source: AK7set9K8Vm7LTtN4A7gC3LPNRwMP5qgzKWj5lDjwhqDXBwBhHafAKFO12wR7YYhtW7Pjr1jt5LK X-Received: by 2002:a17:906:150:b0:894:4341:77d6 with SMTP id 16-20020a170906015000b00894434177d6mr19459384ejh.1.1677175718597; Thu, 23 Feb 2023 10:08:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677175718; cv=none; d=google.com; s=arc-20160816; b=u+S/RhKqP3Ic+jdJgbX9ogwsp90yc3oFXO+QgD5nPqRtNyR3zXQXYQpDaOQHNX9TD3 vZwgqtVEYUYnoWPB+s1VvwGcBhbQWFyVXsynpvIKnPj2JYjMMbHiV9xsL3HLYU/QrYrf Gi8th+v5cfnEPmyfDdG24k7I9TDKWw6dUGAUYOCFi6dDIwKgWOBOY8tVmyNtbohsMykt w66cSbLXnkV77S/WRcVu+aTefiU+aQhFjemenUWHf2gLEDdhK+2lZo79klVPs3FvuDGh QacM7sCTNMSkALU9McCGpprR4iW+WkcrLD+k+SYoZakmV9616oGjiOaTUrS5sYBnbP+1 0PdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=mlHi/Pr6AkJvbTefmm/F5tsWvHitizUD82E7QAHPtR0=; b=uKUtQChLVpFsMkZiSPk7u0r/SjIzEqn7qXGfJWXZixw54tcAKicZQ6ePhCIO0TofHT 1rfQ0J2qCQhK5n8G4W9NCLNq7LwXwtvX2G01+jZvVW4xXYv6Nq67K4c9Wpx6tjzEXsXa nmc4ewQjk4QqwkujY2yTxE4EAkFOzzKtz8rrZQz/vkPfYhWAuyqk9+9ckrV0w4/NRDJO 0q9mw8weoWoldMhCBYL3b+LtQxggJJy2b+NsqFBvwPY4E0taAOo6C2OZCtrlCDrOcZeg RMEY/Ll1C6jniJh5efxKZqrIxTfVAA5nLx+vnILtTe0+EjUh9JeK1rfRFYeuV4NVO7vq /Adg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@marvell.com header.s=pfpt0220 header.b=gOleKfJ9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=marvell.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v28-20020a17090651dc00b008d0378ec19fsi18031640ejk.650.2023.02.23.10.08.14; Thu, 23 Feb 2023 10:08:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@marvell.com header.s=pfpt0220 header.b=gOleKfJ9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=marvell.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230497AbjBWSGW (ORCPT <rfc822;cambridge8321@gmail.com> + 99 others); Thu, 23 Feb 2023 13:06:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230490AbjBWSGU (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 23 Feb 2023 13:06:20 -0500 Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B57F85AB48; Thu, 23 Feb 2023 10:06:13 -0800 (PST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31NHUj4E027047; Thu, 23 Feb 2023 10:06:04 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=pfpt0220; bh=mlHi/Pr6AkJvbTefmm/F5tsWvHitizUD82E7QAHPtR0=; b=gOleKfJ9c4zg4oaYDhF8F4pJm3VZVyVhbuhea/ld3FPzzcFtD5T3AeaBQwwm/W5GIADz WJxYegeYoHuX2y2Y/1cWG/Q1yubuKZJQ2bPBCt2nsgtm/M6ffuWv8bcytzvfjjAt2gQH A0qJrFlT5sRhahEhnWEH1QWIngn0fCNGtsa81Nx5qVtPRQuyCPDdnUOC0Hsm75C9MtVD AAO/DgDFu+NRCb1oe8ZZzwQWgSbqMCWUTAEJaZ4T2EGvev7JsV6qyLLDeZzv+PPOfYCZ d1r+qOrU+5m4xjWNFJ5qsG2s016NMln0pLHVfOg6NPy5099HsI8zD8e+F5IGrNN+8tGl fg== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3nwy5h2cwc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 23 Feb 2023 10:06:03 -0800 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 23 Feb 2023 10:06:02 -0800 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.42 via Frontend Transport; Thu, 23 Feb 2023 10:06:02 -0800 Received: from jupiter073.il.marvell.com (unknown [10.5.116.85]) by maili.marvell.com (Postfix) with ESMTP id 5A5DF3F709A; Thu, 23 Feb 2023 10:05:59 -0800 (PST) From: Elad Nachman <enachman@marvell.com> To: <thomas.petazzoni@bootlin.com>, <bhelgaas@google.com>, <lpieralisi@kernel.org>, <robh@kernel.org>, <kw@linux.com>, <krzysztof.kozlowski+dt@linaro.org>, <linux-pci@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org> CC: Elad Nachman <enachman@marvell.com> Subject: [PATCH v3 4/7] dt-bindings: PCI: dwc: add DMA, region mask bits Date: Thu, 23 Feb 2023 20:05:28 +0200 Message-ID: <20230223180531.15148-5-enachman@marvell.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230223180531.15148-1-enachman@marvell.com> References: <20230223180531.15148-1-enachman@marvell.com> MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-GUID: SK_ePFW_FMStnAg1H46EK2rEnVYzUGLn X-Proofpoint-ORIG-GUID: SK_ePFW_FMStnAg1H46EK2rEnVYzUGLn X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-23_11,2023-02-23_01,2023-02-09_01 X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758646206569783465?= X-GMAIL-MSGID: =?utf-8?q?1758646206569783465?= |
Series |
PCI: dwc: Add support for Marvell AC5 SoC
|
|
Commit Message
Elad Nachman
Feb. 23, 2023, 6:05 p.m. UTC
From: Elad Nachman <enachman@marvell.com> Add properties to support configurable DMA mask bits and region mask bits. configurable DMA mask bits is needed for Marvell AC5/AC5X SOCs which have their physical DDR memory start at address 0x2_0000_0000. Configurable region mask bits is needed for the Marvell Armada 7020/7040/8040 SOCs when the DT file places the PCIe window above the 4GB region. The Synopsis Designware PCIe IP in these SOCs is too old to specify the highest memory location supported by the PCIe, but practically supports such locations. Allow these locations to be specified in the DT file. First DT property is called num-dmamask, and can range between 33 and 64. Second DT property is called num-regionmask, and can range between 33 and 64. Signed-off-by: Elad Nachman <enachman@marvell.com> --- .../devicetree/bindings/pci/snps,dw-pcie-common.yaml | 10 ++++++++++ 1 file changed, 10 insertions(+)
Comments
On 23/02/2023 19:05, Elad Nachman wrote: > From: Elad Nachman <enachman@marvell.com> > > Add properties to support configurable DMA mask bits > and region mask bits. > configurable DMA mask bits is needed for Marvell AC5/AC5X SOCs which > have their physical DDR memory start at address 0x2_0000_0000. > Configurable region mask bits is needed for the Marvell Armada > 7020/7040/8040 SOCs when the DT file places the PCIe window above the > 4GB region. > The Synopsis Designware PCIe IP in these SOCs is too old to specify the > highest memory location supported by the PCIe, but practically supports > such locations. Allow these locations to be specified in the DT file. This formatting is so bad it makes difficult to read. Make these proper sentences with proper wrapping. > First DT property is called num-dmamask, > and can range between 33 and 64. Wrong mapping and we see it in the code. No need to code it again in commit msg. Especially that you already said it in the first sentence. > Second DT property is called num-regionmask, > and can range between 33 and 64. > > Signed-off-by: Elad Nachman <enachman@marvell.com> > --- > .../devicetree/bindings/pci/snps,dw-pcie-common.yaml | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/snps,dw-pcie-common.yaml b/Documentation/devicetree/bindings/pci/snps,dw-pcie-common.yaml > index d87e13496834..a1b06ff19ca7 100644 > --- a/Documentation/devicetree/bindings/pci/snps,dw-pcie-common.yaml > +++ b/Documentation/devicetree/bindings/pci/snps,dw-pcie-common.yaml > @@ -261,6 +261,16 @@ properties: > > dma-coherent: true > > + num-dmamask: > + description: | > + number of dma mask bits to use, if different than default 32 minimum: 33 (from commit msg) default: 32... which does not make now sense... > + maximum: 64 > + > + num-regionmask: > + description: | > + number of region limit mask bits to use, if different than default 32 > + maximum: 64 > + > additionalProperties: true > > ... Best regards, Krzysztof
On Thu, Feb 23, 2023 at 08:05:28PM +0200, Elad Nachman wrote: > From: Elad Nachman <enachman@marvell.com> > > Add properties to support configurable DMA mask bits > and region mask bits. > configurable DMA mask bits is needed for Marvell AC5/AC5X SOCs which > have their physical DDR memory start at address 0x2_0000_0000. > Configurable region mask bits is needed for the Marvell Armada > 7020/7040/8040 SOCs when the DT file places the PCIe window above the > 4GB region. > The Synopsis Designware PCIe IP in these SOCs is too old to specify the > highest memory location supported by the PCIe, but practically supports > such locations. Allow these locations to be specified in the DT file. > First DT property is called num-dmamask, > and can range between 33 and 64. > Second DT property is called num-regionmask, > and can range between 33 and 64. > > Signed-off-by: Elad Nachman <enachman@marvell.com> > --- > .../devicetree/bindings/pci/snps,dw-pcie-common.yaml | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/snps,dw-pcie-common.yaml b/Documentation/devicetree/bindings/pci/snps,dw-pcie-common.yaml > index d87e13496834..a1b06ff19ca7 100644 > --- a/Documentation/devicetree/bindings/pci/snps,dw-pcie-common.yaml > +++ b/Documentation/devicetree/bindings/pci/snps,dw-pcie-common.yaml > @@ -261,6 +261,16 @@ properties: > > dma-coherent: true > > + num-dmamask: Nope! There's already a defined way to define DMA/bus addresses and sizes in DT. That's dma-ranges. Rob
diff --git a/Documentation/devicetree/bindings/pci/snps,dw-pcie-common.yaml b/Documentation/devicetree/bindings/pci/snps,dw-pcie-common.yaml index d87e13496834..a1b06ff19ca7 100644 --- a/Documentation/devicetree/bindings/pci/snps,dw-pcie-common.yaml +++ b/Documentation/devicetree/bindings/pci/snps,dw-pcie-common.yaml @@ -261,6 +261,16 @@ properties: dma-coherent: true + num-dmamask: + description: | + number of dma mask bits to use, if different than default 32 + maximum: 64 + + num-regionmask: + description: | + number of region limit mask bits to use, if different than default 32 + maximum: 64 + additionalProperties: true ...