From patchwork Thu Feb 23 07:58:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Changbin Du X-Patchwork-Id: 60884 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp232507wrd; Thu, 23 Feb 2023 02:11:53 -0800 (PST) X-Google-Smtp-Source: AK7set86FvrMuth4ApenkzjUUvzTYmHhwzvCU0UKNPICRdhyLrpZJJPRdluyaeVHWImttNOoDU14 X-Received: by 2002:a05:6a00:1804:b0:5b2:5466:34e1 with SMTP id y4-20020a056a00180400b005b2546634e1mr10771091pfa.3.1677147113645; Thu, 23 Feb 2023 02:11:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677147113; cv=none; d=google.com; s=arc-20160816; b=AVR7jZxfSu0SBl6gmp37cRuwQeVmgggvkrnz6WvegTVnwTSuT+JBOBzIgsoxj15NsY eFXPg2VGteqx9WpbMWqwebXT05zQ8LMJDXRIgd2YuRfYPUiqVh0jKrlgW03Igs5Yi2Rz TkTzpxmrn3qcSpFwhz3AIkR8Zbc8ORfehgXUYGI3VczW75JgqAa3P9RAys5fX3dASr8p AKeWs0sDvQXNcrGqVCMz/tSvwlzaCkrMBCJPq8WHjCG7ynNOJgyXJpODQ7MwUliFbTju P5kFQZSR5PIae1bJ1HrQCijg/ABRQPY62px2dTJiazBmbHbxBOvt7kNRkXzUERBSf0Jh tUOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=Jf2CBRCW59yTCQXFkRksIslPU6GjZWNQ1s8UsxzqZ3c=; b=08r3fpWT5WaLgpmPkA+LDKIjw0fjpJpFs61cMK0Hfj9x1TdaOyUT+EHyDR+X7YVkyI aRtlpg2v+wNm69dGOZpwzzjr8CmcVX3JJaociLTHnYKc49TzgLF45ewKnUdXRwmcmkGy 6zBogDpvvV4f5FvMOLufb9ZfWjkOCA3YDW99zbssWx+DlTkuH5QnBSjdzgGosBhGf81m sVk/Z5+hv/AGAkwMpqs7XB+ZaAZEjNdtdEKO6U1W/Ysdh9/gvgsmHYwJNZICXTeS0R1X nYShM6ATcKc7wpUTz1kVWkGyTQ/i3yw3+hYzFIYDQ9nT/SWVBVPPxRjXhGatI8UVHwXe uNEw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y18-20020a63b512000000b004fb647a765bsi7385200pge.473.2023.02.23.02.11.40; Thu, 23 Feb 2023 02:11:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233398AbjBWKGn (ORCPT + 99 others); Thu, 23 Feb 2023 05:06:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233601AbjBWKGg (ORCPT ); Thu, 23 Feb 2023 05:06:36 -0500 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E92F39CF1; Thu, 23 Feb 2023 02:06:29 -0800 (PST) Received: from kwepemi500013.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4PMpWd5ZDszRs8M; Thu, 23 Feb 2023 18:03:41 +0800 (CST) Received: from M910t.huawei.com (10.110.54.157) by kwepemi500013.china.huawei.com (7.221.188.120) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Thu, 23 Feb 2023 18:05:21 +0800 From: Changbin Du To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo CC: Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , , , Hui Wang , Changbin Du Subject: [PATCH] perf: fix counting when initial delay configured Date: Thu, 23 Feb 2023 15:58:00 +0800 Message-ID: <20230223075800.1795777-1-changbin.du@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [10.110.54.157] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemi500013.china.huawei.com (7.221.188.120) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758616211929576443?= X-GMAIL-MSGID: =?utf-8?q?1758616211929576443?= When creating counters with initial delay configured, the enable_on_exec field is not set. So we need to enable the counters later. The problem is, when a workload is specified the target__none() is still true. So we also need to check stat_config.initial_delay. Before this fix the event is not counted: $ ./perf stat -e instructions -D 100 sleep 2 Events disabled Events enabled Performance counter stats for 'sleep 2': instructions 1.901661124 seconds time elapsed 0.001602000 seconds user 0.000000000 seconds sys After fix it works: $ ./perf stat -e instructions -D 100 sleep 2 Events disabled Events enabled Performance counter stats for 'sleep 2': 404,214 instructions 1.901743475 seconds time elapsed 0.001617000 seconds user 0.000000000 seconds sys Fixes: c587e77e100f ("perf stat: Do not delay the workload with --delay") Signed-off-by: Changbin Du --- tools/perf/builtin-stat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c index 9f3e4b257516..c71d85577de6 100644 --- a/tools/perf/builtin-stat.c +++ b/tools/perf/builtin-stat.c @@ -544,7 +544,7 @@ static int enable_counters(void) * - we don't have tracee (attaching to task or cpu) * - we have initial delay configured */ - if (!target__none(&target)) { + if (!target__none(&target) || stat_config.initial_delay) { if (!all_counters_use_bpf) evlist__enable(evsel_list); }