[v7,11/18] drm/msm/adreno: Disable has_cached_coherent in GMU wrapper configurations
Message ID | 20230223-topic-gmuwrapper-v7-11-ecc7aab83556@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp341744vqo; Sat, 20 May 2023 05:49:20 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7X/8dy7LWnk0W9Pd5EtukbOGpX1MeYrA7olCZqQV+7uy9Q5AWd28vN2NrkOKOZp1uuFhvs X-Received: by 2002:a17:902:e552:b0:1af:9b8a:9c75 with SMTP id n18-20020a170902e55200b001af9b8a9c75mr1353860plf.7.1684586959932; Sat, 20 May 2023 05:49:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684586959; cv=none; d=google.com; s=arc-20160816; b=0KdEqNCExrVdt97OU1WTJHDmR0/cPB8WBrS1kLt/V1BjpRLU7UOY6CzdkcJsq+Jt9j CPLykdAQQmHNIrFw3GUGtsDaQdGhBEzgNcz62iTJC8B8z0/Jx+XvLI+vRGppYS26yOsN st8lwpxiJ8a4H+gg+iZp50y9zIddrzBy1xKUWLvw4MnrexJSxgGJRxFYvsJ20i+5rn8e gW/wR2Ygrko1Zr+kU0AKf5fLNNqXRc3d/Cfpblqq0LGzVXkJHUiHMlWFWP+Yx/9P3BjK J0/k/4EsMLHsBSIrl7Dgz+ML7VO5kEYYlCrozXz8P94cNJCatxpDUtzcMml62Jgovmzh 0lVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=nbeDfglU9RuqTNjicprjwIl53dVBd5+75wJTdFjQtgw=; b=jTTJWYYNTivBLGu/zcvkKtmlUgfcjS5cnFwOt2JPUHdtto4Eu+JwCoPVuyYggu5cGm CJMciYvJDQ/tzzEYtvyFWYmeMhHkCdyLaG33ztYtxPI88ipB6d4OEDrXNRALqezRklBh dEXldFEsIXdxXTr4liTBk1uEVlSjoRdX7YYo31AmNttHti+5nffUs0z28gzPOJy1qpTR iSE2ymtsrExY+DkOpsIM1GMy+GwAp0uvoipyY+azgvUObs0urM0/zQUBeJFrOixZ0iHC zUESkNDCNCPWg/upish0jSiowPtrmdYoUdJW4ussEMX6GqnVwiPV/O5FBBWN4YxQWZyg fS9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ExOJZduG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r12-20020a170902be0c00b001ab13016a76si1322509pls.601.2023.05.20.05.49.05; Sat, 20 May 2023 05:49:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ExOJZduG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231946AbjETMVI (ORCPT <rfc822;wlfightup@gmail.com> + 99 others); Sat, 20 May 2023 08:21:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231808AbjETMUt (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sat, 20 May 2023 08:20:49 -0400 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3AB2A10D3 for <linux-kernel@vger.kernel.org>; Sat, 20 May 2023 05:20:07 -0700 (PDT) Received: by mail-lj1-x22e.google.com with SMTP id 38308e7fff4ca-2af2d092d7aso5851931fa.2 for <linux-kernel@vger.kernel.org>; Sat, 20 May 2023 05:20:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684585205; x=1687177205; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=nbeDfglU9RuqTNjicprjwIl53dVBd5+75wJTdFjQtgw=; b=ExOJZduGvtwwLGUWbE2bohMRQ3uh+WA5DdQ2TUV3X7X4sNx5oFHX35JK9VgguaFbZH nZgfrBJgcD1rDEdExeZUbnReiz31GMJoX8AHI/+RWbsVLngsCUBU+w4Ch1fRWrJWN6aR rdxW4Ri3cTvxnZwPGF5dHhfhEBqubTeZDvrVSus9Mfh8K6cOVs4N+Rv+KJRh5XlHlnxL UmVuXcXMR95EXPVAve1YdYchXTn/z5uEg59+gQwwOyimzTPQIwfi9nfx3C66k59IUnTp +QY1ajAK317q+KT60pEbgelMlvmTemVtGl9BtqYdpRhs8Xn2vPBpzRLvnDC46jb5KNvd 5DzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684585205; x=1687177205; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nbeDfglU9RuqTNjicprjwIl53dVBd5+75wJTdFjQtgw=; b=A1Mcd2lgyG3ZCBhrQMH8UNMgDG3PWIuxcsCJfBz+EtWn9sjwEoCljNQlirPLKkl+r4 f5RDA/Xu/spEHEqh7UTQvfecbeHezUJtYPyE2jMULtKnvyrl1P5aweiu+BL62C+SArdc IS8gsN25XJH5YMhLh1qQ3cgXBYPzBKwfaS9E9IVLPL3SNe3wHmHCCjzudaF9+X3ROurR X6nG9CTMQrUVyFkuH5O0838g4LOP0+dOoemPc0VrwV2TX7CH2HM1rx3yEoM8vjgSi0sE 0viOl4pAJysEjjQPM7EUqNonzHilhmJmg7Fd21KnCZ1deNVPcwgFaD8UsBjLuOz0yE84 8f3Q== X-Gm-Message-State: AC+VfDxnvYIgpX76XIkD9Jt7iGyZCOgKqRRzgK+Kk628pWx4awWfIBsy DhzQAhKbDgLteZQxinCBbohLZw== X-Received: by 2002:a2e:904d:0:b0:2ac:b63e:94a6 with SMTP id n13-20020a2e904d000000b002acb63e94a6mr1939411ljg.21.1684585205257; Sat, 20 May 2023 05:20:05 -0700 (PDT) Received: from [192.168.1.101] (abxi58.neoplus.adsl.tpnet.pl. [83.9.2.58]) by smtp.gmail.com with ESMTPSA id y6-20020ac24466000000b004f37bd02a89sm244766lfl.287.2023.05.20.05.20.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 May 2023 05:20:04 -0700 (PDT) From: Konrad Dybcio <konrad.dybcio@linaro.org> Date: Sat, 20 May 2023 14:19:51 +0200 Subject: [PATCH v7 11/18] drm/msm/adreno: Disable has_cached_coherent in GMU wrapper configurations MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20230223-topic-gmuwrapper-v7-11-ecc7aab83556@linaro.org> References: <20230223-topic-gmuwrapper-v7-0-ecc7aab83556@linaro.org> In-Reply-To: <20230223-topic-gmuwrapper-v7-0-ecc7aab83556@linaro.org> To: Rob Clark <robdclark@gmail.com>, Abhinav Kumar <quic_abhinavk@quicinc.com>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, Sean Paul <sean@poorly.run>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@somainline.org>, Akhil P Oommen <quic_akhilpo@quicinc.com> Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Clark <robdclark@chromium.org>, Marijn Suijten <marijn.suijten@somainline.org>, Konrad Dybcio <konrad.dybcio@linaro.org> X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1684585186; l=1374; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=Ocm0vLk+RPaXxNK50G6/CzW6Z0tf26goam4OhjTSWzI=; b=kG9tiJJo8el0T9AKSzuHPeh2Sfcz5nC7icc5Eg0j1Kz8+OxSsA/t/ZldnqBwMOgw92PtxeSRA awRSRNuzpFbCNWiYdPjMR/ER0mCdAOx45dNW6hQBntrTLroZwm98Tnu X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766417456348942439?= X-GMAIL-MSGID: =?utf-8?q?1766417456348942439?= |
Series |
GMU-less A6xx support (A610, A619_holi)
|
|
Commit Message
Konrad Dybcio
May 20, 2023, 12:19 p.m. UTC
A610 and A619_holi don't support the feature. Disable it to make the GPU stop
crashing after almost each and every submission - the received data on
the GPU end was simply incomplete in garbled, resulting in almost nothing
being executed properly. Extend the disablement to adreno_has_gmu_wrapper,
as none of the GMU wrapper Adrenos that don't support yet seem to feature it.
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
drivers/gpu/drm/msm/adreno/adreno_device.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/msm/adreno/adreno_device.c index 8cff86e9d35c..b133755a56c4 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_device.c +++ b/drivers/gpu/drm/msm/adreno/adreno_device.c @@ -551,7 +551,6 @@ static int adreno_bind(struct device *dev, struct device *master, void *data) config.rev.minor, config.rev.patchid); priv->is_a2xx = config.rev.core == 2; - priv->has_cached_coherent = config.rev.core >= 6; gpu = info->init(drm); if (IS_ERR(gpu)) { @@ -563,6 +562,10 @@ static int adreno_bind(struct device *dev, struct device *master, void *data) if (ret) return ret; + if (config.rev.core >= 6) + if (!adreno_has_gmu_wrapper(to_adreno_gpu(gpu))) + priv->has_cached_coherent = true; + return 0; }