From patchwork Sat Apr 1 11:54:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 78131 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1189617vqo; Sat, 1 Apr 2023 05:20:54 -0700 (PDT) X-Google-Smtp-Source: AKy350ZUMzMpTP4ErF/pYEcvNMDbU9/fAJ/qR2VW13f5RL0curgzaizELb0qjB+zBFmkVeMT2Tb0 X-Received: by 2002:aa7:d74b:0:b0:4fb:5607:6a24 with SMTP id a11-20020aa7d74b000000b004fb56076a24mr28887621eds.8.1680351654213; Sat, 01 Apr 2023 05:20:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680351654; cv=none; d=google.com; s=arc-20160816; b=OESESge2ayxu2iVD11R+P+zZYJDE/xtsdP0bYjadTy4fEhpU+1X8P/KjXfHpjOifld g5xJ0nDVg2rKuKdm1jmkV0u5E/mYABHEPy5fimGf5njLRKhQ07FJ8+n8pSKLtr+nNhAv RhcmmZob/9uG8cl2RB+NMMUpv6PlaoloiUDA8O/r4AsAt8S9GLWl9ScFH1kTDB4DoYWO 9ci7QcJHxizfy5h5Gj8m8OTEfkm1g2CSVss/TM43un0r8i2PCpY0nZVDOgMV1P+4bDH0 ofX6u6DodngTG1d+jOfJj/ukRc7ye38aU0bPzVWF8sk90HrX9GR0IVNNJSavnG0/hKOT +JqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=ifhrbShC7+juhdrM7tSPSmIe9BvFlsZ4IeJyZGUcR1w=; b=jLxjFsUM98RLx0jtp5qA2noO2GiSxKSe/DFu2KrHBtf13Hh7sUe8I42EP2NAFC4TfS CgxS70jHRpKDlNmV/9MlvJeqIbxT0Wk5DuUs2G3BeuOH9uogzxfanz8NyfN/FfdrYe30 cKqfAVkZWVMG/pkVo2JWLf+c1qwukjwq0WdGvGyou667PZf1xfHJhYGhlcekHkE+nL29 fQ71ruuddeGkvFNhnhdJAdE3Za8Mi3vDWgZ1nDn6NM3wJmgLASQwioH6G/cIYZPzM9QK PpSAfLJ4rHX7Mp8iuOtMFmH+f/k2Jjrfuk+vTBJ9dwh7xDI/U0z3DQcXBCvJyRGPBwzo PtUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=t3FWIRjF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e15-20020a170906c00f00b00929b68ef0besi4598468ejz.934.2023.04.01.05.20.30; Sat, 01 Apr 2023 05:20:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=t3FWIRjF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230036AbjDALzo (ORCPT + 99 others); Sat, 1 Apr 2023 07:55:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230000AbjDALz3 (ORCPT ); Sat, 1 Apr 2023 07:55:29 -0400 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8C0D26589 for ; Sat, 1 Apr 2023 04:55:11 -0700 (PDT) Received: by mail-lf1-x131.google.com with SMTP id j11so32195608lfg.13 for ; Sat, 01 Apr 2023 04:55:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680350111; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ifhrbShC7+juhdrM7tSPSmIe9BvFlsZ4IeJyZGUcR1w=; b=t3FWIRjFKkx2JGZv4wZqYWLGC53QNHQPYM2XqLu8rcG+v808heG6inHMxujip9i9TK NGy6evo9wHZqV3omXLiTO5MyoWY69eKT81cPD5Fg8gXUpF8NdBfqKO3aTwXmpnWp+T3I nFUYtBCqZdcDDGRek47/cv0cpCvNws0xMPWt2GPL2yyQ0IMz8w7z9k6U8C4xe1FkeSu6 t/i1veutCJuhgmxKl/vx7k8snA3zcqx7E1zNbbJ0GLFc1ISrX/Ks+8Hrmcm1sGR5uBHa loS3v8zY6ZZOgkjdKJKmQkU0UeVE2MkcCDnxV95qFsaeyOYm4DsNrhELa9FDoD/Oq5dK LKkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680350111; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ifhrbShC7+juhdrM7tSPSmIe9BvFlsZ4IeJyZGUcR1w=; b=6105PYIOl/QoVlGHub89aUiOwLREJY+39Sg1kbB+J2omrDILraq1c1Mx/bCJvUrwjw uE1D7lVy21MaEs+rZ+COXWAtulvk7leqrhEVdClSw/ZVt1oJZyLCAyh69AIK6X5jyUX5 jWS893VZLPh8rLP5Ltp3M4o3pdKYn+IYh1UictNUvCUxZRzoapuB26J1JXx4/bQFvbyc 7Y5rlyt4/O6Dxmcgo3AJwSNe2EjzyLp9bQDgz1TctvWL3cLB8GpZOrbj68cvZFde5GRY aMkQ/1eyyCG7fgbqHROcr7/vG6a7FIcWgVQGNT1SkI9w1RFF3wfftZuOFZJ48uW55B0s 50Gw== X-Gm-Message-State: AAQBX9ca24L5xD4Y39+Ll46gxY3+EowA7JTZuzTVYjqz7TVoyLn4G5QO fWXnnEKR0xjao/yrRKEopbdE2Q== X-Received: by 2002:ac2:5482:0:b0:4b5:8f03:a2bc with SMTP id t2-20020ac25482000000b004b58f03a2bcmr8649139lfk.9.1680350111509; Sat, 01 Apr 2023 04:55:11 -0700 (PDT) Received: from [192.168.1.101] (abxj225.neoplus.adsl.tpnet.pl. [83.9.3.225]) by smtp.gmail.com with ESMTPSA id w8-20020ac254a8000000b004e83f386878sm786737lfk.153.2023.04.01.04.55.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Apr 2023 04:55:11 -0700 (PDT) From: Konrad Dybcio Date: Sat, 01 Apr 2023 13:54:45 +0200 Subject: [PATCH v6 08/15] drm/msm/adreno: Disable has_cached_coherent in GMU wrapper configurations MIME-Version: 1.0 Message-Id: <20230223-topic-gmuwrapper-v6-8-2034115bb60c@linaro.org> References: <20230223-topic-gmuwrapper-v6-0-2034115bb60c@linaro.org> In-Reply-To: <20230223-topic-gmuwrapper-v6-0-2034115bb60c@linaro.org> To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Clark , Marijn Suijten , Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1680350084; l=1374; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=Uy9xduAlMWK2dLdqx78UuoS6GjnaBPbaxTCDUXSqNNk=; b=WbgMypqr8VbfjFpGDgyRqDk0vGFsrUY/gNWlfqaZQ2JlGKoTnt8e9m+Zkw6fJpFD0wul+XOiavpo yz5f2dmyAjAUqze+TnpY+c6yeGpi9YcCLzUgTP7glEDXgHbuUsO3 X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761976416236304671?= X-GMAIL-MSGID: =?utf-8?q?1761976416236304671?= A610 and A619_holi don't support the feature. Disable it to make the GPU stop crashing after almost each and every submission - the received data on the GPU end was simply incomplete in garbled, resulting in almost nothing being executed properly. Extend the disablement to adreno_has_gmu_wrapper, as none of the GMU wrapper Adrenos that don't support yet seem to feature it. Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/adreno_device.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/msm/adreno/adreno_device.c index 4d1448714285..4705ce3eb95e 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_device.c +++ b/drivers/gpu/drm/msm/adreno/adreno_device.c @@ -551,7 +551,6 @@ static int adreno_bind(struct device *dev, struct device *master, void *data) config.rev.minor, config.rev.patchid); priv->is_a2xx = config.rev.core == 2; - priv->has_cached_coherent = config.rev.core >= 6; gpu = info->init(drm); if (IS_ERR(gpu)) { @@ -563,6 +562,10 @@ static int adreno_bind(struct device *dev, struct device *master, void *data) if (ret) return ret; + if (config.rev.core >= 6) + if (!adreno_has_gmu_wrapper(to_adreno_gpu(gpu))) + priv->has_cached_coherent = true; + return 0; }