From patchwork Wed Feb 22 14:46:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frederic Weisbecker X-Patchwork-Id: 60567 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp619045wrd; Wed, 22 Feb 2023 06:54:14 -0800 (PST) X-Google-Smtp-Source: AK7set8tkcAvxtqSVek+kjocQ05/5xQKOVdU9+dCHt7HCmbzA7pcEuPq8lFt+rn89Pg4cVPD42dM X-Received: by 2002:a17:906:58cf:b0:88b:5798:2613 with SMTP id e15-20020a17090658cf00b0088b57982613mr20987596ejs.20.1677077654341; Wed, 22 Feb 2023 06:54:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677077654; cv=none; d=google.com; s=arc-20160816; b=qzFfmKSC97x2imFLZTPMYKc8YB93/XJoKC2u1AR/Rg5gjS60NKpNAh2v7FUgE28BYz faYaviH9nGLr3iNwj4rZ8QW+Fge42X9FV8ISeJ7rlSByo94JMsbdcKJX9UUqFkM7R4Ft m+JFV1MkPfDjlKuUMSHIL72pfMCFaxLOtI6PWnbf9Z6iiBv/bt/iL3n1itJgluGc5Qh2 ZVzP7VWk/V+L4Q9lKNNqJfcQdyctGFPoB7aMXesIAsOdxnZ6BB5Loyhzd65IExC8MFox qFx1N+DVkycFd4Ieb7OARSZ3lD7fSQ46sBnyuxsJrkMaMnl3oiq9VMNH3FYtov9XC4Yg RZPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=hFbVBQX5traxN3KDS5Y0JH03AX0vM76qT+/IKvGQRtA=; b=TxHjeYCQTL6ZDXsHSzADX4Ds8sLrSRHxibqOdh1as6Iiy0RECwG4C0X5Up4yujLDVl +CROtoRDTchGy+hhh3Wpf9xz3iWAr8ZcDqo1OX2BQb/jO2bcULYJtGPPuPh8h4O73/Kv tVjZ13YB/0qrrFMXtDybIFmZE/bDs6vtDb3Ff5k4/5BEnX7WYAxq5Q8ePHangpgfJzB0 ZS2zRkbfk2ezijds7/yXdk5hbHnco3qdBC0nfXveh34oyA8h+sTPQGBLvhU+ajbn1sZs v4nIOUpMhpT0MFqsr1xXQ19BCsCOWlmWuQBc2oBgX9w6IDnyGdmbvus/SJskb6uRfDLn PCCw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bxgURqkQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n21-20020a17090673d500b008b176cc834bsi23937982ejl.939.2023.02.22.06.53.47; Wed, 22 Feb 2023 06:54:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bxgURqkQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231926AbjBVOsD (ORCPT + 99 others); Wed, 22 Feb 2023 09:48:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231945AbjBVOrl (ORCPT ); Wed, 22 Feb 2023 09:47:41 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B27E83BD92 for ; Wed, 22 Feb 2023 06:47:22 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2AC9961490 for ; Wed, 22 Feb 2023 14:47:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7259DC4339C; Wed, 22 Feb 2023 14:47:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677077229; bh=/vEaMsqtOE5BkbGfNS7gZR33SAARhK8GonMdLs7ceS0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bxgURqkQdkUvU9rwsmMvbmQ+NaQ/3H72lC8HzB9tC2wpkHwyjDOJmuPdDA1QjJPZc ogLlOR/no2HPH3zJD3aCVLLkDtZGFcVcdYy3rS+o/Wycq5KwssYIZzyNWKxkp1H6q9 NkyVSxYNBDpvaF40BBjqj5zFfaXJ8/z8ZOZzR1CxsQYcJ5XZTK4y24u5KxQDf50lCL kDi3Gwhx4ntKzy9+AD6K1OFMLGEuLBvX+7TTIZGgQfV4g8ZvgFst7pjGLuKIlvyId/ yPEDf+4C+EpTeiEcGylwcfTsEZ6g5/adZYZmDBsruqLJErd2w/8NBc3kvNQOlAKIXZ LNxnamwUqx4Hg== From: Frederic Weisbecker To: Thomas Gleixner Cc: LKML , Frederic Weisbecker , Alexey Dobriyan , Wei Li , Peter Zijlstra , Mirsad Goran Todorovac , Yu Liao , Hillf Danton , Ingo Molnar Subject: [PATCH 5/8] timers/nohz: Remove middle-function __tick_nohz_idle_stop_tick() Date: Wed, 22 Feb 2023 15:46:46 +0100 Message-Id: <20230222144649.624380-6-frederic@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230222144649.624380-1-frederic@kernel.org> References: <20230222144649.624380-1-frederic@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758543378351152817?= X-GMAIL-MSGID: =?utf-8?q?1758543378351152817?= There is no need for the __tick_nohz_idle_stop_tick() function between tick_nohz_idle_stop_tick() and its implementation. Remove that unnecessary step. Acked-by: Peter Zijlstra (Intel) Cc: Hillf Danton Cc: Yu Liao Cc: Ingo Molnar Cc: Thomas Gleixner Cc: Wei Li Cc: Alexey Dobriyan Cc: Mirsad Goran Todorovac Signed-off-by: Frederic Weisbecker --- kernel/time/tick-sched.c | 20 ++++++++------------ 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c index edd6e9f26d16..3b53b894ca98 100644 --- a/kernel/time/tick-sched.c +++ b/kernel/time/tick-sched.c @@ -1079,10 +1079,16 @@ static bool can_stop_idle_tick(int cpu, struct tick_sched *ts) return true; } -static void __tick_nohz_idle_stop_tick(struct tick_sched *ts) +/** + * tick_nohz_idle_stop_tick - stop the idle tick from the idle task + * + * When the next event is more than a tick into the future, stop the idle tick + */ +void tick_nohz_idle_stop_tick(void) { + struct tick_sched *ts = this_cpu_ptr(&tick_cpu_sched); + int cpu = smp_processor_id(); ktime_t expires; - int cpu = smp_processor_id(); /* * If tick_nohz_get_sleep_length() ran tick_nohz_next_event(), the @@ -1114,16 +1120,6 @@ static void __tick_nohz_idle_stop_tick(struct tick_sched *ts) } } -/** - * tick_nohz_idle_stop_tick - stop the idle tick from the idle task - * - * When the next event is more than a tick into the future, stop the idle tick - */ -void tick_nohz_idle_stop_tick(void) -{ - __tick_nohz_idle_stop_tick(this_cpu_ptr(&tick_cpu_sched)); -} - void tick_nohz_idle_retain_tick(void) { tick_nohz_retain_tick(this_cpu_ptr(&tick_cpu_sched));