From patchwork Wed Feb 22 14:03:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 60548 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp597287wrd; Wed, 22 Feb 2023 06:09:53 -0800 (PST) X-Google-Smtp-Source: AK7set+h3uta81nJYEcPryGPM6TbDiNnQDHrDcyPZSUy2Y1LCqBdzfdmp6fYKJjGo8qS8yhnFZDl X-Received: by 2002:a17:903:246:b0:19c:ac96:6630 with SMTP id j6-20020a170903024600b0019cac966630mr1552886plh.52.1677074993097; Wed, 22 Feb 2023 06:09:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677074993; cv=none; d=google.com; s=arc-20160816; b=mf8njyKd+gVx9IvgqyYJgSJpjlsCfhPYpQYFOY42eRz4+ab2jL/8KO7Urss0QJHRfm QGenrJbpBhe14xRKrErfS5DQGm4ACLFcAdSvVflcMeozgV8e8wy79kAxHANYhsM15XlR hihakcV9VJpaYFnxFSP1Wcuj8xMrXTF2VRAYu+vLs3owsLA1wVdUFdzYGnjCD9Nyw2Z5 Xn2Vb/XQutMTtNAUpGkeUwUsEQIvT4pNw9Dpq0xggn2k23qytJGcNKbbxUhAEPh2G/Vf Y7GVN/OLsHyf9XgaUIE0r/+USZHCfTmwB17l2t905YnpN3Bp4NoDobSNpi/gAkjUEDAW MiuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=g5UJMcZWkv0Duw8v6BzxymiOTt/dWj5iraOc3PiPg+w=; b=iasn3k3aRcoernPovj2QljvCzfhVufkAolYanxNdQ41CCkzK6kq1U95yi3X1vcjeDi a1UWLwf8MT4XVx2l+p9UXCVWC8glWRNh4wpIgAKSWC+YkTl5xqSmC1MOVZTLacK3m+vC Nq01Bo1mCkwbTEpaY1tp3tdZbNlUVVxC84WD+855qv3VhmJNrBfV0nt/XwVybiQicB0L cO7pV2XTKEN3oUHNXc+PEXl4X7AUy88C9ehD8uyBTvu8CSZsySP365+3gYv6/vVOpBbV aV7rFxZJ/jnRjw3ijsCdh7hdGCq+E3nJo+7jFc6bH8keDrXFdlKWKui4Z32koMJkGqSY Trmw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CrArXo1e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y20-20020a170902ed5400b001945f74ad98si14530807plb.549.2023.02.22.06.09.39; Wed, 22 Feb 2023 06:09:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CrArXo1e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229631AbjBVOEE (ORCPT + 99 others); Wed, 22 Feb 2023 09:04:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230406AbjBVOEC (ORCPT ); Wed, 22 Feb 2023 09:04:02 -0500 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D8A334F4A for ; Wed, 22 Feb 2023 06:03:49 -0800 (PST) Received: by mail-wr1-x434.google.com with SMTP id j2so7663092wrh.9 for ; Wed, 22 Feb 2023 06:03:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=g5UJMcZWkv0Duw8v6BzxymiOTt/dWj5iraOc3PiPg+w=; b=CrArXo1e9kBrDozaImqVOs6XagCQmqDxyhZ0UG/P9YUyxojo5L7Q9op8Cre5bY3evD 9zgVBqb60t1BECkEf+cWMuB2gxXv3iWWetdi0Q5SA6V2hqCNFdO3xKmjjdIW2OWoon9l KOVl/+JoOq02FTFXhwwE/ULn8JScIyhfOBsUNpH3MF8bEBPDs5AdOuZ3N37joRhXClfV CNE87vf5v+dQIfwbA7SWsU4wghpzR9Q9r7PHAhiKDH0ntLAMl3yee1Rl/vZShESQdHZu nXoCSGj1XjDoK7Q1LGgin0vaeTRRnaWhEBt5Y59j2Q4flB0pQPRaek3fJD0zH9QP6e7x QB0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=g5UJMcZWkv0Duw8v6BzxymiOTt/dWj5iraOc3PiPg+w=; b=3BFjb3uV9DustCTM0PCfx0aSOH3QcNwkgAV8FgEoq1n0lC0hPSanU6rdSq2XALcgn6 YDyeTZeDw2z0Fri4Lk8ynN862ulXUEieUKG5nn/ZiGBZZOex64Qn4QJycmpK/g/ae/E/ m5G5qS7Vwoc0DqzyuPbhfiY+X3xYuuNTNVDDWJz/HP8BkC2tk+Y8zZyMV5o1cP8V2Eej pde8VFgJ3WSc6jJ/zzIEnHh72xduQph/10u9wDM/W5FsuiYjLL2tgjSexDVtQOFbMHow twW9t/6m3dgPZ7OGuoWDWCzDalZk+wAUKCRGTFkq7cuGVilau4wrsJJCFR+z9OOkt55K mRCQ== X-Gm-Message-State: AO0yUKUNdZhg0g7WhNXd2AKWyqsdRmRieVU9a+iWlQEFQOP/ldk9joHr 50ztJtT3lcaMW7eVaXyd7VyB8w== X-Received: by 2002:a5d:684c:0:b0:2c6:3d2a:435b with SMTP id o12-20020a5d684c000000b002c63d2a435bmr7946597wrw.67.1677074628089; Wed, 22 Feb 2023 06:03:48 -0800 (PST) Received: from krzk-bin.. ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id d1-20020a5d4f81000000b002c5526234d2sm6991346wru.8.2023.02.22.06.03.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 06:03:46 -0800 (PST) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Vinod Koul , Bard Liao , Pierre-Louis Bossart , Sanyog Kale , Srinivas Kandagatla , linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , stable@vger.kernel.org Subject: [PATCH] soundwire: qcom: correct setting ignore bit on v1.5.1 Date: Wed, 22 Feb 2023 15:03:43 +0100 Message-Id: <20230222140343.188691-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758540587847336615?= X-GMAIL-MSGID: =?utf-8?q?1758540587847336615?= According to the comment and to downstream sources, the SWRM_CONTINUE_EXEC_ON_CMD_IGNORE in SWRM_CMD_FIFO_CFG_ADDR register should be set for v1.5.1 and newer, so fix the >= operator. Fixes: 542d3491cdd7 ("soundwire: qcom: set continue execution flag for ignored commands") Cc: Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- drivers/soundwire/qcom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c index d5b73b7f98bf..29035cf15407 100644 --- a/drivers/soundwire/qcom.c +++ b/drivers/soundwire/qcom.c @@ -733,7 +733,7 @@ static int qcom_swrm_init(struct qcom_swrm_ctrl *ctrl) } /* Configure number of retries of a read/write cmd */ - if (ctrl->version > 0x01050001) { + if (ctrl->version >= 0x01050001) { /* Only for versions >= 1.5.1 */ ctrl->reg_write(ctrl, SWRM_CMD_FIFO_CFG_ADDR, SWRM_RD_WR_CMD_RETRIES |