diff mbox series

[v1,1/3] meson: pinctrl: use CONFIG_PINCTRL_A1 with CONFIG_ARM

Message ID 20230222115020.55867-2-avromanov@sberdevices.ru
State New
Headers
Series Meson A1 32-bit support |

Commit Message

Alexey Romanov Feb. 22, 2023, 11:50 a.m. UTC 
  Tested A1 pinctrl support for ARM and it works.

Signed-off-by: Alexey Romanov <avromanov@sberdevices.ru>
---
 drivers/pinctrl/meson/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Linus Walleij March 6, 2023, 1:45 p.m. UTC | #1 
On Wed, Feb 22, 2023 at 12:50 PM Alexey Romanov
<avromanov@sberdevices.ru> wrote:

> Tested A1 pinctrl support for ARM and it works.
>
> Signed-off-by: Alexey Romanov <avromanov@sberdevices.ru>

This patch applied to the pinctrl tree for v6.4.

Have you considered also adding || COMPILE_TEST?

Or does that break builds?

Yours,
Linus Walleij
Neil Armstrong March 6, 2023, 1:49 p.m. UTC | #2 
Hi Linus,

On 06/03/2023 14:45, Linus Walleij wrote:
> On Wed, Feb 22, 2023 at 12:50 PM Alexey Romanov
> <avromanov@sberdevices.ru> wrote:
> 
>> Tested A1 pinctrl support for ARM and it works.
>>
>> Signed-off-by: Alexey Romanov <avromanov@sberdevices.ru>
> 
> This patch applied to the pinctrl tree for v6.4.

Erf, this serie is something we would avoid, so no need to apply it for v6.4

> 
> Have you considered also adding || COMPILE_TEST?

It would be great to have || COMPILE_TEST for sure

Neil

> 
> Or does that break builds?
> 
> Yours,
> Linus Walleij
Linus Walleij March 6, 2023, 1:52 p.m. UTC | #3 
On Mon, Mar 6, 2023 at 2:49 PM <neil.armstrong@linaro.org> wrote:
> On 06/03/2023 14:45, Linus Walleij wrote:
> > On Wed, Feb 22, 2023 at 12:50 PM Alexey Romanov
> > <avromanov@sberdevices.ru> wrote:
> >
> >> Tested A1 pinctrl support for ARM and it works.
> >>
> >> Signed-off-by: Alexey Romanov <avromanov@sberdevices.ru>
> >
> > This patch applied to the pinctrl tree for v6.4.
>
> Erf, this serie is something we would avoid, so no need to apply it for v6.4

OK I take that as "Neil says NACK" and backed out the patch.

Yours,
Linus Walleij
diff mbox series

Patch

diff --git a/drivers/pinctrl/meson/Kconfig b/drivers/pinctrl/meson/Kconfig
index 64fb9e074ac6..fad688cabd05 100644
--- a/drivers/pinctrl/meson/Kconfig
+++ b/drivers/pinctrl/meson/Kconfig
@@ -57,7 +57,7 @@  config PINCTRL_MESON_G12A
 
 config PINCTRL_MESON_A1
 	tristate "Meson a1 Soc pinctrl driver"
-	depends on ARM64
+	depends on ARM || ARM64
 	select PINCTRL_MESON_AXG_PMX
 	default y