From patchwork Tue Feb 21 22:33:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Usama Arif X-Patchwork-Id: 60276 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp258028wrd; Tue, 21 Feb 2023 14:38:18 -0800 (PST) X-Google-Smtp-Source: AK7set/1UHyUwS0o82Q/4KbQsLyV1AyAvQAChbVeoJOUdClNMgooH70YbB1sqradJOSIWKBSjO+4 X-Received: by 2002:a50:fb04:0:b0:4af:601e:6034 with SMTP id d4-20020a50fb04000000b004af601e6034mr272072edq.42.1677019098304; Tue, 21 Feb 2023 14:38:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677019098; cv=none; d=google.com; s=arc-20160816; b=efQyss/UqqRa/o4WQj4FMSki3S4i4z1DI3OZYJQWYpYThGAfAJZGEmmIeB54dB1Jn2 bnE1oNLwvMspNPe2Zp7V6v4MLU4vG3ihgS7to92lVnvBYnbLso8BjYY0jQlk26ZVB6ED caaRKahFkiU6fforhiUokgVh43TtLnDkd6hFp9euYi3tFuvB0xdT2/3natMWcDfPYBVb wEOUafdi9tSSpuh6W4I38cgg3Vvt2KUV5CqiX8YXSqJJywTSXClZTl/tTfB859M2Fm9O 0q82//vanesri/ZWEHfeGk2SCee55PhHj+1jQhms45pdosozGDDC2UR9dd7txnEu0aLM KBZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=7yne835l8M0Qgk6uaQXrJLgxrNefMQSePYhKpKknocM=; b=eoHUo6E6zssYt53CLZyrsQ4TdPb+5KErUdaLArGdKC0e51TKjL7EQH4EFOI/jo79Dn M35Vyf6GeckrrfAw91uePbxzuCmOU1leDLqSBHKHv+tpPB16sQ6/1XJZD4+DtY5Sy/9d bv016clescMXFycglb7avMbE/5jqGcgrjpk5AZSofJ1c+srpc1VGMrXirP/6L1mVqUlE 3UJBhnHC4b/A5MO+cCsldKEq7fSFcW/CEp2aNihgNYBR4KKQx+sJsSqmS3XKM1EHuGdQ xjqYBRORUnTa7Y6llJqDJes1VyKNb9nVCTODc8Pa5S8nUdOU85HT8AQgqKrhe1oOhL1k A01w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=X20kH30g; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b2-20020aa7c6c2000000b004ad02463b96si19278317eds.108.2023.02.21.14.37.54; Tue, 21 Feb 2023 14:38:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=X20kH30g; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230316AbjBUWfw (ORCPT + 99 others); Tue, 21 Feb 2023 17:35:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229816AbjBUWft (ORCPT ); Tue, 21 Feb 2023 17:35:49 -0500 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 373D732E41 for ; Tue, 21 Feb 2023 14:35:47 -0800 (PST) Received: by mail-wr1-x432.google.com with SMTP id r7so5835281wrz.6 for ; Tue, 21 Feb 2023 14:35:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7yne835l8M0Qgk6uaQXrJLgxrNefMQSePYhKpKknocM=; b=X20kH30gjx7jjeCYiS6bQkNDwSInIurUWisx/6toeIFXG/YzuOPt0mhulplticXJJe USL1tmF05q+lyIutCdciaox5IYlKFbhv0HkvZ0KGkyUVo65y3mqW0WE8WVOV4ETYnps9 rdNUF4poSBGHofVV448YYuN0dPIC/EAiuXaUizBF+XTt1quvq/JXxnEAT5X3UdRYUIW5 Hx4Whh9fhnXuN0n4nICZgcnNa/s9vNuS+/7Yl5YZBeHuDoyN5NqdLcpyLQhNlsxppRA8 KIU35W3+PcULhhqvwtYaMq9NUHxUp4bWhdVUWk8Kpd4akXD9w3T4Ucb/NVDanuEwuE4O h3UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7yne835l8M0Qgk6uaQXrJLgxrNefMQSePYhKpKknocM=; b=a4tkv1aivU7wlRY2DCSUpS72/PZ8Fph73lk0fi3PIHrdO+DxQgTO2jbInNr1JuQoo8 QG3ygKi1fa2okVgcEynYUEQwuV2U6traX+DPbZSOdHP5FkFP/WBqd5HPwhz3VxTShRYu kiQx8mEvt8SUc/ZrTtmdQNM0D0I9KyBKM5sXeTnD/ydvLejrI6XvJ9CAZh/F+9h61vEV 7EikwBtOJQr1D/UKU2a+BjwnZoUqOsKuLRUSq6lUKH8Um+5NAweMJPgpnl4gA1tVHenV SK60wYBMT0mqi1o3DS9n+TypqZkpbLbcA3Yi57Y8j0c+TM1623C3zvXxS1wS93TB77MQ Vrfw== X-Gm-Message-State: AO0yUKWTQDyaIxYorFSNS8CHae21tn+Yre78qlG0E64w37ekfX9uaJe2 3PKdKVvIj+UbBCiKvcv8FBBdjQ== X-Received: by 2002:a5d:6ad0:0:b0:2bf:1ec:a068 with SMTP id u16-20020a5d6ad0000000b002bf01eca068mr6457170wrw.53.1677018945757; Tue, 21 Feb 2023 14:35:45 -0800 (PST) Received: from usaari01.cust.communityfibre.co.uk ([2a02:6b6a:b566:0:1a14:8be6:b3a9:a95e]) by smtp.gmail.com with ESMTPSA id u13-20020a5d434d000000b002c55ec7f661sm4501254wrr.5.2023.02.21.14.35.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Feb 2023 14:35:45 -0800 (PST) From: Usama Arif To: dwmw2@infradead.org, tglx@linutronix.de, kim.phillips@amd.com Cc: piotrgorski@cachyos.org, oleksandr@natalenko.name, arjan@linux.intel.com, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, x86@kernel.org, pbonzini@redhat.com, paulmck@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, rcu@vger.kernel.org, mimoja@mimoja.de, hewenliang4@huawei.com, thomas.lendacky@amd.com, seanjc@google.com, pmenzel@molgen.mpg.de, fam.zheng@bytedance.com, punit.agrawal@bytedance.com, simon.evans@bytedance.com, liangma@liangbit.com, David Woodhouse , Usama Arif Subject: [PATCH v10 2/8] cpu/hotplug: Move idle_thread_get() to Date: Tue, 21 Feb 2023 22:33:46 +0000 Message-Id: <20230221223352.2288528-3-usama.arif@bytedance.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230221223352.2288528-1-usama.arif@bytedance.com> References: <20230221223352.2288528-1-usama.arif@bytedance.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758481978048640342?= X-GMAIL-MSGID: =?utf-8?q?1758481978048640342?= From: David Woodhouse Instead of relying purely on the special-case wrapper in bringup_cpu() to pass the idle thread to __cpu_up(), expose idle_thread_get() so that the architecture code can obtain it directly when necessary. This will be useful when the existing __cpu_up() is split into multiple phases, only *one* of which will actually need the idle thread. If the architecture code is to register its new pre-bringup states with the cpuhp core, having a special-case wrapper to pass extra arguments is non-trivial and it's easier just to let the arch register its function pointer to be invoked with the standard API. Signed-off-by: David Woodhouse Reviewed-by: Thomas Gleixner Signed-off-by: Usama Arif Tested-by: Paul E. McKenney Tested-by: Kim Phillips Tested-by: Oleksandr Natalenko --- include/linux/smpboot.h | 7 +++++++ kernel/smpboot.h | 2 -- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/include/linux/smpboot.h b/include/linux/smpboot.h index 9d1bc65d226c..3862addcaa34 100644 --- a/include/linux/smpboot.h +++ b/include/linux/smpboot.h @@ -5,6 +5,13 @@ #include struct task_struct; + +#ifdef CONFIG_GENERIC_SMP_IDLE_THREAD +struct task_struct *idle_thread_get(unsigned int cpu); +#else +static inline struct task_struct *idle_thread_get(unsigned int cpu) { return NULL; } +#endif + /* Cookie handed to the thread_fn*/ struct smpboot_thread_data; diff --git a/kernel/smpboot.h b/kernel/smpboot.h index 34dd3d7ba40b..60c609318ad6 100644 --- a/kernel/smpboot.h +++ b/kernel/smpboot.h @@ -5,11 +5,9 @@ struct task_struct; #ifdef CONFIG_GENERIC_SMP_IDLE_THREAD -struct task_struct *idle_thread_get(unsigned int cpu); void idle_thread_set_boot_cpu(void); void idle_threads_init(void); #else -static inline struct task_struct *idle_thread_get(unsigned int cpu) { return NULL; } static inline void idle_thread_set_boot_cpu(void) { } static inline void idle_threads_init(void) { } #endif