diff mbox series

[v1,08/10] dt-bindings: dsp: add Fortemedia FM34 DSP

Message ID	20230221183211.21964-9-clamor95@gmail.com
State	New
Headers	Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; From: Svyatoslav Ryhel <clamor95@gmail.com> To: Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Thierry Reding <thierry.reding@gmail.com>, Jonathan Hunter <jonathanh@nvidia.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, Svyatoslav Ryhel <clamor95@gmail.com>, Maxim Schwalm <maxim.schwalm@gmail.com>, Dmitry Osipenko <digetx@gmail.com> Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linux-tegra@vger.kernel.org, linux-staging@lists.linux.dev Subject: [PATCH v1 08/10] dt-bindings: dsp: add Fortemedia FM34 DSP Date: Tue, 21 Feb 2023 20:32:09 +0200 Message-Id: <20230221183211.21964-9-clamor95@gmail.com> In-Reply-To: <20230221183211.21964-1-clamor95@gmail.com> References: <20230221183211.21964-1-clamor95@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	Fix sound on ASUS Transformers \| [v1,00/10] Fix sound on ASUS Transformers [v1,01/10] dt-bindings: sound: nvidia,tegra-audio-common: add new property [v1,02/10] sound: soc: jack: allow multiple interrupt per gpio [v1,03/10] dt-bindings: sound: nvidia,tegra-audio: add RT5631 CODEC [v1,04/10] ASoC: tegra: Support RT5631 by machine driver [v1,05/10] dt-bindings: sound: nvidia,tegra-audio: add MAX9808x CODEC [v1,06/10] ASoC: tegra: Support MAX9808x by machine driver [v1,07/10] ARM: tegra: transformers: update bindings of sound graph [v1,08/10] dt-bindings: dsp: add Fortemedia FM34 DSP [v1,09/10] staging: dsp: add support for Fortemedia FM34NE DSP [v1,10/10] ARM: tegra: transformers: bind FM34NE DSP on supported devices

Commit Message

Svyatoslav Ryhel Feb. 21, 2023, 6:32 p.m. UTC

  Add dt-binding for Fortemedia FM34NE DSP.

Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
---
 .../bindings/dsp/fortemedia,dsp.yaml          | 95 +++++++++++++++++++
 1 file changed, 95 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/dsp/fortemedia,dsp.yaml

Comments

Rob Herring Feb. 26, 2023, 7:42 p.m. UTC | #1

On Tue, Feb 21, 2023 at 08:32:09PM +0200, Svyatoslav Ryhel wrote:
> Add dt-binding for Fortemedia FM34NE DSP.
> 
> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> ---
>  .../bindings/dsp/fortemedia,dsp.yaml          | 95 +++++++++++++++++++
>  1 file changed, 95 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/dsp/fortemedia,dsp.yaml
> 
> diff --git a/Documentation/devicetree/bindings/dsp/fortemedia,dsp.yaml b/Documentation/devicetree/bindings/dsp/fortemedia,dsp.yaml
> new file mode 100644
> index 000000000000..78f30969d9bf
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/dsp/fortemedia,dsp.yaml
> @@ -0,0 +1,95 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/dsp/fortemedia,dsp.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Fortemedia DSP core
> +
> +maintainers:
> +  - Svyatoslav Ryhel <clamor95@gmail.com>
> +
> +description: |

Don't need '|'

> +  Asus Transformer T20/T30 tablet family contains a DSP core
> +  used for advanced noise cancellation.
> +
> +properties:
> +  compatible:
> +    items:
> +      - enum:
> +          - asus,tf101-dsp
> +          - asus,tf201-dsp
> +          - asus,tf300t-dsp
> +          - asus,tf700t-dsp
> +          - pegatron,chagall-dsp
> +

Drop blank line.

> +      - const: fortemedia,fm34
> +
> +  reg:
> +    maxItems: 1
> +
> +  bypass-gpios:

Needs a description what this is.

> +    maxItems: 1
> +
> +  reset-gpios:
> +    maxItems: 1
> +
> +  vdd-supply: true
> +
> +  clocks:
> +    maxItems: 1
> +
> +  clock-names:
> +    items:
> +      - const: mclk
> +
> +  assigned-clocks:
> +    maxItems: 1
> +
> +  assigned-clock-parents:
> +    maxItems: 1
> +
> +  assigned-clock-rates:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - vdd-supply
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/clock/tegra30-car.h>
> +    #include <dt-bindings/soc/tegra-pmc.h>
> +
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        dsp@60 {
> +            compatible = "asus,tf201-dsp", "fortemedia,fm34";
> +            reg = <0x60>;
> +
> +            bypass-gpios = <&gpio 222 0>;
> +            reset-gpios = <&gpio 115 1>;
> +
> +            vdd-supply = <&vdd_1v8_dsp>;
> +
> +            clocks = <&tegra_pmc TEGRA_PMC_CLK_OUT_1>;
> +            clock-names = "mclk";
> +
> +            assigned-clocks = <&tegra_pmc TEGRA_PMC_CLK_OUT_1>;
> +            assigned-clock-parents = <&tegra_car TEGRA30_CLK_EXTERN1>;
> +        };
> +    };
> +
> +    vdd_1v8_dsp: regulator-dsp {
> +        compatible = "regulator-fixed";
> +        regulator-name = "vdd_1v8_dsp";
> +        regulator-min-microvolt = <1800000>;
> +        regulator-max-microvolt = <1800000>;
> +        gpio = <&gpio 165 0>;
> +        enable-active-high;
> +    };

Drop this node. No need to show providers in consumer examples.

Rob

diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/dsp/fortemedia,dsp.yaml b/Documentation/devicetree/bindings/dsp/fortemedia,dsp.yaml
new file mode 100644
index 000000000000..78f30969d9bf
--- /dev/null
+++ b/Documentation/devicetree/bindings/dsp/fortemedia,dsp.yaml
@@ -0,0 +1,95 @@ 
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/dsp/fortemedia,dsp.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Fortemedia DSP core
+
+maintainers:
+  - Svyatoslav Ryhel <clamor95@gmail.com>
+
+description: |
+  Asus Transformer T20/T30 tablet family contains a DSP core
+  used for advanced noise cancellation.
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - asus,tf101-dsp
+          - asus,tf201-dsp
+          - asus,tf300t-dsp
+          - asus,tf700t-dsp
+          - pegatron,chagall-dsp
+
+      - const: fortemedia,fm34
+
+  reg:
+    maxItems: 1
+
+  bypass-gpios:
+    maxItems: 1
+
+  reset-gpios:
+    maxItems: 1
+
+  vdd-supply: true
+
+  clocks:
+    maxItems: 1
+
+  clock-names:
+    items:
+      - const: mclk
+
+  assigned-clocks:
+    maxItems: 1
+
+  assigned-clock-parents:
+    maxItems: 1
+
+  assigned-clock-rates:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - vdd-supply
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/tegra30-car.h>
+    #include <dt-bindings/soc/tegra-pmc.h>
+
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        dsp@60 {
+            compatible = "asus,tf201-dsp", "fortemedia,fm34";
+            reg = <0x60>;
+
+            bypass-gpios = <&gpio 222 0>;
+            reset-gpios = <&gpio 115 1>;
+
+            vdd-supply = <&vdd_1v8_dsp>;
+
+            clocks = <&tegra_pmc TEGRA_PMC_CLK_OUT_1>;
+            clock-names = "mclk";
+
+            assigned-clocks = <&tegra_pmc TEGRA_PMC_CLK_OUT_1>;
+            assigned-clock-parents = <&tegra_car TEGRA30_CLK_EXTERN1>;
+        };
+    };
+
+    vdd_1v8_dsp: regulator-dsp {
+        compatible = "regulator-fixed";
+        regulator-name = "vdd_1v8_dsp";
+        regulator-min-microvolt = <1800000>;
+        regulator-max-microvolt = <1800000>;
+        gpio = <&gpio 165 0>;
+        enable-active-high;
+    };