diff mbox series

[v1,02/10] sound: soc: jack: allow multiple interrupt per gpio

Message ID 20230221183211.21964-3-clamor95@gmail.com
State New
Headers
Series Fix sound on ASUS Transformers |

Commit Message

Svyatoslav Ryhel Feb. 21, 2023, 6:32 p.m. UTC 
  This feature is required for coupled hp-mic quirk used
by some Nvidia Tegra 3 based devices work properly.

Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
---
 sound/soc/soc-jack.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Mark Brown Feb. 21, 2023, 10:08 p.m. UTC | #1 
On Tue, Feb 21, 2023 at 08:32:03PM +0200, Svyatoslav Ryhel wrote:
> This feature is required for coupled hp-mic quirk used
> by some Nvidia Tegra 3 based devices work properly.

Please submit this separately, there's no meaningful dependency
on the rest of the series.

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.
Svyatoslav Ryhel Feb. 22, 2023, 7:53 a.m. UTC | #2 
ср, 22 лют. 2023 р. о 00:08 Mark Brown <broonie@kernel.org> пише:
>
> On Tue, Feb 21, 2023 at 08:32:03PM +0200, Svyatoslav Ryhel wrote:
> > This feature is required for coupled hp-mic quirk used
> > by some Nvidia Tegra 3 based devices work properly.
>
> Please submit this separately, there's no meaningful dependency
> on the rest of the series.

RT5631 by machine driver commit contains a coupled hp-mic quirk which
requires this commit to work properly. In v2 RT5631 machine driver bringup
and coupled hp-mic quirk may be split into separate commits.

> Please submit patches using subject lines reflecting the style for the
> subsystem, this makes it easier for people to identify relevant patches.
> Look at what existing commits in the area you're changing are doing and
> make sure your subject lines visually resemble what they're doing.
> There's no need to resubmit to fix this alone.
Mark Brown Feb. 22, 2023, 12:16 p.m. UTC | #3 
On Wed, Feb 22, 2023 at 09:53:28AM +0200, Svyatoslav Ryhel wrote:
> ср, 22 лют. 2023 р. о 00:08 Mark Brown <broonie@kernel.org> пише:

> > On Tue, Feb 21, 2023 at 08:32:03PM +0200, Svyatoslav Ryhel wrote:
> > > This feature is required for coupled hp-mic quirk used
> > > by some Nvidia Tegra 3 based devices work properly.

> > Please submit this separately, there's no meaningful dependency
> > on the rest of the series.

> RT5631 by machine driver commit contains a coupled hp-mic quirk which
> requires this commit to work properly. In v2 RT5631 machine driver bringup
> and coupled hp-mic quirk may be split into separate commits.

This is needed to get the machine driver to work at runtime but that
doesn't block getting this merged, and there's no build time dependency
in the other direction either.
diff mbox series

Patch

diff --git a/sound/soc/soc-jack.c b/sound/soc/soc-jack.c
index fcece5ca38c6..f951acb2ce36 100644
--- a/sound/soc/soc-jack.c
+++ b/sound/soc/soc-jack.c
@@ -367,6 +367,7 @@  int snd_soc_jack_add_gpios(struct snd_soc_jack *jack, int count,
 
 		ret = request_any_context_irq(gpiod_to_irq(gpios[i].desc),
 					      gpio_handler,
+					      IRQF_SHARED |
 					      IRQF_TRIGGER_RISING |
 					      IRQF_TRIGGER_FALLING,
 					      gpios[i].name,