Message ID | 20230221171919.55714-1-kilobyte@angband.pl |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp185317wrd; Tue, 21 Feb 2023 11:30:31 -0800 (PST) X-Google-Smtp-Source: AK7set/ubeA9HBN/0VrO2N+OKuOWjN3AEoYV1h/qjLXcjys1AJRCrV15yqUU3WX2DAOOmg/lR5gr X-Received: by 2002:a17:906:55d2:b0:878:7a0e:5730 with SMTP id z18-20020a17090655d200b008787a0e5730mr14587355ejp.56.1677007831015; Tue, 21 Feb 2023 11:30:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677007831; cv=none; d=google.com; s=arc-20160816; b=O5qfmZzwI3/GCHHA90YYGQYfOjGLByUVXOZfREiCOXfFMSf4u5dDl6NdAkcvcwCAnh 9mS5mMbYmwX+0IW38S9mbcj71Z5YT5rpqHkrZtfIq1DtEAZ/qyMIHlBLuztcCflBJt7Q rK8pBcmYWNgXyy/xC0emEmTMgxNoDW8Pj0wcr2uaTZBJWc7FZ+dYmqlWJWMEDbPCxZGv f2u86mPDTdcfHZhDlP965w/g5a0X4oSiwnD7E28+fq5zT1lUAry0aZFIL3GUxaKYfMmL Vl+xapkrN/oPNp0ULxRORHqmmoekg1+ZfVRUuYQOVR9odkNjlmm6Pt4qPMy6rocBic7m lQww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=i9+A1nQzdmuXy3hp3w92VyMJn5gV+HrIvYVOE27Ezgk=; b=Ul5p3vX1h8iEt4dBWQZtr9FR8pW8QEHhQM33mxLb+vNBC2xmBjrkU2TM3Q09i8DASS Taalf+e/svfCU5iaapzim5esaOl0peCKFqqwnQnoGLjooyClPIW8gcRv2MDrwdmRYfO3 36T20NXsdiwJe45BEMtxgHctQPQjowGuaBr1tLWqHY9PXIuwTrSrgRZuCUgHeMCPM/o3 fp6Qq3EbBX5POzfvu1GtUkxX2/wx1kimw3o6ZIjnk0bsPwIIXIl2kP21uFFfeFZWefN8 ItjDn2UBKwIOfhAl89tdf+QFNWX4jSakLmjrWADoobEMqMPJDTgaCaNTIKU/uuIS7q1Q eh/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@angband.pl header.s=tartarus header.b=v9OvMN6E; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fq33-20020a1709069da100b008b17e235ac3si13953796ejc.924.2023.02.21.11.30.08; Tue, 21 Feb 2023 11:30:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@angband.pl header.s=tartarus header.b=v9OvMN6E; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229736AbjBUT0Y (ORCPT <rfc822;hanasaki@gmail.com> + 99 others); Tue, 21 Feb 2023 14:26:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229639AbjBUT0X (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 21 Feb 2023 14:26:23 -0500 X-Greylist: delayed 1800 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 21 Feb 2023 11:26:21 PST Received: from tartarus.angband.pl (tartarus.angband.pl [51.83.246.204]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E63F30299; Tue, 21 Feb 2023 11:26:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=angband.pl; s=tartarus; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject: Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=i9+A1nQzdmuXy3hp3w92VyMJn5gV+HrIvYVOE27Ezgk=; b=v9OvMN6EYOa84tupTkGKC8LNTb O8cZA9v/aEP93UpM2cWoSAA0oX8pLL7SVJPPEydvivoImtvY1ht5xDHZCSeIMOGJeXvKA8AXpiTEu 8vqp+xGMu/nT/RipU/HLa8FZwk/UB7Mhv51wQB76DCj/7SByWuUOUz1Rp2zW7f2UyC3g=; Received: from localhost ([127.0.0.1] helo=valinor.angband.pl) by tartarus.angband.pl with smtp (Exim 4.96) (envelope-from <kilobyte@valinor.angband.pl>) id 1pUWIa-001Rcn-2z; Tue, 21 Feb 2023 18:19:28 +0100 Received: (nullmailer pid 55815 invoked by uid 1000); Tue, 21 Feb 2023 17:19:28 -0000 From: Adam Borowski <kilobyte@angband.pl> To: David Howells <dhowells@redhat.com>, Herbert Xu <herbert@gondor.apana.org.au>, "David S. Miller" <davem@davemloft.net>, keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Adam Borowski <kilobyte@angband.pl> Subject: [PATCH v2] certs: fips test: fix build failure with PKCS7_MESSAGE_PARSER=m Date: Tue, 21 Feb 2023 18:19:19 +0100 Message-Id: <20230221171919.55714-1-kilobyte@angband.pl> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: kilobyte@valinor.angband.pl X-SA-Exim-Scanned: No (on tartarus.angband.pl); SAEximRunCond expanded to false X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758470163234869675?= X-GMAIL-MSGID: =?utf-8?q?1758470163234869675?= |
Series |
[v2] certs: fips test: fix build failure with PKCS7_MESSAGE_PARSER=m
|
|
Commit Message
Adam Borowski
Feb. 21, 2023, 5:19 p.m. UTC
ld: crypto/asymmetric_keys/selftest.o: in function `fips_signature_selftest':
selftest.c:(.init.text+0xcd): undefined reference to `pkcs7_parse_message'
ld: selftest.c:(.init.text+0x103): undefined reference to `pkcs7_supply_detached_data'
ld: selftest.c:(.init.text+0x10d): undefined reference to `pkcs7_verify'
ld: selftest.c:(.init.text+0x135): undefined reference to `pkcs7_validate_trust'
ld: selftest.c:(.init.text+0x157): undefined reference to `pkcs7_free_message'
Fixes: 3cde3174eb91 ("certs: Add FIPS selftests")
Signed-off-by: Adam Borowski <kilobyte@angband.pl>
---
This fail still happens on randconfig runs.
v2: expanded the Fixes tag to include that commit's subject
crypto/asymmetric_keys/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Tue, Feb 21, 2023 at 06:19:19PM +0100, Adam Borowski wrote: > ld: crypto/asymmetric_keys/selftest.o: in function `fips_signature_selftest': > selftest.c:(.init.text+0xcd): undefined reference to `pkcs7_parse_message' ... and a fix for this has just been applied, I somehow missed it being on the way. That's 0f5d4a0b995faa6537c4de79973817a4f8da206a which wasn't yet in yesterday evening's pull. Sorry for noise. > ld: selftest.c:(.init.text+0x103): undefined reference to `pkcs7_supply_detached_data' > ld: selftest.c:(.init.text+0x10d): undefined reference to `pkcs7_verify' > ld: selftest.c:(.init.text+0x135): undefined reference to `pkcs7_validate_trust' > ld: selftest.c:(.init.text+0x157): undefined reference to `pkcs7_free_message' > > Fixes: 3cde3174eb91 ("certs: Add FIPS selftests") > Signed-off-by: Adam Borowski <kilobyte@angband.pl> > --- > This fail still happens on randconfig runs. > > v2: expanded the Fixes tag to include that commit's subject > > crypto/asymmetric_keys/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/crypto/asymmetric_keys/Kconfig b/crypto/asymmetric_keys/Kconfig > index 3df3fe4ed95f..fe007db96c69 100644 > --- a/crypto/asymmetric_keys/Kconfig > +++ b/crypto/asymmetric_keys/Kconfig > @@ -83,6 +83,6 @@ config FIPS_SIGNATURE_SELFTEST > for FIPS. > depends on KEYS > depends on ASYMMETRIC_KEY_TYPE > - depends on PKCS7_MESSAGE_PARSER > + depends on PKCS7_MESSAGE_PARSER=y > > endif # ASYMMETRIC_KEY_TYPE > -- Meow!
diff --git a/crypto/asymmetric_keys/Kconfig b/crypto/asymmetric_keys/Kconfig index 3df3fe4ed95f..fe007db96c69 100644 --- a/crypto/asymmetric_keys/Kconfig +++ b/crypto/asymmetric_keys/Kconfig @@ -83,6 +83,6 @@ config FIPS_SIGNATURE_SELFTEST for FIPS. depends on KEYS depends on ASYMMETRIC_KEY_TYPE - depends on PKCS7_MESSAGE_PARSER + depends on PKCS7_MESSAGE_PARSER=y endif # ASYMMETRIC_KEY_TYPE