From patchwork Tue Feb 21 16:36:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mingwei Zhang X-Patchwork-Id: 60168 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp106732wrd; Tue, 21 Feb 2023 08:38:51 -0800 (PST) X-Google-Smtp-Source: AK7set9dxvmlBSNu8QROQf2aF0RxU+A4ewlSQ4Uut9yv9EacwxrX0uNxJFJxRXk5uCOPZhWW0MYT X-Received: by 2002:a17:906:dc90:b0:8b1:304b:8e2c with SMTP id cs16-20020a170906dc9000b008b1304b8e2cmr16688627ejc.0.1676997531252; Tue, 21 Feb 2023 08:38:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676997531; cv=none; d=google.com; s=arc-20160816; b=bGYN8zke8jv/fOuOcNxR3IuoBi9GjSJyrR7Gr0DDq+VX4IFf4plPh8Lwe+Vm68toU/ zTuZAEjqXqO9rmsU7DYvNIl2fUepl7hcTXu3RO7/kbahrr/HD+rvu2ddyBa90fqXTEGw DXwYKzLYagvXsGHsknu+qMdB+YEzMzWxoP1Tw/li+vxTG/LIDlmwE0JgFrKu+k1cLOzo +8uCM8Iz23VXKsHkVN+vECR9vtVxtLi2ymoQJAQM+5LIANIRyyc3g2uPSHH3sJfYD0FM cF7ir5ifyGBGiY9CgK2d9Kr34uUVgKSz9SC7MaPYHWaC4geF60SPBm524z7Pk7GOLq6s 3XpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:reply-to:dkim-signature; bh=6eya8RvAso0oVSkPG+SqCdov6cQuqd8KcPbcmXzNxTo=; b=Yn2+jtRNzqWYDOeLhhL18AC7yRKHzSPcGtFWXhYibxMo71ZnZJ28/mbbrlS12UJHDE uwHeCntF+fa+6+85HhPEuTS5i9MpRk+R7u9XpEzMhsqkVTUNs6O+LAiyAl1UnoTilYps 2ySoAbPQlQtEUcraQ66NmnGcUl30zV72fqQ4XWTLXL/nfZTn6lzO3oNTZo9t7v4bgYs+ 6HjCwaC6HeshMm9ja6WhxCeypmY73l5vxPoELoHGoMr2CVZfRM2uN9VP+wfw8vXtMi3I jp3baeIy3X6dvVl8CyWIdQ5homPddMMvEghWDZHv0Fxuoc/Tq/D7tk4prAONrCbJhnOi zdnA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=TVd18GDS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v26-20020a17090610da00b008b19489a9eesi18163227ejv.602.2023.02.21.08.38.27; Tue, 21 Feb 2023 08:38:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=TVd18GDS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234909AbjBUQiE (ORCPT + 99 others); Tue, 21 Feb 2023 11:38:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234853AbjBUQhn (ORCPT ); Tue, 21 Feb 2023 11:37:43 -0500 Received: from mail-pf1-x449.google.com (mail-pf1-x449.google.com [IPv6:2607:f8b0:4864:20::449]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9DC22A6E0 for ; Tue, 21 Feb 2023 08:37:31 -0800 (PST) Received: by mail-pf1-x449.google.com with SMTP id a23-20020a62bd17000000b0058db55a8d7aso2191386pff.21 for ; Tue, 21 Feb 2023 08:37:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1676997451; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=6eya8RvAso0oVSkPG+SqCdov6cQuqd8KcPbcmXzNxTo=; b=TVd18GDSarLsA2/lPOgVrYfYPYZtvFYr4jPuI+f6by2zc3e5pGx1TLe7+8F/v5CLcD C+ZUrDVI4U1jkWxXvQCJTohZULj91OSBWXga7XMNHoIQ3y9p1MLfmHOOfYPQREsSOSVx g2LY0iK/jP8K4IOeK/N+J+awTSjk0wSuqNeNvwP34Qzf7NDM+YArW/aoRPdbQATy4QU1 iVfIDNRyN55PI5w/GyAPsWGgV/GAQlDYeyBx5D/HeDQ9QmeP44S8Gix/v/R9ZkOr8sJU QoVSUyIk00vSaTEyVgZc4PCsBDX7yXWROpx9vZXMV81E9I5nSvgGpWREuTz/5ZJP9+KS vIXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1676997451; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6eya8RvAso0oVSkPG+SqCdov6cQuqd8KcPbcmXzNxTo=; b=GBPQgzphgi14AnEwlWZp1BgaUpGYY2/+LqQv2j5mbHBtiEF0fp+wGCEi3qKGp+EVF2 giYo+DFSTyBk/yeq6WEL3as6j3WIJzMyfY3wR/v7y67iS+DpcLIiCIlMTOt7YqN1/OiN hXzZkG+7c4j8LzJnQcHl0m0rV7iVfJMyQKxo+uPQaeLEaA+lvW5tveZwSgSzDmjctbG4 od8zkHciqaM6qhzGn/29/8uquirew9vSGcBe1OQfudfgCVl5YIakCNax7Fhod0steTF3 wuQXh28EczZqzvNNF6TxnJU4B0w7l2/01cDM4ictMqGd1yABu2eqZVDuRkA3gsQ+qUrF XPvQ== X-Gm-Message-State: AO0yUKVp63UJaLjoVMqWhEyW/gfXyi8DO3RTq2fsYN+uVrB4/1X1qehX 5ReHEn0Q3xLyYNdts+IPvgik/TJtrjrd X-Received: from mizhang-super.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:1071]) (user=mizhang job=sendgmr) by 2002:a62:c143:0:b0:593:d4cb:dba2 with SMTP id i64-20020a62c143000000b00593d4cbdba2mr655957pfg.13.1676997451249; Tue, 21 Feb 2023 08:37:31 -0800 (PST) Reply-To: Mingwei Zhang Date: Tue, 21 Feb 2023 16:36:50 +0000 In-Reply-To: <20230221163655.920289-1-mizhang@google.com> Mime-Version: 1.0 References: <20230221163655.920289-1-mizhang@google.com> X-Mailer: git-send-email 2.39.2.637.g21b0678d19-goog Message-ID: <20230221163655.920289-9-mizhang@google.com> Subject: [PATCH v3 08/13] KVM: selftests: x86: Repeat the checking of xheader when IA32_XFD[XTILEDATA] is set in amx_test From: Mingwei Zhang To: Sean Christopherson , Paolo Bonzini , Thomas Gleixner Cc: "H. Peter Anvin" , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, Mingwei Zhang , Jim Mattson , Venkatesh Srinivas , Aaron Lewis , "Chang S. Bae" , Chao Gao X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758459363589746965?= X-GMAIL-MSGID: =?utf-8?q?1758459363589746965?= Repeat the checking of AMX component in xheader after XSAVEC when IA32_XFD[XTILEDATA] is set. This check calibrates the functionality scope of IA32_XFD: it does not intercept the XSAVE state management. Regardless of the values in IA32_XFD, AMX component state will still be managed by XSAVE* and XRSTOR* as long as the corresponding bits are set XCR0. Signed-off-by: Mingwei Zhang --- tools/testing/selftests/kvm/x86_64/amx_test.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/tools/testing/selftests/kvm/x86_64/amx_test.c b/tools/testing/selftests/kvm/x86_64/amx_test.c index 62fff3363b3b..724e991ba814 100644 --- a/tools/testing/selftests/kvm/x86_64/amx_test.c +++ b/tools/testing/selftests/kvm/x86_64/amx_test.c @@ -201,6 +201,16 @@ static void __attribute__((__flatten__)) guest_code(struct tile_config *amx_cfg, /* xfd=0x40000, disable amx tiledata */ wrmsr(MSR_IA32_XFD, XFEATURE_MASK_XTILEDATA); + + /* + * XTILEDATA is cleared in xstate_bv but set in xcomp_bv, this property + * remains the same even when amx tiledata is disabled by IA32_XFD. + */ + xstate->header.xstate_bv = XFEATURE_MASK_XTILEDATA; + __xsavec(xstate, XFEATURE_MASK_XTILEDATA); + GUEST_ASSERT(!(xstate->header.xstate_bv & XFEATURE_MASK_XTILEDATA)); + GUEST_ASSERT((xstate->header.xcomp_bv & XFEATURE_MASK_XTILEDATA)); + GUEST_SYNC(6); GUEST_ASSERT(rdmsr(MSR_IA32_XFD) == XFEATURE_MASK_XTILEDATA); set_tilecfg(amx_cfg);