From patchwork Tue Feb 21 16:36:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mingwei Zhang X-Patchwork-Id: 60166 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp106593wrd; Tue, 21 Feb 2023 08:38:32 -0800 (PST) X-Google-Smtp-Source: AK7set9rEojmx1cxAvQ/+1xpi8RiqrecnYXQadpuHNKyDDChCWZmgBoHVzzbYBA9iQQZ3pOcpd6J X-Received: by 2002:a17:907:33cc:b0:895:58be:94a with SMTP id zk12-20020a17090733cc00b0089558be094amr13359357ejb.14.1676997512147; Tue, 21 Feb 2023 08:38:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676997512; cv=none; d=google.com; s=arc-20160816; b=IYLlYKZnpTNHMkbQ6C/9F81I2jBrHJfuAz5EEqFuHXbp1bL2XvIJ0ZOw9hJnrr5caI zcbtBY5W8W2DmEXHPh5/vI8Srxdiqpu43VYwXDgtUUq+D1KUp2AJOwHhDbZRYmnqTZcy zIkPbwtqmfkxGuyzBRDrdhaNbd3US11zZtfTuWdqZLaonL3AG27wED9BXsLrk/a030pn s3pSwZ2z9q9g3ZxaxFeEa0LUgRTXG1uRZIJcxh1FoP7tMrGNZRJXk1og8mrQ5O7B6+KI BKOTkTJu3031POUNIGhtIN4xLyJs0psTDep00lZVqJP/RdI3SHk77BeeVTaaRHJPQMmg wbhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:reply-to:dkim-signature; bh=LHzOHHZRF0Z0PxEe7g90IRKekQBPW5kSPBGZ896mCAw=; b=i23jlB5wstiXrHp8nwppF2NivgK+ypL2LWZPSMXQSTmcAivCBS1mO02mQ4uK3r6MY3 BBkYfVgvlhyyOrvyo1Iz+oltN8SvAxq5a2CzUDXqliM7OvUH9qkDx5XsbFPy1vqt8/92 tDwNpuNHrYkqgedv1aVe9sjIUlGinkzUHVfgjmd4GHx0k7sFZYB7tQnDosL7LxOZTzk5 /mqwhSzUQ+s/WUcAFfUUtF8LXqivm2RvLZXKJZLlpCWaFrlg9pBBvZlpO/rhEo+Oq+r1 olkNyIXPFE1Jxhvb3j3vP2Dg07dYvWy94yORcFcKoH/YQJfrmq9I3j0CNG7oh6WE7zXB qv+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b="iYq/M/sw"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mz13-20020a1709071b8d00b008be3fe9b454si10865312ejc.111.2023.02.21.08.38.08; Tue, 21 Feb 2023 08:38:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b="iYq/M/sw"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234707AbjBUQhi (ORCPT + 99 others); Tue, 21 Feb 2023 11:37:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234771AbjBUQha (ORCPT ); Tue, 21 Feb 2023 11:37:30 -0500 Received: from mail-pg1-x549.google.com (mail-pg1-x549.google.com [IPv6:2607:f8b0:4864:20::549]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F59A2CFE0 for ; Tue, 21 Feb 2023 08:37:26 -0800 (PST) Received: by mail-pg1-x549.google.com with SMTP id g15-20020a63200f000000b004fb0bd64941so1970204pgg.16 for ; Tue, 21 Feb 2023 08:37:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=LHzOHHZRF0Z0PxEe7g90IRKekQBPW5kSPBGZ896mCAw=; b=iYq/M/swxMz4Ajz5CWey7J9Cn2hGpOfZNKoeQVqLmLqWDDu83kf7cKxB5F54bE8hgY 6vq352hL3hkuyr+xvGGBPsMBFVU/kUaywZAPGbjpw45pwBVNsUBhXvaHp3p5ij76cNyt rDAfZbAgReB4EQSAA7OwInJ6lY9U5BvKp/01wMwOxtpg44NJRhHT8Xq4rTmDcrsxjTti pfGVpDEXEfEJGnxNtzFVmYPT2BiwBWDwDKgsfrnnVyf/fxGl4166/OjhO4zVgoSeAI5l SvSQxAOupvX+FgQXWxfzi4j2RPAPPbmJeclJTu28XTV+YePpR+2e/aj+jRqUzJYVs/du fzmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LHzOHHZRF0Z0PxEe7g90IRKekQBPW5kSPBGZ896mCAw=; b=sZfOtHjbx+ll+IU7aCtuTisl63GWNmQb+n+3EbpzGW6/7B67qpSXdXkFZhXZzm1C4b JYExMbtRHR4dru/iqqebKGnrR1Dxo+lI4VlfRFCebXUScCbzr+RgiV5gJrFiTkWeOWTY SLnmv6/CGmnf/E7ZfwU7eQNvfmCAArMlG5Om6bary6E4hrRILIJ12NNJeAvhNnYILDOQ b56Ey0B2f8uh0V3rfVi5a8EyKHhL1H8OJG+vxRq0BdgSf2UtPVPTWWJZx6oo+gaj2xcs 22Qz1lfmMDI8tMffrsx3x/t2Sx9X0dUGYCNTyY0zALq7WUBLgEi7OLuDlEKjFy70ZLUF /F6Q== X-Gm-Message-State: AO0yUKWIiqX1JCvMKeTUUhTVklwQ07d0MGKHZ+0HCNeTNBj/9mfxqu9g O+ajTlxIVBntHenadN6ZYHGsFiyZWJh3 X-Received: from mizhang-super.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:1071]) (user=mizhang job=sendgmr) by 2002:a63:3344:0:b0:502:e48d:6ea7 with SMTP id z65-20020a633344000000b00502e48d6ea7mr9485pgz.10.1676997445850; Tue, 21 Feb 2023 08:37:25 -0800 (PST) Reply-To: Mingwei Zhang Date: Tue, 21 Feb 2023 16:36:47 +0000 In-Reply-To: <20230221163655.920289-1-mizhang@google.com> Mime-Version: 1.0 References: <20230221163655.920289-1-mizhang@google.com> X-Mailer: git-send-email 2.39.2.637.g21b0678d19-goog Message-ID: <20230221163655.920289-6-mizhang@google.com> Subject: [PATCH v3 05/13] KVM: selftests: x86: Add check of CR0.TS in the #NM handler in amx_test From: Mingwei Zhang To: Sean Christopherson , Paolo Bonzini , Thomas Gleixner Cc: "H. Peter Anvin" , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, Mingwei Zhang , Jim Mattson , Venkatesh Srinivas , Aaron Lewis , "Chang S. Bae" , Chao Gao X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758459343258731856?= X-GMAIL-MSGID: =?utf-8?q?1758459343258731856?= Add check of CR0.TS[bit 3] before the check of IA32_XFD_ERR in the #NM handler in amx_test. This is because XFD may not be the only reason of the IA32_XFD MSR and the bitmap corresponding to the state components required by the faulting instruction." (Intel SDM vol 1. Section 13.14) Add the missing check of CR0.TS. Signed-off-by: Mingwei Zhang --- tools/testing/selftests/kvm/x86_64/amx_test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/kvm/x86_64/amx_test.c b/tools/testing/selftests/kvm/x86_64/amx_test.c index ba8c0afdbac8..ac49b14460b6 100644 --- a/tools/testing/selftests/kvm/x86_64/amx_test.c +++ b/tools/testing/selftests/kvm/x86_64/amx_test.c @@ -216,6 +216,7 @@ void guest_nm_handler(struct ex_regs *regs) { /* Check if #NM is triggered by XFEATURE_MASK_XTILEDATA */ GUEST_SYNC(7); + GUEST_ASSERT((get_cr0() & X86_CR0_TS) == 0); GUEST_ASSERT(rdmsr(MSR_IA32_XFD_ERR) == XFEATURE_MASK_XTILEDATA); GUEST_SYNC(8); GUEST_ASSERT(rdmsr(MSR_IA32_XFD_ERR) == XFEATURE_MASK_XTILEDATA);