From patchwork Tue Feb 21 16:36:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mingwei Zhang X-Patchwork-Id: 60163 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp106490wrd; Tue, 21 Feb 2023 08:38:21 -0800 (PST) X-Google-Smtp-Source: AK7set8WIfccltyACFqJH4OlrkGa0pkaXRvuC1msS7+MYMtkFo+aLQBqN4qOwil3tTkGZtBtsxx7 X-Received: by 2002:a05:6402:286:b0:4ad:6ca7:612c with SMTP id l6-20020a056402028600b004ad6ca7612cmr5794919edv.27.1676997500976; Tue, 21 Feb 2023 08:38:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676997500; cv=none; d=google.com; s=arc-20160816; b=si+XEd9Nen96al3bkdNEnY9ySnlKuNXA3OvMdUgwMHFb8agNyl4h6/6vha9lYsFwb0 V6NrC3mxvGjgn8nbUxUj+iNpjoa/rYGltQkLbjN/WnyGs9pPtf9wBF2JrHVVGhi3aNNx hMm1MB6LtBsmG3ZCZiBZYQpr3l6s+qayCyyOrLn8DKFhqvmq/rzV7d/HE/rSO9qGQe23 SJiCmaBQfuO42e3ajHiobFWBTnuVWSoQr+5kuMrpRse8wztA+MVF8W/rp35+T6N/t7AM Bx+8rWSE92OfTe/IBD1nFDeXHh8TW1uQQ1KM7U5cH3Vly6PsQpTpvL/0CR9I2jbKx0/K e4Kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:reply-to:dkim-signature; bh=AyHb4Yx7urg+Zx7LCzA3DPIwt3rV/2dFui2+3APs9Tw=; b=NIUwmvFG8U4tsm/EMNveAmR/acVrjnbEAAKFi+CiwqP2OSsIlOnChsTdaMxx+dOxG/ X+ZiYiOj5uQ8JRIrxib5ifdyC/LsJetqU+HJ225wnasxWO7+vMgf/OzuTiCcVauNz1F6 aAsO6G6NfQQxIg+m9/KTZ9cqGEdVxbso7iyijFqCuFs1dhy9NSOi4o+VqzgaLbdiB04o UjHB9tdttV4EwjmL4VcaVBtGQPmi+VPhJjFR9TIJz/VhOCYaD4oSn+wZCm5cZEx0lSbq AueZW7TPgiIFky3bPLc8O7UWl+4yD+84L6D3CDP0Pg8qB30B84zl7zhZFReAa5HeIx9w ixAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=rJnHYpiq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e2-20020a50fb82000000b004acc68a5878si107726edq.274.2023.02.21.08.37.58; Tue, 21 Feb 2023 08:38:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=rJnHYpiq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234804AbjBUQhd (ORCPT + 99 others); Tue, 21 Feb 2023 11:37:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234742AbjBUQh3 (ORCPT ); Tue, 21 Feb 2023 11:37:29 -0500 Received: from mail-pj1-x104a.google.com (mail-pj1-x104a.google.com [IPv6:2607:f8b0:4864:20::104a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2EC26279AA for ; Tue, 21 Feb 2023 08:37:23 -0800 (PST) Received: by mail-pj1-x104a.google.com with SMTP id d5-20020a17090a6a4500b00233fbf2cc15so2585268pjm.3 for ; Tue, 21 Feb 2023 08:37:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=AyHb4Yx7urg+Zx7LCzA3DPIwt3rV/2dFui2+3APs9Tw=; b=rJnHYpiq5KubUJYTSiL6hLKa3WdBN7dObACs3EooXynZnDtSUFMMac+rcUMHzOwXan N1auXr5kJDb0xBpddo87Mu10IQGJR64S8FHMz7w2VZCZrOABJv8RJQfeccvr41wzKuom CcPj7lu4XfpGMjIfHZj+AZxChF9kGaoUu1jJT6X6HY6KZdk9lD/y8fCAy9NdLTQ8U65X zFbtEdVVKjkf9uhBse6jbZoYCl5miFUFGutHh65L/bFqbxAsG3kbRVKbd+BUT/X+7qyw k4CuWZv7SUWSuzzMxtGskoyZqxq30YuNSC4xEkZuIFkGG0liJhveNy5yECEk8jlwxhMu w4yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AyHb4Yx7urg+Zx7LCzA3DPIwt3rV/2dFui2+3APs9Tw=; b=hpixdgmMC0Kd6kLDPfg/rBK+2eLQr46rB5ewugd9b8VwlMDkOidLq9jpm7iyZ27oq7 acsR2dU6bWzOkqxKK8VOOv1rw6o47+gSVc7i6i/e2UmYAUsRWMmEJzRWEE8z40KN+9IL sBMr0KmioJkonFLnOKC9LNyl2O2xYCf/Pd0KYg2wB1Z3IyBQIjT2mEge1/APYfTKnqF9 Wgydebp9J6Wvm/cIDUASy1B5QAJSYY4U4MdT9lnuTdou1ytlGy95dJm5XYT40C+gRfJf DEYeptpnv+gvomuVSXPSWvZEBpkU3cvWgjs8wyx/Qv56dxSIdP8slHNbtPqqwChtmGRT r2Tg== X-Gm-Message-State: AO0yUKWn5nFtw10w//lehmramwZi3ovu2VSdWl5zJLU1KpRawmEbDAP7 kEry15SR4R0E+GWjYXiprWAXvO1kaDaF X-Received: from mizhang-super.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:1071]) (user=mizhang job=sendgmr) by 2002:a62:de44:0:b0:5a8:670c:c94e with SMTP id h65-20020a62de44000000b005a8670cc94emr859351pfg.12.1676997442517; Tue, 21 Feb 2023 08:37:22 -0800 (PST) Reply-To: Mingwei Zhang Date: Tue, 21 Feb 2023 16:36:45 +0000 In-Reply-To: <20230221163655.920289-1-mizhang@google.com> Mime-Version: 1.0 References: <20230221163655.920289-1-mizhang@google.com> X-Mailer: git-send-email 2.39.2.637.g21b0678d19-goog Message-ID: <20230221163655.920289-4-mizhang@google.com> Subject: [PATCH v3 03/13] KVM: selftests: x86: Fix an error in comment of amx_test From: Mingwei Zhang To: Sean Christopherson , Paolo Bonzini , Thomas Gleixner Cc: "H. Peter Anvin" , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, Mingwei Zhang , Jim Mattson , Venkatesh Srinivas , Aaron Lewis , "Chang S. Bae" , Chao Gao X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758459331827920466?= X-GMAIL-MSGID: =?utf-8?q?1758459331827920466?= After the execution of __tilerelease(), AMX component will be in INIT state. Therefore, execution of XSAVEC saving the AMX state into memory will cause the xstate_bv[18] cleared in xheader. However, the xcomp_bv[18] will remain set. Fix the error in comment. Also, update xsavec() to XSAVEC because xcomp_bv[18] is set due to the instruction, not the function. Finally, use XTILEDATA instead 'bit 18' in comments. Cc: Jim Mattson Cc: Venkatesh Srinivas Cc: Aaron Lewis Signed-off-by: Mingwei Zhang --- tools/testing/selftests/kvm/x86_64/amx_test.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/kvm/x86_64/amx_test.c b/tools/testing/selftests/kvm/x86_64/amx_test.c index bb9dc0008f43..16c857c1052e 100644 --- a/tools/testing/selftests/kvm/x86_64/amx_test.c +++ b/tools/testing/selftests/kvm/x86_64/amx_test.c @@ -190,7 +190,10 @@ static void __attribute__((__flatten__)) guest_code(struct tile_config *amx_cfg, GUEST_SYNC(4); __tilerelease(); GUEST_SYNC(5); - /* bit 18 not in the XCOMP_BV after xsavec() */ + /* + * After XSAVEC, XTILEDATA is cleared in the xstate_bv but is set in + * the xcomp_bv. + */ xstate->header.xstate_bv = XFEATURE_MASK_XTILEDATA; __xsavec(xstate, XFEATURE_MASK_XTILEDATA); GUEST_ASSERT(!(xstate->header.xstate_bv & XFEATURE_MASK_XTILEDATA));