From patchwork Tue Feb 21 11:34:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Borislav Petkov X-Patchwork-Id: 59875 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1812055wrn; Tue, 21 Feb 2023 03:35:36 -0800 (PST) X-Google-Smtp-Source: AK7set8v3lbznmtIgcSotj5LP4EeKG+feHNpoVGamFHMiSlElGaNfA96jc6tNn/YSQUl8yhwb3mT X-Received: by 2002:a17:906:8601:b0:89c:d072:e33e with SMTP id o1-20020a170906860100b0089cd072e33emr10772108ejx.49.1676979336257; Tue, 21 Feb 2023 03:35:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676979336; cv=none; d=google.com; s=arc-20160816; b=KtFfA4oGch/G6kmmpWwWkL+f6OimqtJskO+zAhLlRDzTQ4cMRZnR8pi3NG4T7JvvCQ sSlXCN2snmaclkZc/wmocDHc3Q1v5AD3J5LK29/2uIsUNco/6UuY3jPRRIuz20zQsRgS H0osb2xlZF6Wlsu9UV3mbKwxzFC/7I9l81ekQpjjRQUhoDMxxcWUKnxSkr6ygJsA5Qk6 fVMNkwwvjVHCufjyUL+2vC3iaTuWM+noFp9FnuRa+imBess7SIoM2VvQNyxbhzh6XLN1 4CRbVRASHgsUogBuOTOFY3Tnh/nR48ttK/SDAYYkpPVi1Xty5oNGnxdFoDZbTvIZYv1G 3doA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=fmJP6KJzP645UaTSE0lRF5lUFM34wl43txCaH4JG/ds=; b=Z4Jx4JpscYV3SfosOudaetixTktr3gY+1RgzsRMTH+xCZP1U+RGgCJmiPPnKQMlWPX WWDt57VJlnT/n0h4sYTtHZ8WyDnm1LnN0qbBpbVNdsBqtWALXP69UgB3Fjws17GKuGVX soin0x5I+DMx+c2SKIssbrR1MakuJzVrBZ/TcrUit5teIIggwIZjzQNiUdIBbUKgy8hh X3GqDwc9HV7cOlViR56k3aRNedf1bSvZUdSFinHaV1+z5xdiLumr3OS423lGM1tGxh04 KDOEex+qZaWnRb2q1IaP/9tsLBqyLCJoV3KJg4otiIX0Lp27yTIcS/114uDQ3mYl0Qdg ixug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=gr+Ft10d; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n29-20020a17090673dd00b008b25e3ed221si18638383ejl.162.2023.02.21.03.35.13; Tue, 21 Feb 2023 03:35:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=gr+Ft10d; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233775AbjBULel (ORCPT + 99 others); Tue, 21 Feb 2023 06:34:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233677AbjBULek (ORCPT ); Tue, 21 Feb 2023 06:34:40 -0500 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F844234CA for ; Tue, 21 Feb 2023 03:34:38 -0800 (PST) Received: from zn.tnic (p5de8e9fe.dip0.t-ipconnect.de [93.232.233.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id B7E561EC064D; Tue, 21 Feb 2023 12:34:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1676979276; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fmJP6KJzP645UaTSE0lRF5lUFM34wl43txCaH4JG/ds=; b=gr+Ft10dPKgV49IOliEOEH6OOeK1mkIT1loIM1M/fMuVqQ3tJZgbmQy7PpsirIEuEwMHOf JOXiXKY+LNCKKaxs6n5oY8RWbpub0Vft/lwwfzMbCv7vQU/PuvN6mX5I69/r/VZbAbYQWu T1bhTRA4CSVexbPlRIP74fjb9yyI29k= From: Borislav Petkov To: LKML Cc: Dionna Glaze , Joerg Roedel , Michael Roth , Nikunj A Dadhania , Peter Gonda , Tom Lendacky , linux-coco@lists.linux.dev, x86@kernel.org Subject: [PATCH -v2 02/11] virt/coco/sev-guest: Check SEV_SNP attribute at probe time Date: Tue, 21 Feb 2023 12:34:19 +0100 Message-Id: <20230221113428.19324-3-bp@alien8.de> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20230221113428.19324-1-bp@alien8.de> References: <20230221113428.19324-1-bp@alien8.de> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758440284757129807?= X-GMAIL-MSGID: =?utf-8?q?1758440284757129807?= From: "Borislav Petkov (AMD)" No need to check it on every ioctl. And yes, this is a common SEV driver but it does only SNP-specific operations currently. This can be revisited later, when more use cases appear. No functional changes. Signed-off-by: Borislav Petkov (AMD) --- arch/x86/kernel/sev.c | 3 --- drivers/virt/coco/sev-guest/sev-guest.c | 3 +++ 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/kernel/sev.c b/arch/x86/kernel/sev.c index 679026a640ef..c644c34372e8 100644 --- a/arch/x86/kernel/sev.c +++ b/arch/x86/kernel/sev.c @@ -2183,9 +2183,6 @@ int snp_issue_guest_request(u64 exit_code, struct snp_req_data *input, unsigned struct ghcb *ghcb; int ret; - if (!cc_platform_has(CC_ATTR_GUEST_SEV_SNP)) - return -ENODEV; - if (!fw_err) return -EINVAL; diff --git a/drivers/virt/coco/sev-guest/sev-guest.c b/drivers/virt/coco/sev-guest/sev-guest.c index 4ec4174e05a3..edaf6031c6d9 100644 --- a/drivers/virt/coco/sev-guest/sev-guest.c +++ b/drivers/virt/coco/sev-guest/sev-guest.c @@ -689,6 +689,9 @@ static int __init sev_guest_probe(struct platform_device *pdev) void __iomem *mapping; int ret; + if (!cc_platform_has(CC_ATTR_GUEST_SEV_SNP)) + return -ENODEV; + if (!dev->platform_data) return -ENODEV;