From patchwork Tue Feb 21 05:03:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksij Rempel X-Patchwork-Id: 59764 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1685823wrn; Mon, 20 Feb 2023 21:28:33 -0800 (PST) X-Google-Smtp-Source: AK7set+WsgZPo2obivgMdK+cyAa/N5EMFfwxhXLaMI5LlAynB9/ty3EbHwh0Oj2oBoHg8T9MXErl X-Received: by 2002:a17:902:e851:b0:19b:c2d:1222 with SMTP id t17-20020a170902e85100b0019b0c2d1222mr4457952plg.52.1676957313573; Mon, 20 Feb 2023 21:28:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676957313; cv=none; d=google.com; s=arc-20160816; b=YIGQ7Sn30PkblsgfYIwGpAZ/x+X4VdQRusXy2Mk3ZhUiFo3riPKbUZifz9ySfJNpqO GHIWA3FyBmSaRfTP/51b4njbL3LBCCmfQMaJJDP1wjsRqaChCHb113XY0uRRFrJb2e8R KBab4d63btYIUHA+/k9Xa2gMcd6dh09xh4Q2VKZStFcuGhgfTarRbKWzoX0cmKJWGLj4 Wj5cqyWTqa+9smLnnLT/LfkLNxFmh8OYoEOhgZJr7U6lzuRxIzxUPMFRu6pvFqbBy0Re id/uMNt2xcXAcnRpRiFMZipmWvtYDnIE7nme9GmBQP1wCRXDHFKURfD9FAzW80QnOdwa /2dQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=giOd3toHora3wSyWYoA9I2ZF65BstJMjLh/bsPULFt4=; b=SG3F6V/LP1VQrh3GNaPKbkmxWnS+W+Xtpu0MjvzoINokajUrVNkuvkAJMoX3BRQXQa An2la4tO+suRGAgARNyIxmPqUJOM8PF89/lhpkRN4kz/8HDLlStffotvA9Mir2tU19Qa 5jffx21W405fTkJR/+1FRcL4hdO27yzx6Mj+gDs4dRZc/+nDLhiw5OVp3DgtGvU5cXaL yTxZDj/XpHd4fi32Zo3KIX50AdSsabqwbIr7n1O1Njfb6dPyaTj+D+PbDf3GF/IrNW5U 9i1Dtk2S3vXj0YLSKZPvmiwlHBx6FS3Jc6pOpnwaNhcz2cpodYoNzamBKXVMw1m3T7Vl WtFw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p18-20020a170902ebd200b00198c3291944si12376050plg.44.2023.02.20.21.28.20; Mon, 20 Feb 2023 21:28:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232507AbjBUFD4 (ORCPT + 99 others); Tue, 21 Feb 2023 00:03:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229626AbjBUFDu (ORCPT ); Tue, 21 Feb 2023 00:03:50 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 908691E284 for ; Mon, 20 Feb 2023 21:03:47 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pUKoU-0002zy-4I; Tue, 21 Feb 2023 06:03:38 +0100 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pUKoR-006PyT-IN; Tue, 21 Feb 2023 06:03:36 +0100 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pUKoR-002QNs-Oj; Tue, 21 Feb 2023 06:03:35 +0100 From: Oleksij Rempel To: Andrew Lunn , Heiner Kallweit , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Oleksij Rempel , Russell King , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Russell King Subject: [PATCH net-next v2 1/4] net: phy: c45: use "supported_eee" instead of supported for access validation Date: Tue, 21 Feb 2023 06:03:31 +0100 Message-Id: <20230221050334.578012-2-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230221050334.578012-1-o.rempel@pengutronix.de> References: <20230221050334.578012-1-o.rempel@pengutronix.de> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758417192036632342?= X-GMAIL-MSGID: =?utf-8?q?1758417192036632342?= Make sure we use proper variable to validate access to potentially not supported registers. Otherwise we will get false read/write errors. Fixes: 022c3f87f88e ("net: phy: add genphy_c45_ethtool_get/set_eee() support") Signed-off-by: Oleksij Rempel Reviewed-by: Russell King (Oracle) --- drivers/net/phy/phy-c45.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/phy/phy-c45.c b/drivers/net/phy/phy-c45.c index f9b128cecc3f..f23cce2c5199 100644 --- a/drivers/net/phy/phy-c45.c +++ b/drivers/net/phy/phy-c45.c @@ -674,7 +674,7 @@ int genphy_c45_write_eee_adv(struct phy_device *phydev, unsigned long *adv) { int val, changed; - if (linkmode_intersects(phydev->supported, PHY_EEE_CAP1_FEATURES)) { + if (linkmode_intersects(phydev->supported_eee, PHY_EEE_CAP1_FEATURES)) { val = linkmode_to_mii_eee_cap1_t(adv); /* In eee_broken_modes are stored MDIO_AN_EEE_ADV specific raw @@ -726,7 +726,7 @@ static int genphy_c45_read_eee_adv(struct phy_device *phydev, { int val; - if (linkmode_intersects(phydev->supported, PHY_EEE_CAP1_FEATURES)) { + if (linkmode_intersects(phydev->supported_eee, PHY_EEE_CAP1_FEATURES)) { /* IEEE 802.3-2018 45.2.7.13 EEE advertisement 1 * (Register 7.60) */ @@ -762,7 +762,7 @@ static int genphy_c45_read_eee_lpa(struct phy_device *phydev, { int val; - if (linkmode_intersects(phydev->supported, PHY_EEE_CAP1_FEATURES)) { + if (linkmode_intersects(phydev->supported_eee, PHY_EEE_CAP1_FEATURES)) { /* IEEE 802.3-2018 45.2.7.14 EEE link partner ability 1 * (Register 7.61) */