From patchwork Mon Feb 20 13:56:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksij Rempel X-Patchwork-Id: 59452 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1319534wrn; Mon, 20 Feb 2023 05:57:10 -0800 (PST) X-Google-Smtp-Source: AK7set8aaDpt7ecjR9MI8SHU0GIgt12qSp96ZGalEwxLUtlxiVmULHqujIMhlMfD/zz3/1RkICOV X-Received: by 2002:a17:90b:4b0a:b0:234:b35b:f905 with SMTP id lx10-20020a17090b4b0a00b00234b35bf905mr2120230pjb.2.1676901430214; Mon, 20 Feb 2023 05:57:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676901430; cv=none; d=google.com; s=arc-20160816; b=F2NemBG3ilJfeljGwKqZzY4MUMwlWMvUYtEOovllEG4DoANqixRmLaWX2OWW2kYW5K qu84gkDK3tQM4CP1nRzMSqqezcQdRX2edQRXW5DJnHeuEpZ925xHYG8aPPTKq4iygU2b sbfnZ2pn8yTDZv9p2L7akdYjHq1fxStz02uura33rkfkejQJL4WYlbBkwFzFJpN2W6Ky ANkPMjDz7tduG9XPWG/vO0KQeSwE05ueuqE/EwUXGyXO15Hpi+4zW+bvFjulbL4d9aIl v7g2aZ4OPJjqlXeaaTvsZ1j0T8kJr92QktMZZEjlQoYfQ1ZKgyDpROmZeOt0r45MU8GS sYlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=kuHfJMzaQQkLHkO2WOJv7KzmAZaxrgDV1rt3GBgeEBA=; b=tybWnNraZegnxYOoTRwmsQ1OoCYI5VrBRtbEfUn7hS7fseMivJYi1FleKkVoXe15B7 WH3eJvhOLdBwunqyLq4UesW5xfO1zXoqkLlpI6ct56IIIr8aF3imNe65WFy4Ucl7ytX5 2uMOFc8wJLjhGieM3+z1GyYrsYTtWCvSVwzKoWS6b3D+/Iun/Bd0MTGHLBigQ3KYjOn+ GJ2Aogy8vZlw0jU06mEmPQxL9WMRYJFzPwFoATxZx5fHzDV3D1WLLadhxjOKdK+nUlQK +kjFdcTImCPzJ1+SAiKB91YcXyFg6NibzwA7ycGXXQC6zCJ8xRnO+r1lJQDhVuO2+YSu JTJA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j71-20020a638b4a000000b004e931d7643asi15336396pge.707.2023.02.20.05.56.55; Mon, 20 Feb 2023 05:57:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232604AbjBTN4t (ORCPT + 99 others); Mon, 20 Feb 2023 08:56:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232600AbjBTN4r (ORCPT ); Mon, 20 Feb 2023 08:56:47 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E58A51EBE8 for ; Mon, 20 Feb 2023 05:56:21 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pU6eG-0006k3-QX; Mon, 20 Feb 2023 14:56:08 +0100 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pU6eD-006HMG-Rk; Mon, 20 Feb 2023 14:56:07 +0100 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pU6eE-004laK-6u; Mon, 20 Feb 2023 14:56:06 +0100 From: Oleksij Rempel To: Andrew Lunn , Heiner Kallweit , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Oleksij Rempel , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Russell King Subject: [PATCH net-next v1 4/4] net: phy: c45: genphy_c45_ethtool_set_eee: validate EEE link modes Date: Mon, 20 Feb 2023 14:56:05 +0100 Message-Id: <20230220135605.1136137-5-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230220135605.1136137-1-o.rempel@pengutronix.de> References: <20230220135605.1136137-1-o.rempel@pengutronix.de> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758358593990615228?= X-GMAIL-MSGID: =?utf-8?q?1758358593990615228?= Currently, it is possible to let some PHYs to advertise not supported EEE link modes. So, validate them before overwriting existing configuration. Signed-off-by: Oleksij Rempel --- drivers/net/phy/phy-c45.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/phy-c45.c b/drivers/net/phy/phy-c45.c index 974d6e96fc71..34efade0e2c3 100644 --- a/drivers/net/phy/phy-c45.c +++ b/drivers/net/phy/phy-c45.c @@ -1439,8 +1439,18 @@ int genphy_c45_ethtool_set_eee(struct phy_device *phydev, if (data->eee_enabled) { phydev->eee_enabled = true; - if (data->advertised) + if (data->advertised) { + __ETHTOOL_DECLARE_LINK_MODE_MASK(adv) = {}; + + adv[0] = data->advertised; + linkmode_andnot(adv, adv, phydev->supported_eee); + if (!linkmode_empty(adv)) { + phydev_warn(phydev, "At least some EEE link modes are not supported.\n"); + return -EINVAL; + } + phydev->advertising_eee[0] = data->advertised; + } } else { phydev->eee_enabled = false; }