From patchwork Mon Feb 20 12:41:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frederic Weisbecker X-Patchwork-Id: 59430 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1286497wrn; Mon, 20 Feb 2023 04:46:59 -0800 (PST) X-Google-Smtp-Source: AK7set+shyrmbkYwPsiKH6YLXSWe8e5KSh9j3PHsHGl0N6NHPM1rUCcT15qQtlN50v8MP5vcEGNK X-Received: by 2002:aa7:8ecc:0:b0:5a9:b910:6d98 with SMTP id b12-20020aa78ecc000000b005a9b9106d98mr2115728pfr.13.1676897218978; Mon, 20 Feb 2023 04:46:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676897218; cv=none; d=google.com; s=arc-20160816; b=kd+IfLR0QpjYrY4ezgRsWbVuzdvDD+yEVIfBJvzYF/Sb3DSmwH8yVzv63eJhifXxFf b2jFdmsb52//6EZUBT2uYgExKDMU2V/KeEkdtPc/CfvbaWqdsFQYnqFHymv9hANSyzci LEWtDlzeZ47Nk4iN9jkhzq5MBOp+yO7GqsYk/xmQJMeSN8Q4t22uuWYVAarO9f8jN/sA jfAQrdRH9a2sAcfIg0ZsJQnTBuNxKTwfZU/1Jau7J9alwRLHlVJbAdXJn/z5MHmoqAYa t9FMGV9+tABCDuhw+nnBN4jdFhsfWwBv+F88VvnQKpTVfK9Grw8qrl4/ShGjIZo5fbaY qdbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=hFbVBQX5traxN3KDS5Y0JH03AX0vM76qT+/IKvGQRtA=; b=0Dj8g6B01fVsQhRMTZ8yn4MhzI86yy1qwQ023jyyrHbPgBFqO/x1k873z1kZQl2e+p XtI9PPCzJpzcFC3K4YIWk5U3D2RhbZtOf7eOT1KzJ36GwOlXQwFKHAW1j7/eAdtqLsy/ onB0NE7GtTykluitrrMrz3oOrIRDJnN/34JNCe4nGMN3SXAyrGphW4ioYUwlt5AXNmbC PKUxTH2cY6FjWKimH/ka9dZ4SqIEn3bP2BYSCi7qCMXfwoepTnRl+HnoxuQfkc2rbpJU JQwuqYeqR7xh+nnSouiPGNnK5YvkIiOTtf/gYxqyM81cYJjo8Nw8A+YaHNWk+etRvpd5 +yXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=a5srEQPi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 67-20020a621446000000b005a90fe6a3afsi13715891pfu.228.2023.02.20.04.46.45; Mon, 20 Feb 2023 04:46:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=a5srEQPi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232130AbjBTMmB (ORCPT + 99 others); Mon, 20 Feb 2023 07:42:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232126AbjBTMlw (ORCPT ); Mon, 20 Feb 2023 07:41:52 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F54F1C7D9 for ; Mon, 20 Feb 2023 04:41:51 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2FA9560DFE for ; Mon, 20 Feb 2023 12:41:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F66DC433EF; Mon, 20 Feb 2023 12:41:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676896910; bh=/vEaMsqtOE5BkbGfNS7gZR33SAARhK8GonMdLs7ceS0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=a5srEQPiwndG2qYWSkwb6rz1hH5ZVUDeQ2bFUcDI6YBO+xzbD/iIfGszglsuGKp5e MH7Ad4jfdvMpfhuoJavBuWPhogEG7Kz800j04tctQ6gZNCI6dfGJYU/TZ8PWSxkvYf 4nPImLjb7Vd0cZtcctfDUsklZIC5ei4MAj9Jza9gPa9wo6Ur+1vUyoKzANBpVz7RM8 M/8Su6Lw/ro331OCHWm3ehQckWGNT//2EWfYRLxnjHdBKYQrrP0cmoGbJcyYYdivtR cSWmBMlDUiwQYK7K42MOUibMQG2vSYBxP7pAmQcSqR2ER/thhC8yWCDZKSuMnOTJ0S 2TZS50Vr4z6LQ== From: Frederic Weisbecker To: Thomas Gleixner Cc: LKML , Frederic Weisbecker , Alexey Dobriyan , Peter Zijlstra , Wei Li , Mirsad Goran Todorovac , Yu Liao , Hillf Danton , Ingo Molnar Subject: [PATCH 5/7] timers/nohz: Remove middle-function __tick_nohz_idle_stop_tick() Date: Mon, 20 Feb 2023 13:41:27 +0100 Message-Id: <20230220124129.519477-6-frederic@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230220124129.519477-1-frederic@kernel.org> References: <20230220124129.519477-1-frederic@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758354177850072513?= X-GMAIL-MSGID: =?utf-8?q?1758354177850072513?= There is no need for the __tick_nohz_idle_stop_tick() function between tick_nohz_idle_stop_tick() and its implementation. Remove that unnecessary step. Acked-by: Peter Zijlstra (Intel) Cc: Hillf Danton Cc: Yu Liao Cc: Ingo Molnar Cc: Thomas Gleixner Cc: Wei Li Cc: Alexey Dobriyan Cc: Mirsad Goran Todorovac Signed-off-by: Frederic Weisbecker --- kernel/time/tick-sched.c | 20 ++++++++------------ 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c index edd6e9f26d16..3b53b894ca98 100644 --- a/kernel/time/tick-sched.c +++ b/kernel/time/tick-sched.c @@ -1079,10 +1079,16 @@ static bool can_stop_idle_tick(int cpu, struct tick_sched *ts) return true; } -static void __tick_nohz_idle_stop_tick(struct tick_sched *ts) +/** + * tick_nohz_idle_stop_tick - stop the idle tick from the idle task + * + * When the next event is more than a tick into the future, stop the idle tick + */ +void tick_nohz_idle_stop_tick(void) { + struct tick_sched *ts = this_cpu_ptr(&tick_cpu_sched); + int cpu = smp_processor_id(); ktime_t expires; - int cpu = smp_processor_id(); /* * If tick_nohz_get_sleep_length() ran tick_nohz_next_event(), the @@ -1114,16 +1120,6 @@ static void __tick_nohz_idle_stop_tick(struct tick_sched *ts) } } -/** - * tick_nohz_idle_stop_tick - stop the idle tick from the idle task - * - * When the next event is more than a tick into the future, stop the idle tick - */ -void tick_nohz_idle_stop_tick(void) -{ - __tick_nohz_idle_stop_tick(this_cpu_ptr(&tick_cpu_sched)); -} - void tick_nohz_idle_retain_tick(void) { tick_nohz_retain_tick(this_cpu_ptr(&tick_cpu_sched));