From patchwork Mon Feb 20 12:23:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Oltean X-Patchwork-Id: 59408 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1276590wrn; Mon, 20 Feb 2023 04:24:55 -0800 (PST) X-Google-Smtp-Source: AK7set+FRR5nuBWkuN9pM5pUxQ/vUOUUs53qn/r6dO3g/0Zfy13+r4znDncynYV2wsnvLwEvGl2T X-Received: by 2002:a17:90b:3e86:b0:234:28ac:ec57 with SMTP id rj6-20020a17090b3e8600b0023428acec57mr2794853pjb.21.1676895895328; Mon, 20 Feb 2023 04:24:55 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1676895895; cv=pass; d=google.com; s=arc-20160816; b=vmXrqtmF88syVNomWM6IWoEZGZ9Vx4L6exl9B9Zh3jmGn6DvykgH3cYskltn3K/m3t haLnDUp8HswsMVfI685uAx1R9/RLxyPLcwIVxrBnqrQst2o/KqMOkyWA9ifk7iJ39Ipj yVDM6fHhMGoqgtHnXhHeEuLNA/AQONK32zB/Aw22dnwlzSH6PeOF8zEaQ+0J/q0APUBw zDStV4iqZHM0Nr7gWgkAuMeTzojEniBwuJHCVg/mfc0fXF+1SrXlIQI1xuYx3tQ49ozw dVBx/uU6GAg2wsKFQuqgDupOQ4qZG1goDy27CriuyO1XTQLd/THV21DsKiFPybZJqahu KRcA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=HrOGSjADdNGnCxvTN6zOO/6ulh5BCUN1mw5+cZI5gn8=; b=MzVDiKTj2hTJbrfg1MqhEHAX5EJhN0BdRW16iBBMBVgTXMuR4BaxiQVNJEG9z83laX Vs96wzDj22Vg4FtwfmALCLoupT4pxO+A+01Spo7P8pd36oyG3EN7G0DDw8Swm6SCn1Ej lpmKG8MkNWCZ4wdvG+4vjU7CUBWXgdk7wJR7wehgg+JzNj6FoRHVuSMR+tH5gjRgo46b dV5aoeYntQrFY91FEBy7KVlKQPUObxtr/QoIzKmkekfYwvUefWLWHH4f+AdPEU5jDWw+ nSWKdNfosfhLbTCH181m5ZUs6GVh2QEm3U8rzvZ8+r4wF90XNmGp0memph5oBPAIK2PG NE7A== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=LeePMcEU; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f17-20020a17090ac29100b0022bb6a9677csi15172616pjt.35.2023.02.20.04.24.41; Mon, 20 Feb 2023 04:24:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=LeePMcEU; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232019AbjBTMYF (ORCPT + 99 others); Mon, 20 Feb 2023 07:24:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231983AbjBTMYB (ORCPT ); Mon, 20 Feb 2023 07:24:01 -0500 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2056.outbound.protection.outlook.com [40.107.105.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ECD321814E; Mon, 20 Feb 2023 04:23:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oVB/lkz7kyFuib5CxBPmjFB+I7IrPeduiJqyLi80F3aCaSiR17IErG4TieCE4ftvmnuWnszjhjc0CchXGl5nt+/BEIQLOVBx2E6i/Iu0LgzZjsep+oH+H5dmanioT2UosMvOQ94JOHi50Wy7SZ+aGI2Vghr1oUbF/cLHBauAbs6V5MA2vEikYrqaCLRfQZBUpVGc1p/d4KW5NCI634thqvIBr63lU4j8nQmQQigkjejEZ2uXwrfoag/yir++cvp0+eB1eOFvDhyoUy2wro0CwWqLuyeFlaEZgPtlGr725D3pvviRkwVXWmCjbT3PM728FKp0PDsHxUi+51ZbIG1MJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HrOGSjADdNGnCxvTN6zOO/6ulh5BCUN1mw5+cZI5gn8=; b=k8B8CBYz5t0ZkUdcKKByTIdBEnoTGFvOMgryLt9gq2rVrt+WgpRIWYslhNapGrFfECb7brKIAeFRN3nfE0GT9Lvv+RC3pebUlKgFlgN4bp9dDha6onZI0FfxzdCuAJX1g8aCprsXbrKSVXBNit3+L2ZWHXmEzuXDrbVwvUXuQL/2swcJBHNalmRl+3RwE7Tqd8Tzp5KPDNw6hHGczs/CZ9vyoUsdq8OMN9s0ZpKeZQrAn+1E5fgWr7/ORVda3947vvj1YHu7bJVMIDiWr3pv+V6yirCIO1hzHnUK2+3HzK1q3xGqO/icFF1aRvJFPOml0bmILE9LJ6QERX3VkV9Q3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HrOGSjADdNGnCxvTN6zOO/6ulh5BCUN1mw5+cZI5gn8=; b=LeePMcEUy9v7mfqkxoGUJEhEWPj0XH3uGdq5QNOA6bgWeB5HMuJEZCyvts/FULFdAtxSyoIX2CT6fpYlBdUM03v35dX4GPXkBN/xiEvzan4mJZC0p4e3fla4LWyr8ePXPGLrYK7dnG52RPnfjjwXD8/eBecJWSH3wkl9j923c10= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) by PA4PR04MB7725.eurprd04.prod.outlook.com (2603:10a6:102:f1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.19; Mon, 20 Feb 2023 12:23:58 +0000 Received: from VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::3cfb:3ae7:1686:a68b]) by VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::3cfb:3ae7:1686:a68b%7]) with mapi id 15.20.6111.019; Mon, 20 Feb 2023 12:23:58 +0000 From: Vladimir Oltean To: netdev@vger.kernel.org Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jamal Hadi Salim , Cong Wang , Jiri Pirko , Vinicius Costa Gomes , Kurt Kanzenbach , Gerhard Engleder , Amritha Nambiar , Claudiu Manoil , Alexandre Belloni , UNGLinuxDriver@microchip.com, Andrew Lunn , Florian Fainelli , Ferenc Fejes , Xiaoliang Yang , Roger Quadros , Pranavi Somisetty , Harini Katakam , Giuseppe Cavallaro , Alexandre Torgue , Michael Sit Wei Hong , Mohammad Athari Bin Ismail , Jacob Keller , linux-kernel@vger.kernel.org, Ferenc Fejes Subject: [PATCH v3 net-next 01/13] net: ethtool: fix __ethtool_dev_mm_supported() implementation Date: Mon, 20 Feb 2023 14:23:31 +0200 Message-Id: <20230220122343.1156614-2-vladimir.oltean@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230220122343.1156614-1-vladimir.oltean@nxp.com> References: <20230220122343.1156614-1-vladimir.oltean@nxp.com> X-ClientProxiedBy: BE1P281CA0183.DEUP281.PROD.OUTLOOK.COM (2603:10a6:b10:8d::17) To VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI1PR04MB5136:EE_|PA4PR04MB7725:EE_ X-MS-Office365-Filtering-Correlation-Id: 53a6edba-8f10-46d0-701e-08db133d571d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ryd/cK3upBN7ykMEltpHUvYF9wvBlUD55QAmdlDHi0pIYn0bGgEIHCkSdMeBEZmiAQ++hZ5Je1qtF41Uz0a0uAe4qgGJeukeOTo2BETMykqgGQ6iMRXVTMczO67hSuqt89NOqENpNdSgkZ7UYIq+4xUhX8WbFf2cPViYbopSThSBWhn63BLl8mulyzlmK8fKfmI1GlCJ/gxON/ngPRwiwmzRjF9L6Ke1+spEB7/dqxoW7ax+yIUu/aKuXR73ZJfLj+6B5jqneTSGj6szt/eaP5s2sv8plOt6678Dx7cVFZivmwaD6gACBhpFK1TFhRQJ2otdJi9uPpA91mo6I9O0kz3bpd5wim/mXtfkMT+CPuxJo1btAhUPeVwnflvJlRqbJE4qu0/scKrSBAl1EgGkm9cXHAgA6Qmgxph4jcG2Kw0b5ZrLPb/bOEEVhILkDtJ05vS1XyvGVv3BQ+1zq96KN528nX6F0T41py5k1jU8GTf/zhTUPUdd4/cUCg8MyGQDnn1y8GdPRj1sftoVZ+daALcUoDoLOuaRF3605oe0V2oM3lCvnW7PgcG8akEjn2pMEa8izGamtK10Pq9jsLqjSy8sHpcOqzhB30jPIPkvG8bQ4o6DlrMX5D5mAvVHV3qkWCVvzMBhtbgScgkJ+wRd3IA4taFdOxXppmigWz3gxHqsBLPWVv3emyKW0ME0F7hHM5MZRe0GV3JNcPlRjrM0Yg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5136.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(366004)(346002)(39860400002)(136003)(376002)(396003)(451199018)(8676002)(6916009)(4326008)(66556008)(316002)(6486002)(66476007)(54906003)(66946007)(7416002)(966005)(52116002)(8936002)(5660300002)(41300700001)(86362001)(36756003)(478600001)(38100700002)(1076003)(38350700002)(6506007)(26005)(186003)(6512007)(6666004)(2616005)(4744005)(2906002)(44832011)(83380400001)(309714004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: wJNyBMhjZREkWqtX+qUQOR1LriCGaY8ZEZi0J/KwRMVEAhTr0gRBm4MXDfP3j4ZyD3nSLPNV6P3ktYmSY4KYHklJZ3EeJ7+/7irg9AnWBzxw6YrwUUxwMmIvgwlmo+/R4UydIERuFBswI2fIRbXjIbB4OnmUUfitMEAYMbuSHnyfdOX8jnWVSMKyL4Ru8RY3e+i94VRKdNopMQ826Vg6f349YWz/TYhOrYfK7bvDD8yQpPFqofvx2lmduQqePFkvMT5ceElu9UBvjYh13SXLLlInATFaG2ptDySLarzhIQroehDXeT/YHHInOG71U9+3ScKbC7fezmsUVDhUSpUgFFOMg0rF4BkhLgb4X48SohidbVnmAJVWh8vXWc9F+4AUSWnyseWt108hf1vQscwNZVzNmWPtSYxAss7bEYLg58BMAkdbKSDbka+0+K1AOIJKoX/In06dzeqVJBT7o2hi+Q3vtfj8WvTdzEPByJCEmswkKiFZvGd7GMjkdW8PjAkIkqflWiPHpsMLmUugdNXcDAAM1tvR5pzeTxdwnOt5CRhb69TqG6iWgfezx4HPdcSqei4oQesfJHbnsCa3CBo1MBapfApChn81MUi2Gu6pelRLMI7xDsloOvKTLagubCLzFwXzgwBaauGpjAa3JjuAJ9OsDrJLTFBTKOsfq6BO2Ih/whSv8z6a2w3ajkpLapbvMcNGk0hKa4Ii8VawRc72GzPd/APZGSDg5l1nF34aaZB6LNjU368sQkb0QeqoBVSG/gjYF/toVWINdLr0XNiWh+LARr3hnNXww7AqdOPjEM/1HDEfWF7oJGqhQ5uG16qPCbOBrvNX17TWdnjINvXLkr5SDMgyHYV3B4kz6eg4G0qSgnqK4GWAo7uh+1YTHe1CGyvtxUWGXPfJqwuyu2Q2puPEm4um/OfMMRAkKcbmVxIozLwnWor3thfl3hdKkXqFDEGXeV6q8RaC2xJ0qbYnfEpgr1Eb7y/PR+/YomP2lujnTV07CE9y2RZfW+hM4wC+VXLU/1l8GY08W+AisT1PshLOqSaecLPvppsrVAnBHzwlD08xlGGwXJBnS/ILgsJlxDBi1FkxozoWRzqNabAJoGak/Vvn/BCG7NPH03OHuud+E79g/PAOwPzKyUTmMhozkHkSF455Yr3+dqxGphcEw9D5RsTIGEyDRrbsatNbOYisShEyP2fAn0bXOFEyibA0k9/vMR1bexL2p7aejwTS9d6w9qZHTb3sgRS7wbUeKiljMgkK7ZHQSJXyLoMrXxmn2+GSf2uAVmYDQS1x1bQODE1r8osKTzstVw4ReyIFjMDzRkEPUjmQfRtLpI7BiRUG6+VsQXQh33L+recfwnPFF7rVPbEskxKIr9SXshFAYE3IeYAVnLne4jupOCr7R4nN/CLSa4Sn+Egm3sDzwoe6D/mdL4iJgplBuToyojpzj0njL03WerSKrocDKfdXpHD1JPSR+xVbBaQP0G5XKgisBffidiUj/JKVgM0G1M+i8HUZy7QEz7eqmRsN+e/CZkW29iKiIZFXdMhrl3OHCSeiK/YsbMa9Q3uOjyAqgm25YFT1tYVPUHqAacol0SPFKqsfO03g5fKP2lUSnW7vqOnJhw== X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 53a6edba-8f10-46d0-701e-08db133d571d X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2023 12:23:58.2286 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GuetE4Y7WrY9/KFB6CZaT8IlOlhy+JC1vxoOKwzKqQryvIIKkKofn8AFgWYPSkSJnffbUFDXLKKBoAzuzFG2TQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7725 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758352790260786155?= X-GMAIL-MSGID: =?utf-8?q?1758352790260786155?= The MAC Merge layer is supported when ops->get_mm() returns 0. The implementation was changed during review, and in this process, a bug was introduced. Link: https://lore.kernel.org/netdev/20230111161706.1465242-5-vladimir.oltean@nxp.com/ Fixes: 04692c9020b7 ("net: ethtool: netlink: retrieve stats from multiple sources (eMAC, pMAC)") Signed-off-by: Vladimir Oltean Reviewed-by: Ferenc Fejes --- v2->v3: change link from patchwork to lore v1->v2: none net/ethtool/mm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ethtool/mm.c b/net/ethtool/mm.c index e612856eed8c..fce3cc2734f9 100644 --- a/net/ethtool/mm.c +++ b/net/ethtool/mm.c @@ -247,5 +247,5 @@ bool __ethtool_dev_mm_supported(struct net_device *dev) if (ops && ops->get_mm) ret = ops->get_mm(dev, &state); - return !!ret; + return !ret; }