diff mbox series

[v2,net-next,04/12] net: ethtool: fix __ethtool_dev_mm_supported() implementation

Message ID 20230219135309.594188-5-vladimir.oltean@nxp.com
State New
Headers
Series Add tc-mqprio and tc-taprio support for preemptible traffic classes |

Commit Message

Vladimir Oltean Feb. 19, 2023, 1:53 p.m. UTC 
  The MAC Merge layer is supported when ops->get_mm() returns 0.
The implementation was changed during review, and in this process, a bug
was introduced.

Link: https://patchwork.kernel.org/project/netdevbpf/patch/20230111161706.1465242-5-vladimir.oltean@nxp.com/
Fixes: 04692c9020b7 ("net: ethtool: netlink: retrieve stats from multiple sources (eMAC, pMAC)")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
v1->v2: none

 net/ethtool/mm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kurt Kanzenbach Feb. 20, 2023, 11:50 a.m. UTC | #1 
On Sun Feb 19 2023, Vladimir Oltean wrote:
> The MAC Merge layer is supported when ops->get_mm() returns 0.
> The implementation was changed during review, and in this process, a bug
> was introduced.
>
> Link: https://patchwork.kernel.org/project/netdevbpf/patch/20230111161706.1465242-5-vladimir.oltean@nxp.com/

Nit:

Link: https://lore.kernel.org/r/20230111161706.1465242-5-vladimir.oltean@nxp.com/

is preferred, because it is supposed to be stable. Same for patch #8.

Thanks,
Kurt
Vladimir Oltean Feb. 20, 2023, 11:55 a.m. UTC | #2 
On Mon, Feb 20, 2023 at 12:50:35PM +0100, Kurt Kanzenbach wrote:
> On Sun Feb 19 2023, Vladimir Oltean wrote:
> > The MAC Merge layer is supported when ops->get_mm() returns 0.
> > The implementation was changed during review, and in this process, a bug
> > was introduced.
> >
> > Link: https://patchwork.kernel.org/project/netdevbpf/patch/20230111161706.1465242-5-vladimir.oltean@nxp.com/
> 
> Nit:
> 
> Link: https://lore.kernel.org/r/20230111161706.1465242-5-vladimir.oltean@nxp.com/
> 
> is preferred, because it is supposed to be stable. Same for patch #8.
> 
> Thanks,
> Kurt

Thanks for taking a look, I've made the change.
FWIW, your /r/ link redirected me to /all/. I've replaced it with /netdev/.
diff mbox series

Patch

diff --git a/net/ethtool/mm.c b/net/ethtool/mm.c
index e612856eed8c..fce3cc2734f9 100644
--- a/net/ethtool/mm.c
+++ b/net/ethtool/mm.c
@@ -247,5 +247,5 @@  bool __ethtool_dev_mm_supported(struct net_device *dev)
 	if (ops && ops->get_mm)
 		ret = ops->get_mm(dev, &state);
 
-	return !!ret;
+	return !ret;
 }