From patchwork Sun Feb 19 10:42:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kemeng Shi X-Patchwork-Id: 59058 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp655981wrn; Sat, 18 Feb 2023 18:41:58 -0800 (PST) X-Google-Smtp-Source: AK7set+v44l4An5rWyJtm/Kc627pt67GPKwDdzHn2oVmBu2x9ULp2HoQ5dtduDz4WoIoMiHS8OcH X-Received: by 2002:a17:902:d2c3:b0:19a:80e6:2a21 with SMTP id n3-20020a170902d2c300b0019a80e62a21mr2201790plc.33.1676774517954; Sat, 18 Feb 2023 18:41:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676774517; cv=none; d=google.com; s=arc-20160816; b=03dZBdAuW6lSk2YYOf0qXatogp1a0zOoQqstlQZoL0lpQOE51Ze89IjT/R5ggTA8X4 WYTo1Gq/n2SxNqH7fHFoxOURQ30TaeWlhiIwH8YDUv80lEurEZSRfRYplKpSKizlQ3+f qJNEzlGGzboFn5D8IzLyQVP0XFMf6pkNkYYBtlw9LpXQNY7d/gAsMBUMLcRJHo/pleQJ NWX+X58w7xZSdwp77obiqgFAFhNxee0DAi/F5RFlW87FozKZDkcyq3JUhsi6s4C/qNoY b/0MZOAR6VH9SO4Pf+gxv/ZVtDpnaNGXY6tGGsVUxGFOmDGMeOo7AS2ABUMaxVv2nl/t dJLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=SbRPtdGBC3Lon7O74OiiwH4QymrrSvGM3JDqyf+54LU=; b=Mf6oPqgaDl6nbQn4y1f3SQvlvxhNf4plE57maM8njT5zvVdiXVhson8yjpS2zAQzmn C5DuyLjwlPIrDp0nIbqGNh7L89FLLOO7pBDW6VMU5xad7NCoWlM0orFRqob7HHX1XlWT pQiHwqdY3kgAYJ90E77z5Z4Bq5qFZG2wJ/263oZqubDgtEkez7fVzwTUKOLfwSAGKW2M /4C6NJ5XVbVmRz+2CXBhA1Vv3zrfK6AfD1WcuqrSt+TG0b9UpU9Wke/VllFeOSQ8mY8Y ljz5uRowysYOTSs7RiA7XHYIqjuwUx1X2lyBdNgSy53nvNS/Vpsj+2vZ0lERFLJJwC6m Y7AA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q16-20020a170902dad000b0019acbf1dc4asi5467078plx.181.2023.02.18.18.41.38; Sat, 18 Feb 2023 18:41:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229623AbjBSCl3 (ORCPT + 99 others); Sat, 18 Feb 2023 21:41:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229580AbjBSCl2 (ORCPT ); Sat, 18 Feb 2023 21:41:28 -0500 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E9E011EB8; Sat, 18 Feb 2023 18:41:26 -0800 (PST) Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4PK8v50zc2z4f3pBt; Sun, 19 Feb 2023 10:41:21 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP2 (Coremail) with SMTP id Syh0CgBH7utQjPFjPmleDw--.7604S5; Sun, 19 Feb 2023 10:41:23 +0800 (CST) From: Kemeng Shi To: paolo.valente@linaro.org, axboe@kernel.dk, jack@suse.cz Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, shikemeng@huaweicloud.com Subject: [PATCH 03/17] block, bfq: only preempt plugged in_service_queue if bfq_better_to_idle say no Date: Sun, 19 Feb 2023 18:42:55 +0800 Message-Id: <20230219104309.1511562-4-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20230219104309.1511562-1-shikemeng@huaweicloud.com> References: <20230219104309.1511562-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 X-CM-TRANSID: Syh0CgBH7utQjPFjPmleDw--.7604S5 X-Coremail-Antispam: 1UD129KBjvJXoW7WrW3Gr15GFy7ZFWfuw4rXwb_yoW8WrWfpF WqkryfXw1xta15Zry7X3yUJFy3uF93G3saqr4xZF4Yq34xAr97C3ZIy34Yqr48Wrs7Aw43 XFyrC3sIgw1UAw7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUPSb4IE77IF4wAFF20E14v26rWj6s0DM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M280x2IEY4vEnII2IxkI6r1a6r45M2 8IrcIa0xkI8VA2jI8067AKxVWUWwA2048vs2IY020Ec7CjxVAFwI0_Gr0_Xr1l8cAvFVAK 0II2c7xJM28CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW7JVWDJwA2z4 x0Y4vE2Ix0cI8IcVCY1x0267AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l 84ACjcxK6I8E87Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I 8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AK xVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zV CS5cI20VAGYxC7MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E 5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAV WUtwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY 1x0267AKxVW8JVWxJwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI 0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7s RNiiSUUUUUU== X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_00,DATE_IN_FUTURE_06_12, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758225517246249299?= X-GMAIL-MSGID: =?utf-8?q?1758225517246249299?= Why we preempt in_service_queue when bfq_better_to_idle say no is (from comment above the preemption expiration): As for throughput, we ask bfq_better_to_idle() whether we still need to plug I/O dispatching. If bfq_better_to_idle() says no, then plugging is not needed any longer, either to boost throughput or to perserve service guarantees. Then the best option is to stop plugging I/O, as not doing so would certainly lower throughput. This preemption only makes sense that IO of in_service_queue is currently plugged and then there is a need to stop plugging. Make sure bfqq is plugged before bfq_better_to_idle check to improve this. Signed-off-by: Kemeng Shi --- block/bfq-iosched.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index 4868538c9745..7b416f9471b3 100644 --- a/block/bfq-iosched.c +++ b/block/bfq-iosched.c @@ -1978,8 +1978,9 @@ static void bfq_bfqq_handle_idle_busy_switch(struct bfq_data *bfqd, if (bfqd->in_service_queue && ((bfqq_wants_to_preempt && bfqq->wr_coeff >= bfqd->in_service_queue->wr_coeff) || - bfq_bfqq_higher_class_or_weight(bfqq, bfqd->in_service_queue) || - !bfq_better_to_idle(bfqd->in_service_queue)) && + bfq_bfqq_higher_class_or_weight(bfqq, bfqd->in_service_queue) || + (bfq_bfqq_wait_request(bfqq) && + !bfq_better_to_idle(bfqd->in_service_queue))) && next_queue_may_preempt(bfqd)) bfq_bfqq_expire(bfqd, bfqd->in_service_queue, false, BFQQE_PREEMPTED);