From patchwork Sun Feb 19 08:44:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxim Korotkov X-Patchwork-Id: 59089 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp760220wrn; Sun, 19 Feb 2023 00:54:25 -0800 (PST) X-Google-Smtp-Source: AK7set8SsFSR2F2zJy31EeZfRk/+xg4ZPrJdE3zj760ph9wBDF7TjfjDI1BIH8kvRNowpoUUTEVn X-Received: by 2002:a17:907:9727:b0:8af:4257:93f7 with SMTP id jg39-20020a170907972700b008af425793f7mr14490731ejc.2.1676796865679; Sun, 19 Feb 2023 00:54:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676796865; cv=none; d=google.com; s=arc-20160816; b=bsPWde2b8EDjI2DEOdpejm8y3ya68S6FCsaFdmxfGWXvLjI3P4JHx8ib2t2Gb5L7au +OYqBGiKnxwoQ14PmNA7/NCoo46BTtCQ9+xPci74ZeyqErp62ij9x47+2belS0CPcUqA +pvZ5z4WMTDBg5v0OOgOc13+MAvBk0N0k12WJlM9FN2y+iUhoA2n7N7SgfLsBcUl/gQe Mm73Cnz8l+aNgflQhhxL7/CfpxXc9Hs4KT/d5ZDzHoOGBE0C2lX0mVAgFRGAxmXdg7BG b2ci6uaOPWvnEw32s2kR/399RcZz+OJBiGjXgCY8wfYzdUKcvokgHGtZ3NNEjfMatDjn 4uQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=y++BPIZOSO2h3LSMZrkgSiXiIFf+8mVPfmFtUJMsjaU=; b=I6Pi1tfMkUDC5lojq7Mc0LQfOqh9dR8xu5r8z7IGAgG8pTV2dKZkcB5wW2pppwDCA6 26vYdo8m765Vr6JrgBZ7GyFaslIRoHwdunytAJLrwwXh298AM5M6N06mMtJiXOVRzREe LcHcpgGOG15f1VuiH7JZJjLDPmZ3dkE/uGbjTbA1yrNCEicUrYAsv0JSANvNgq2U8CZy 6q2B+sAYaMW8UYXHODH/lfWiv1q3Lw0ujs2kt3TwnWJCwjrWByc74LW76y6yWf3jjd4w MAIJFsfVIwrwd4nK+hfEvwqZAhIajbyOI9oG5SiIODdvJcZfs4bWJNjojpWfqWagv27i /KLg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=lr5guBjE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 26-20020a17090601da00b008af3dea1b19si12753357ejj.751.2023.02.19.00.53.59; Sun, 19 Feb 2023 00:54:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=lr5guBjE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229622AbjBSIpe (ORCPT + 99 others); Sun, 19 Feb 2023 03:45:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229478AbjBSIpc (ORCPT ); Sun, 19 Feb 2023 03:45:32 -0500 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95F3EF762; Sun, 19 Feb 2023 00:45:30 -0800 (PST) Received: by mail-lf1-x136.google.com with SMTP id x27so497828lfu.4; Sun, 19 Feb 2023 00:45:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=y++BPIZOSO2h3LSMZrkgSiXiIFf+8mVPfmFtUJMsjaU=; b=lr5guBjEVuwBaCkvz8qX/+Fk52e6WMvjvXxB6BzWCZroOXuiUMybDyH9plmjhXxDFd IMew2SHKOYwLahL9/PYHKslfMO9XEzGqXzI/q9AyFjSxEFqyy3+zpfq8ydS6+Xo3BtG5 mQpFAUDGIyNyt5Ko2pjRuChOALMlhBAk21CexOEFowH0S6sFJb4qGi5Fjo3Ib9nLEkYB W5OSf4epESkKLs/ef0u4cHOnBS93nsNz5/4rnSvdVri/6cC0yQHQfDnKtA3KLfho1SnB mK9FWAttc4cfQkSyvo6FxPU/vkrvAfpfflYKsuFTqKmM9PL0K+p+1g+5DilgsncyyvZt 5j5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=y++BPIZOSO2h3LSMZrkgSiXiIFf+8mVPfmFtUJMsjaU=; b=HxEDUGxmwKpDmwgbqOmdzNT4fHYOR5Jg/59lDkzcZ0rKZ1eDACCRbJd9ffcAYZ4nld 91dBiP/qxeuPp/U0lPT0l9XkYyxmUldLHlVykXjCRFTqrWQ7uLMn4fdKAu3kz89edWeJ 0SapyGty8NTiX5B9WD+w7RhUWbf6CFGxHu0oGR3Uma00pOyE0ZmjjjJk9yv5+YsESw7F To/MTjGdBZSeaM1UW0JpxpZGF0wkFTu1Bx0VmMcCeyZJZgFOLmzARWrpR3kxYS7oJPIr 2VFF/iAI45Kk8cFEJ1ABomirwjRemTw1xLlMN+iPzUKAEK1cZA6tv9c2hv6jpu3KHkKt StkA== X-Gm-Message-State: AO0yUKWwaJdVkORATT7ylZJEzO4LF42HnzxgLaSRNMBdeXYRF9pqioXR 42n9J12i794wKjQ4Sp227ww= X-Received: by 2002:a05:6512:3a90:b0:4cd:7fe0:24 with SMTP id q16-20020a0565123a9000b004cd7fe00024mr201606lfu.27.1676796328745; Sun, 19 Feb 2023 00:45:28 -0800 (PST) Received: from mkor.. (89-109-49-189.dynamic.mts-nn.ru. [89.109.49.189]) by smtp.gmail.com with ESMTPSA id y15-20020ac255af000000b004db511ccae6sm1196442lfg.294.2023.02.19.00.45.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Feb 2023 00:45:28 -0800 (PST) From: Maxim Korotkov To: Michael Chan Cc: Maxim Korotkov , Pavan Chebbi , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: Date: Sun, 19 Feb 2023 11:44:23 +0300 Message-Id: <20230219084423.17670-1-korotkov.maxim.s@gmail.com> X-Mailer: git-send-email 2.37.2 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758248950325922411?= X-GMAIL-MSGID: =?utf-8?q?1758248950325922411?= Date: Sat, 18 Feb 2023 11:46:20 +0300 Subject: [PATCH v2] bnxt: avoid overflow in bnxt_get_nvram_directory() The value of an arithmetic expression is subject of possible overflow due to a failure to cast operands to a larger data type before performing arithmetic. Used macro for multiplication instead operator for avoiding overflow. Found by Security Code and Linux Verification Center (linuxtesting.org) with SVACE. Fixes: c0c050c58d84 ("bnxt_en: New Broadcom ethernet driver.") Signed-off-by: Maxim Korotkov Reviewed-by: Pavan Chebbi --- changelog: - added "fixes" tag. drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c index ec573127b707..696f32dfe41f 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c @@ -2862,7 +2862,7 @@ static int bnxt_get_nvram_directory(struct net_device *dev, u32 len, u8 *data) if (rc) return rc; - buflen = dir_entries * entry_length; + buflen = mul_u32_u32(dir_entries, entry_length); buf = hwrm_req_dma_slice(bp, req, buflen, &dma_handle); if (!buf) { hwrm_req_drop(bp, req);