From patchwork Sat Feb 18 22:01:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ondrej Zary X-Patchwork-Id: 59043 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp569815wrn; Sat, 18 Feb 2023 14:04:40 -0800 (PST) X-Google-Smtp-Source: AK7set91vo1NFwQsIV0F4N1chIjV9wUkJpYdORz3lPPzsOnihj0BAzxSrMxcU3EGm1O9P5D/tX4f X-Received: by 2002:a05:6a20:aaa9:b0:c7:7c12:638c with SMTP id ck41-20020a056a20aaa900b000c77c12638cmr5317819pzb.51.1676757880614; Sat, 18 Feb 2023 14:04:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676757880; cv=none; d=google.com; s=arc-20160816; b=Cz2raGb7/wnZJ7GlqecAD8uC8bA1JO23BFtez1qOHu3+dHZ4krayI+vRY8tRqcxPa4 xliZpVU3hpzaMjrdJ2nE0ZeZBr5g2JN67PALQ1ThlcktkbwGMfXnHes6YBUjyqY17nJv yIYjB/qsj0gvAwMrjOVtIBYm6OhMFfSOQ/jTQ006vVDC4D+oIW164Ln89O+6Ne8S+8B7 6NVp87+NHKn07M8H+Dq9VNhSJ/f3AGhD5zTg41aTuYrupRA+DHNkLXs5J5W2EZhwFkRv eRUOI67u3j8HQ8u1zT2A6AYUP2U8bk9KI9yhUko7h840i0aGwrMYvc26UzwA3D+UIOD/ Cczw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=sTUgHRfeb6F0bvYvyygEeRfoA5Cu4A+l5GtVp/Nm3s4=; b=H9wdYVjqFOuGtT5a8Uf7sV4W0GS5KJU38CFhv/Ffkgx5uQHy459MXx4J0KcQ3Ug/Hi jNiK2zZ/huUOYqPxHr5lFxVBcpJ7nvEz6hqyoxfdAn8iEAbE5jE/uVN9w5QNgfeGpqZZ 229FRz90XCoURCFeHlSObQzEeCgOFcERh8cwzFq0uvzms+4wk2p0zUhq49K5KLFIjaL7 a0F38yO3rHJ/2pjDlc2P1/oVAidaIArvfNb4ErbjilycNlJ8ngqCVRSzTmqlv52nyMWr 1tvPhyWhWcl0uElr/9w3k7pJNCJTSOgVlWBFQ8UVdrHCBkuPsMPXLGLwaPuuyTL8jrs7 aeEw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d29-20020a631d1d000000b004e48198c1b0si8377282pgd.654.2023.02.18.14.04.28; Sat, 18 Feb 2023 14:04:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229953AbjBRWCr (ORCPT + 99 others); Sat, 18 Feb 2023 17:02:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230105AbjBRWCR (ORCPT ); Sat, 18 Feb 2023 17:02:17 -0500 Received: from hosting.gsystem.sk (hosting.gsystem.sk [212.5.213.30]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1462212877; Sat, 18 Feb 2023 14:02:08 -0800 (PST) Received: from gsql.ggedos.sk (off-20.infotel.telecom.sk [212.5.213.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by hosting.gsystem.sk (Postfix) with ESMTPSA id 844937A0708; Sat, 18 Feb 2023 23:02:03 +0100 (CET) From: Ondrej Zary To: Damien Le Moal Cc: Christoph Hellwig , Sergey Shtylyov , Jens Axboe , Tim Waugh , linux-block@vger.kernel.org, linux-parport@lists.infradead.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 12/18] pata_parport: use print_hex_* Date: Sat, 18 Feb 2023 23:01:32 +0100 Message-Id: <20230218220138.5692-13-linux@zary.sk> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20230218220138.5692-1-linux@zary.sk> References: <20230218220138.5692-1-linux@zary.sk> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758208071555979863?= X-GMAIL-MSGID: =?utf-8?q?1758208071555979863?= Use print_hex_* for debug dumps. Signed-off-by: Ondrej Zary Reviewed-by: Sergey Shtylyov --- drivers/ata/pata_parport/bpck.c | 22 ++++------------------ 1 file changed, 4 insertions(+), 18 deletions(-) diff --git a/drivers/ata/pata_parport/bpck.c b/drivers/ata/pata_parport/bpck.c index 1cba098b4b82..dec24983d140 100644 --- a/drivers/ata/pata_parport/bpck.c +++ b/drivers/ata/pata_parport/bpck.c @@ -334,12 +334,9 @@ static int bpck_test_proto(struct pi_adapter *pi, char *scratch, int verbose) } - if (verbose) { - printk("bpck: 0x%x unit %d mode %d: ", - pi->port, pi->unit, pi->mode); - for (i=0;idev, "bpck: 0x%x unit %d mode %d: ", + pi->port, pi->unit, pi->mode); + print_hex_dump_debug("bpck: ", DUMP_PREFIX_NONE, TEST_LEN, 1, buf, TEST_LEN, false); e = 0; for (i=0;i '~')) - scratch[i] = '.'; - printk("bpck EEPROM: %64.64s\n", scratch); - printk(" %64.64s\n", &scratch[64]); -#endif - + print_hex_dump_bytes("bpck EEPROM: ", DUMP_PREFIX_NONE, scratch, 128); dev_info(&pi->dev, "bpck %s, backpack %8.8s unit %d", BPCK_VERSION, &scratch[110], pi->unit); dev_info(&pi->dev, " at 0x%x, mode %d (%s), delay %d\n", pi->port,