From patchwork Sat Feb 18 20:18:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 58958 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp534341wrn; Sat, 18 Feb 2023 12:21:30 -0800 (PST) X-Google-Smtp-Source: AK7set/VvNeYMyw4On1Y/IyX/p2zZh+J8aOiH6EjAG0srxI6nC078EGaJsb5v7Cl8n/AAsh8RvVq X-Received: by 2002:aa7:9562:0:b0:5a9:d247:bc76 with SMTP id x2-20020aa79562000000b005a9d247bc76mr6276592pfq.20.1676751689857; Sat, 18 Feb 2023 12:21:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676751689; cv=none; d=google.com; s=arc-20160816; b=ejzCabE/j8d/pWoDlKJYCRWwnVTMoyNecIVcNIGi3OMbNGm0pa7aQVxPcc94s0Lb0M tfPnnLQMleSa2j+qCTOXzZw8xhUrWB8msLU2kvKNM3ih2VxYCVCSFpgtxaJGCU6sFMxF VFMgLYgnfQFznwfPbzq5E267npgB4OVpQdhxEO6dBbcfSeE0OFEB9azAoU3gKkrWsxV5 guARtiAubLz9l9doXnSm6VhWFWpt8kQPzyrWAaI0443lc4Mg4cv1J4G/Jbeyz3SB7U/l ZmUB2xBiXJIr+MoELfDG9k/b3YxTozMSG2SJDG3BYXVjJi/BHnNJFz6qPr1+9EfRmh3H siOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:subject:cc:to:from:date :user-agent:message-id; bh=isCznK+huadZYX1GsH3mA0Envp6xuAgi20EoVzv5dSo=; b=iAzaD3QShjCYrYdrOJt3Dz4DxNsJsnXoJVWIhKO7rio+U/VcpZkxGR61mJXGUjbv1e g7J2xOWlWDNJvGyn2Gbqh4YdzFz2Ctjaj3go3a72RDf1GH0vx9p1BUFM4mrbc0Qh6Bpg pQPUjFKSNBAEGL8JJSdCaT65WOI44GDAKpE9Mmto/ok6emASm5P6X/iP44MVv0vaXuS2 x5Epyx7mLojqH2RXl/rB+zPLxWSLd79k83uJiZ2+zp8vTP9wdGfRHTo9/kGfjxAY0j4F 7CkwjypSNRV0j+xmbLOzrC2wdc7qnQ/MQ/V8jN05TjTPxPnAq3KZRhV/mgNABiWV0iFl xXdQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y15-20020a056a00190f00b005a8ec89de5fsi9617081pfi.236.2023.02.18.12.21.17; Sat, 18 Feb 2023 12:21:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229706AbjBRUTq (ORCPT + 99 others); Sat, 18 Feb 2023 15:19:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229632AbjBRUTi (ORCPT ); Sat, 18 Feb 2023 15:19:38 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80F161498F for ; Sat, 18 Feb 2023 12:19:36 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1FF81B80935 for ; Sat, 18 Feb 2023 20:19:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8FE6BC433A4; Sat, 18 Feb 2023 20:19:33 +0000 (UTC) Received: from rostedt by gandalf.local.home with local (Exim 4.96) (envelope-from ) id 1pTTgC-000xso-1E; Sat, 18 Feb 2023 15:19:32 -0500 Message-ID: <20230218201932.196676123@goodmis.org> User-Agent: quilt/0.66 Date: Sat, 18 Feb 2023 15:18:23 -0500 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Andrew Morton , Andreas Ziegler , Daniel Bristot de Oliveira Subject: [for-next][PATCH 2/8] tools/tracing/rtla: osnoise_hist: use total duration for average calculation References: <20230218201821.938318263@goodmis.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758201580325382735?= X-GMAIL-MSGID: =?utf-8?q?1758201580325382735?= From: Andreas Ziegler Sampled durations must be weighted by observed quantity, to arrive at a correct average duration value. Perform calculation of total duration by summing (duration * count). Link: https://lkml.kernel.org/r/20230103103400.275566-2-br015@umbiko.net Fixes: 829a6c0b5698 ("rtla/osnoise: Add the hist mode") Signed-off-by: Andreas Ziegler Acked-by: Daniel Bristot de Oliveira Signed-off-by: Steven Rostedt (Google) --- tools/tracing/rtla/src/osnoise_hist.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/tracing/rtla/src/osnoise_hist.c b/tools/tracing/rtla/src/osnoise_hist.c index 5d7ea479ac89..fe34452fc4ec 100644 --- a/tools/tracing/rtla/src/osnoise_hist.c +++ b/tools/tracing/rtla/src/osnoise_hist.c @@ -121,6 +121,7 @@ static void osnoise_hist_update_multiple(struct osnoise_tool *tool, int cpu, { struct osnoise_hist_params *params = tool->params; struct osnoise_hist_data *data = tool->data; + unsigned long long total_duration; int entries = data->entries; int bucket; int *hist; @@ -131,10 +132,12 @@ static void osnoise_hist_update_multiple(struct osnoise_tool *tool, int cpu, if (data->bucket_size) bucket = duration / data->bucket_size; + total_duration = duration * count; + hist = data->hist[cpu].samples; data->hist[cpu].count += count; update_min(&data->hist[cpu].min_sample, &duration); - update_sum(&data->hist[cpu].sum_sample, &duration); + update_sum(&data->hist[cpu].sum_sample, &total_duration); update_max(&data->hist[cpu].max_sample, &duration); if (bucket < entries)