From patchwork Fri Feb 17 13:15:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Natalia Petrova X-Patchwork-Id: 58554 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp881311wrn; Fri, 17 Feb 2023 05:19:57 -0800 (PST) X-Google-Smtp-Source: AK7set9LOpEadHjXrJRGVgvLSktghCCxGwMZxaiyPN2HyCJ6rDK5JzxNjJyG8tTKanwJ2bPIKJsP X-Received: by 2002:a17:906:8a64:b0:8aa:c2bd:a71c with SMTP id hy4-20020a1709068a6400b008aac2bda71cmr9821660ejc.75.1676639997611; Fri, 17 Feb 2023 05:19:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676639997; cv=none; d=google.com; s=arc-20160816; b=CZo3PfZXCkgQmZxqTj0GM29CxjWI8vOYzXJhx1cT1BgJJz9z0x37/Kh0t2po0yRegG 31RrlG2WZyN9XpUOOe80Fr4ZR9ig30NnBOPBG5SZIvQg5O5+Hr8rFLr/a/oraiM8Fz6J tkzW+9Sx/YYOj0DsI6vJJ6UjUKBryMyLQ57wdM0eRRi/u04a6CbWXZb4dX1KMq/50FhX zTLdd72MSfdu3eXalA4eb5itYuI/HiF8mU4SneBrjXTs5gMsDHCA+i/IWEfcS/OJKYQR JFuS/zzixO/2WmVOgYKqpuBPqjBXAEBUkpwE1ZzmgfOPt8Tidjoge6U9PU7Vmkv4eliF +mzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=tji8gKiur+v0LgKBh/OXEhN9KRdrmJcyn3IlCB9f/mQ=; b=pzQQMUSERkNh5CyAprwwWEz2/85RAUQiR4wwEUQX6BeNxpeBdb9chopylWaiA2nXz2 htXyahsW/tcwF6pCasgGdCE6whmQ/LRvKHBvCAiJLQO2mBFtTa12k/mt8vTmkMpkmYw2 UzwIF5uved153BqDmgyjdbikTkonDT0aPf7eX5VJWvCLlNupQM2G7NK8uAAS1cU8X2Ez dcLiNNOEeo6E7KlQpjvDrDfd0e6SJ7Kll4lNoFVP428QNz1OxVTubEYNOw9d0b6DMtbQ HXUq+7DfFLD3PsQKXyTPrUp/o6Mk66UEkiBwu34v6vDVUUS1BeOsQnLOSfD440OW8T3w b4VQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q13-20020aa7da8d000000b004accb68cc93si5469766eds.387.2023.02.17.05.19.34; Fri, 17 Feb 2023 05:19:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229570AbjBQNPs (ORCPT + 99 others); Fri, 17 Feb 2023 08:15:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229475AbjBQNPq (ORCPT ); Fri, 17 Feb 2023 08:15:46 -0500 Received: from exchange.fintech.ru (e10edge.fintech.ru [195.54.195.159]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0CD3939B86 for ; Fri, 17 Feb 2023 05:15:41 -0800 (PST) Received: from Ex16-01.fintech.ru (10.0.10.18) by exchange.fintech.ru (195.54.195.159) with Microsoft SMTP Server (TLS) id 14.3.498.0; Fri, 17 Feb 2023 16:15:33 +0300 Received: from KANASHIN1.fintech.ru (10.0.253.125) by Ex16-01.fintech.ru (10.0.10.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Fri, 17 Feb 2023 16:15:33 +0300 From: Natalia Petrova To: Cezary Rojewski CC: Natalia Petrova , Pierre-Louis Bossart , Liam Girdwood , Peter Ujfalusi , Bard Liao , Ranjani Sridharan , Kai Vehmanen , Mark Brown , "Jaroslav Kysela" , Takashi Iwai , , , Subject: [PATCH] skl-topology_3627: using sprintf changed to snprintf Date: Fri, 17 Feb 2023 16:15:30 +0300 Message-ID: <20230217131530.486962-1-n.petrova@fintech.ru> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Originating-IP: [10.0.253.125] X-ClientProxiedBy: Ex16-01.fintech.ru (10.0.10.18) To Ex16-01.fintech.ru (10.0.10.18) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758084462416353586?= X-GMAIL-MSGID: =?utf-8?q?1758084462416353586?= Use snprintf instead of sprintf to avoid buffer overflow. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 2d744ecf2b98 ("ASoC: Intel: Skylake: Automatic DMIC format configuration according to information from NHLT") Signed-off-by: Natalia Petrova --- sound/soc/intel/skylake/skl-topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/intel/skylake/skl-topology.c b/sound/soc/intel/skylake/skl-topology.c index e06eac592da1..ac06926e651d 100644 --- a/sound/soc/intel/skylake/skl-topology.c +++ b/sound/soc/intel/skylake/skl-topology.c @@ -3660,7 +3660,7 @@ static int skl_tplg_complete(struct snd_soc_component *component) se = (struct soc_enum *)kcontrol->private_value; texts = dobj->control.dtexts; - sprintf(chan_text, "c%d", mach->mach_params.dmic_num); + snprintf(chan_text, sizeof(chan_text), "c%d", mach->mach_params.dmic_num); for (i = 0; i < se->items; i++) { if (strstr(texts[i], chan_text)) {