From patchwork Fri Feb 17 09:59:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 58473 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp807063wrn; Fri, 17 Feb 2023 02:20:11 -0800 (PST) X-Google-Smtp-Source: AK7set/LCQJhfFv2NFpSNljMcYtdKdTf/xZpe/vzkuo/pbQ9HXYj4PtN3rpri6WAXI19/P3/5sov X-Received: by 2002:a17:907:6297:b0:887:aac3:9340 with SMTP id nd23-20020a170907629700b00887aac39340mr5396181ejc.29.1676629211041; Fri, 17 Feb 2023 02:20:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676629211; cv=none; d=google.com; s=arc-20160816; b=JQdTSkCbUcMFKr49X/MQGKV/2dzNICFAMxTzFia9Gu96CXj1Vlf7efkXki3TvLlqNi gZjwNiSh6AVMp0xiTWe/bEvRf+mOovcEnkt1oPiLZNfJx6MmFe3Z5f3WOHeaFYsThO9Z jFgwXoziZXC43PT2NRg2ioRjfvzK9XVKi/CCc2ezEGE74FWS6nYN+cA3+HZ1j1w1HBG7 9y0hoOPuke0QW/U37cDI79Vtl3hJqNQDrvQTrb1bLQlcQMs9e5E6HAR4wh7epTc4if4f puW1+rZYMRxwVGM7PTJ/EyCNgHPtREjvIFQ9ItTBV/4qOJz2N9laT19C7qCYQZJJqBb6 ZoCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=LhwxsC81XWYJJoC8b9XnJBDlTCEpAstzMou8+hHSbTE=; b=TpklPIgT4iw+R9PM8MdXC7Fz75vd4dnBe0hY9c0Sm8FAJrt9EVN/roKdUh1VaN9xN1 kEBQ4AsFcl+CZSjSfZdu9NH2PFj2/kl4iXVQ4CP0HRgfuze5BPLS5lJwGQTKe+HbBsIh P+B5Gi0o6UhakL7cLbNmDMnJXhA2FiO5bCj7h6jY8kz6i9X2An2o+l5hp4QR56r2QwNo rzGWArHCa2S51Ntf/CUkhVMSIGgFY2jKvkiR+pHPy+EM5Mm6EZtVZextdg7s8o2nEfnl PCszLgsv8gIPX9Poao3Zmewjn4h7Mi2nfSXmaAVy7m5PyoslL8kEVKJ2g+CGb7QZqvzC 0FIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oMNOFSe2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 30-20020a17090600de00b008b1392b4b62si7090730eji.477.2023.02.17.02.19.47; Fri, 17 Feb 2023 02:20:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oMNOFSe2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229803AbjBQJ7f (ORCPT + 99 others); Fri, 17 Feb 2023 04:59:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229706AbjBQJ7Y (ORCPT ); Fri, 17 Feb 2023 04:59:24 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9E6FF766; Fri, 17 Feb 2023 01:59:15 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A928DB82B5C; Fri, 17 Feb 2023 09:59:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B79B0C433D2; Fri, 17 Feb 2023 09:59:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676627953; bh=gC8fzzrUSCg6UTwoBVpBiyclU6InTgw8Xj/2u293vJw=; h=From:To:Cc:Subject:Date:From; b=oMNOFSe2pTsipWtyloa74226iH3ACac154G9g2N0S4dnIrndUg8YuXwQ8v55gIBAQ Yv9eEm5Y9lb7dZVlQ+XKlu75rbTSekfMU0wCdClNrUIvNN3QMLbhtmmJXFyA2J2dw6 xbwdd7lTCleT9URT+tuPGOmLm2bTlhq4gacjdDq2PaJUkFhVLmDlTDw/pB1kwCt3Pi hylju8/CQpr/8ZniEN30W+uHlPue4xHMPYuFhRsdG0K9ycWFdjXHA6HDJMov3LTtXH 2zhpuAklhlSlLSfuu+iOddHeB+24nRN1qIJkuMmGk1R9FVGii7Xq6mVl1K1yCh+euh wJF4LjTDS05kw== From: Arnd Bergmann To: Jes Sorensen , Kalle Valo , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Ping-Ke Shih , Bitterblue Smith Cc: Arnd Bergmann , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] wifi: rtl8xxxu: add LEDS_CLASS dependency Date: Fri, 17 Feb 2023 10:59:04 +0100 Message-Id: <20230217095910.2480356-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758073151499301591?= X-GMAIL-MSGID: =?utf-8?q?1758073151499301591?= From: Arnd Bergmann rtl8xxxu now unconditionally uses LEDS_CLASS, so a Kconfig dependency is required to avoid link errors: aarch64-linux-ld: drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.o: in function `rtl8xxxu_disconnect': rtl8xxxu_core.c:(.text+0x730): undefined reference to `led_classdev_unregister' ERROR: modpost: "led_classdev_unregister" [drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.ko] undefined! ERROR: modpost: "led_classdev_register_ext" [drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.ko] undefined! Fixes: 3be01622995b ("wifi: rtl8xxxu: Register the LED and make it blink") Signed-off-by: Arnd Bergmann --- drivers/net/wireless/realtek/rtl8xxxu/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/Kconfig b/drivers/net/wireless/realtek/rtl8xxxu/Kconfig index 091d3ad98093..2eed20b0988c 100644 --- a/drivers/net/wireless/realtek/rtl8xxxu/Kconfig +++ b/drivers/net/wireless/realtek/rtl8xxxu/Kconfig @@ -5,6 +5,7 @@ config RTL8XXXU tristate "Realtek 802.11n USB wireless chips support" depends on MAC80211 && USB + depends on LEDS_CLASS help This is an alternative driver for various Realtek RTL8XXX parts written to utilize the Linux mac80211 stack.