diff mbox series

padata: Make kobj_type structure constant

Message ID 20230217-kobj_type-padata-v1-1-e70b6cab4875@weissschuh.net
State New
Headers
Series padata: Make kobj_type structure constant |

Commit Message

Thomas Weißschuh Feb. 17, 2023, 3:17 a.m. UTC 
  Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
the driver core allows the usage of const struct kobj_type.

Take advantage of this to constify the structure definition to prevent
modification at runtime.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
 kernel/padata.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


---
base-commit: 3ac88fa4605ec98e545fb3ad0154f575fda2de5f
change-id: 20230217-kobj_type-padata-288edceca728

Best regards,

Comments

Daniel Jordan Feb. 17, 2023, 4:14 p.m. UTC | #1 
On Fri, Feb 17, 2023 at 03:17:49AM +0000, Thomas Weißschuh wrote:
> Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
> the driver core allows the usage of const struct kobj_type.
> 
> Take advantage of this to constify the structure definition to prevent
> modification at runtime.
> 
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>

I see the symbol in .rodata now.  Thanks.

Acked-by: Daniel Jordan <daniel.m.jordan@oracle.com>

> ---
>  kernel/padata.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/padata.c b/kernel/padata.c
> index e007b8a4b738..106d08ee9ce2 100644
> --- a/kernel/padata.c
> +++ b/kernel/padata.c
> @@ -967,7 +967,7 @@ static const struct sysfs_ops padata_sysfs_ops = {
>  	.store = padata_sysfs_store,
>  };
>  
> -static struct kobj_type padata_attr_type = {
> +static const struct kobj_type padata_attr_type = {
>  	.sysfs_ops = &padata_sysfs_ops,
>  	.default_groups = padata_default_groups,
>  	.release = padata_sysfs_release,
> 
> ---
> base-commit: 3ac88fa4605ec98e545fb3ad0154f575fda2de5f
> change-id: 20230217-kobj_type-padata-288edceca728
> 
> Best regards,
> -- 
> Thomas Weißschuh <linux@weissschuh.net>
>
Herbert Xu March 10, 2023, 11:26 a.m. UTC | #2 
Thomas Weißschuh <linux@weissschuh.net> wrote:
> Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
> the driver core allows the usage of const struct kobj_type.
> 
> Take advantage of this to constify the structure definition to prevent
> modification at runtime.
> 
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
> kernel/padata.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied.  Thanks.
diff mbox series

Patch

diff --git a/kernel/padata.c b/kernel/padata.c
index e007b8a4b738..106d08ee9ce2 100644
--- a/kernel/padata.c
+++ b/kernel/padata.c
@@ -967,7 +967,7 @@  static const struct sysfs_ops padata_sysfs_ops = {
 	.store = padata_sysfs_store,
 };
 
-static struct kobj_type padata_attr_type = {
+static const struct kobj_type padata_attr_type = {
 	.sysfs_ops = &padata_sysfs_ops,
 	.default_groups = padata_default_groups,
 	.release = padata_sysfs_release,