From patchwork Thu Feb 16 07:34:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoquan He X-Patchwork-Id: 57892 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp164613wrn; Wed, 15 Feb 2023 23:47:07 -0800 (PST) X-Google-Smtp-Source: AK7set8aY38xGun5EuoqK/X4n3uOD35D50/BJW+eQO6FG6QD6Mmj24wkO2EvI4ZDmKZBZ9Ft/EOe X-Received: by 2002:a17:90b:1b50:b0:22c:8161:5143 with SMTP id nv16-20020a17090b1b5000b0022c81615143mr5758850pjb.31.1676533626950; Wed, 15 Feb 2023 23:47:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676533626; cv=none; d=google.com; s=arc-20160816; b=T9e2WvRI7Z+2uaMu0Tj2nBsXB0tBn3A7c1jMN3zI3PIgdXVbKJWx9G0X2fA7R5DpvG 0jkodK5M6iqCB50JGIh5nmRxqbMNP5zzoKw4deCOR3z15KNnsAfIZcRvQV8SMVtam4h6 775ikW53kfU+k9TtIXeMl1fnDhnpzP0j+wmzxz1pGl70kaO8Hatrqn0o7xKLYcqZ03oY wOlhBUUuAZgDg69/0ynSTRc/VK6l5P/zmLONya4QLS8mDDxcAEKDWH+/+G7QaeVxbDBl lshaUyPTUP7SltDgltDKcBZpqvZaN9Z8CYBQr/A0AJpLWb7iha7qC3Ljn7lHKcRDvJ88 RhqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=K8gjNmTSR559OlRy9/RjmiyCYfUP8oDtfxDvTzbUrgI=; b=TqHsCIIFWDdSlPh/3kL7HrJHIap2+MHXSlEb6RPvDihSCM32tx6nak60tiF4ued00l kKx0lKLjL07GpZ6m9fHyGGxDEvhhQXGImJI1PAfzhqsD7CPoaH1GsaTJv+Bq65eFeCgb PZxL7pLqxWOnAuw59R1c/6w0TRIXqfceBY2AvX5RvgwWCnCktTHD6oWZK/X0JZk9LoEj 0Nb2WOtSFP9j+qu59yPXEXHdZzqdFn618F3G2BlsXfRPWNKWDAnsU/y0aw2YmT6eL68f ewqqW1/TiLrNpYQ54rkXBg7lTibcoQyTpLOXYsrzdxDBhPWU+ylieOe2LoU9zZb7n03m Mtxg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="SkpWc/Ti"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w88-20020a17090a6be100b002340e8e4d6csi4121176pjj.94.2023.02.15.23.46.54; Wed, 15 Feb 2023 23:47:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="SkpWc/Ti"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229648AbjBPHfs (ORCPT + 99 others); Thu, 16 Feb 2023 02:35:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229532AbjBPHfp (ORCPT ); Thu, 16 Feb 2023 02:35:45 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C8953A08C for ; Wed, 15 Feb 2023 23:34:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676532864; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K8gjNmTSR559OlRy9/RjmiyCYfUP8oDtfxDvTzbUrgI=; b=SkpWc/TiozrqE7zFRcbVQjqQAKRIcSGvfAePr72p+pDYmUbqjbrPuWj9eL1kIDO4kQ3pJz L1EKVY8T2C8qVOKHVsJNlssXZv1G1o3UpCCr4gJG0AO3A0tZYjbLOUR3CI+9nbna8D/+wT REdKO+F2fArUH6RiCqp8vvGcdi+/Dvo= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-607-qFMrDV1tMX6QrEoyM6s7bg-1; Thu, 16 Feb 2023 02:34:18 -0500 X-MC-Unique: qFMrDV1tMX6QrEoyM6s7bg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1B46D811E6E; Thu, 16 Feb 2023 07:34:18 +0000 (UTC) Received: from MiWiFi-R3L-srv.redhat.com (ovpn-12-99.pek2.redhat.com [10.72.12.99]) by smtp.corp.redhat.com (Postfix) with ESMTP id F227C140EBF6; Thu, 16 Feb 2023 07:34:12 +0000 (UTC) From: Baoquan He To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, schnelle@linux.ibm.com, linux-s390@vger.kernel.org, Baoquan He , Andy Gross , Bjorn Andersson , Konrad Dybcio , Vinod Koul , linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org Subject: [PATCH 2/2] dmaengine: make QCOM_HIDMA depend on HAS_IOMEM Date: Thu, 16 Feb 2023 15:34:03 +0800 Message-Id: <20230216073403.451455-2-bhe@redhat.com> In-Reply-To: <20230216073403.451455-1-bhe@redhat.com> References: <20230216073403.451455-1-bhe@redhat.com> MIME-Version: 1.0 Content-type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757972924711346678?= X-GMAIL-MSGID: =?utf-8?q?1757972924711346678?= On s390 systems (aka mainframes), it has classic channel devices for networking and permanent storage that are currently even more common than PCI devices. Hence it could have a fully functional s390 kernel with CONFIG_PCI=n, then the relevant iomem mapping functions [including ioremap(), devm_ioremap(), etc.] are not available. Here let QCOM_HIDMA depend on HAS_IOMEM so that it won't be built to cause below compiling error if PCI is unset. -------------------------------------------------------- ld: drivers/dma/qcom/hidma.o: in function `hidma_probe': hidma.c:(.text+0x4b46): undefined reference to `devm_ioremap_resource' ld: hidma.c:(.text+0x4b9e): undefined reference to `devm_ioremap_resource' make[1]: *** [scripts/Makefile.vmlinux:35: vmlinux] Error 1 make: *** [Makefile:1264: vmlinux] Error 2 Link: https://lore.kernel.org/all/Y0TcaZD4nB1w+mAQ@MiWiFi-R3L-srv/T/#u Signed-off-by: Baoquan He Cc: Andy Gross Cc: Bjorn Andersson Cc: Konrad Dybcio Cc: Vinod Koul Cc: linux-arm-msm@vger.kernel.org Cc: dmaengine@vger.kernel.org Reviewed-by: Niklas Schnelle