From patchwork Thu Feb 16 06:41:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Muhammad Usama Anjum X-Patchwork-Id: 57888 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp148001wrn; Wed, 15 Feb 2023 22:59:57 -0800 (PST) X-Google-Smtp-Source: AK7set8YjzWjfMvB74Eq4HPg9w2XnUdOll0tnNcaMp/L+C2N/m8yH6JrZdvC2gN2JLjGgYfByVMy X-Received: by 2002:a17:906:af8c:b0:878:61d8:d7c2 with SMTP id mj12-20020a170906af8c00b0087861d8d7c2mr5164806ejb.39.1676530797009; Wed, 15 Feb 2023 22:59:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676530796; cv=none; d=google.com; s=arc-20160816; b=TkUaCK0IxUyP+C1b+pUtzHixL4nn/cRer1Zb76aYvt8U+U9wwnVk3TH8NBIGDEAhGe bKO5qTJ0JpaXYTtRQ2DWJ22ngt5yZA1Kr/FCXZBzx1ReC3AJujYXgCEUaKib4JNXWdcn 7zcwRf0QAMNbW3kWP/ybdlGIdb/FTFgYqN6XueRxyOjxL5lrK2A7UT8RLPmMv7XHNzpI g1AHpkEjy8pFaPw6Y4uhCh3ZbE87OKoPB+ADhaEFnGgOzFnatggJV1xaxTx0Otz0mH0S N5d1CAfl+5lbDB+R2hwm6ipHvKWSjyRUdqNeSk/kiY46MvkM6z+j9xYNZmk55wQH36dN +PdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ljirQrVNPG5UDLJtYd2F8HCRXiJQ1e82Nq6Ygyb5EHw=; b=onfSpj8KYWOv/eybTva2Q7C2UT7z3rSe09zuIN3URoz+YutqwTGpf1FBCNPeb/tGrB pnHz/mx5Lw6epca1A331jdAQO4VTsIlVuJdECGfo6Q2xBtj2CrgrhaRAfy3MyYzr6+g4 nKpEUE3vsJiLBN5wzQhVV3OW7ePe+Bipejvx4Wlp1VyOBVnQZqa8xr3lqAd7jfMWFc64 K8LeMY2+LvvOZbPRXCMXGNS+braPAdtTMxroZlRsYXCb65vJejHdGDzxcIdTRigXwpuA xZ4gaHo3DqxH1lMeiJPiByJltMD4wiHWDJ7PoCJUxrVHhKmv4I2o19EWxZ2kQ68GEsWX ciFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=gtjiguMc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fs35-20020a170907602300b008aac1899a54si999056ejc.354.2023.02.15.22.59.33; Wed, 15 Feb 2023 22:59:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=gtjiguMc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229752AbjBPGmh (ORCPT + 99 others); Thu, 16 Feb 2023 01:42:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229680AbjBPGm3 (ORCPT ); Thu, 16 Feb 2023 01:42:29 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22682BBA6 for ; Wed, 15 Feb 2023 22:42:26 -0800 (PST) Received: from localhost.localdomain (unknown [39.45.217.110]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madras.collabora.co.uk (Postfix) with ESMTPSA id 1A30A660219C; Thu, 16 Feb 2023 06:42:22 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1676529744; bh=M7QlyqeYtV2UlnIzxGzDOtk3LV88X9UD8SBF1GKpk74=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gtjiguMc1ox/cRrtHwHMVCqqQKZjlivuix+mk2HPqBPG0RDTXnrodYWaI33paHuT2 MnwrFREwKzaKSWE4XnItQrhajqD7F0D157Z2RfM9dNiDbjJiDTQhmzsGQ3i2uV1894 XkGgRXEOoJkI9C2vP/GYdQWub0zjuVk9yFx+t0Otn/cMUzWpmHSUQA+0cqTHuKiZw5 SM1z4Efw1toiuoAK0+ztCcENXZKBC8sA250DbD3XN0MPZABXkwMawCyZqxyFyw1G3c YhXFry0lnJ8Q2INWo0qqRV+lFMPLF1AgrjUgUkIO9SZVG4KqRza2PNt4LRcDeceNDG O+rbk+iToXINw== From: Muhammad Usama Anjum To: peterx@redhat.com, david@redhat.com, Andrew Morton Cc: Muhammad Usama Anjum , kernel@collabora.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 2/2] mm/userfaultfd: add VM_WARN_ONCE() Date: Thu, 16 Feb 2023 11:41:55 +0500 Message-Id: <20230216064155.1500545-2-usama.anjum@collabora.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230216064155.1500545-1-usama.anjum@collabora.com> References: <20230216064155.1500545-1-usama.anjum@collabora.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757969956845461844?= X-GMAIL-MSGID: =?utf-8?q?1757969956845461844?= Add VM_WARN_ONCE() to uffd_wp_range() to detect range (start, len) abuse. Signed-off-by: Muhammad Usama Anjum --- mm/userfaultfd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mm/userfaultfd.c b/mm/userfaultfd.c index 366dc097ab11..9db77c36ef18 100644 --- a/mm/userfaultfd.c +++ b/mm/userfaultfd.c @@ -716,6 +716,8 @@ void uffd_wp_range(struct mm_struct *dst_mm, struct vm_area_struct *dst_vma, unsigned int mm_cp_flags; struct mmu_gather tlb; + VM_WARN_ONCE(start < dst_vma->vm_start || start + len > dst_vma->vm_end, + "The address range exceeds VMA boundary.\n"); if (enable_wp) mm_cp_flags = MM_CP_UFFD_WP; else