From patchwork Thu Feb 16 05:17:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suren Baghdasaryan X-Patchwork-Id: 57840 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp116746wrn; Wed, 15 Feb 2023 21:19:21 -0800 (PST) X-Google-Smtp-Source: AK7set/EU3Y7USQM6raO6gEFyu7Fz4+NxvR9Ak+dCnQxNrgohlQ9TEZnPdX13ja5VlbsygHWiqta X-Received: by 2002:a17:902:fad0:b0:19a:c65d:f91 with SMTP id ld16-20020a170902fad000b0019ac65d0f91mr4657676plb.66.1676524761194; Wed, 15 Feb 2023 21:19:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676524761; cv=none; d=google.com; s=arc-20160816; b=SLcM0joksv8uwYZLj+1BnE9tLY4f7BCT/AZLUBr6pUpF4M/K2Spk66m0F9a9Fy4XuH RVKh/sYg8VnCx+Tve3umZKr/vXqooK1UPdBbOuk5pCuaRB6uiPfV2W79b5bB56vHlFE3 BDgFpI4oZ7rs/u0OUtrA3tS2/Er/OSehtIhBXtNnUDqld4FvuXQqztEnIlaB2/RCd1Te odegLeDxGXLf+nhCzr5abbcXAMiyUshLDR9JJIoUDAptyzgrwiYP39fT8qI5UWk0dGoS nR4B6GtTIN5dk2aj8dwk2DDJXw5s4wR6rpB8uJqbBo/DXyV/SBsSi4cOYP/aOlsRTv2z 4ldQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:dkim-signature; bh=bYTu7nw04Y/eGAN3i9eCzY/Ke38OAVixcrHXlu+jNFw=; b=0nJcBK/FXJZRAqrefpmnldX3X4qN1JDH9YzUCyNIYCvU9E7WOJohBjgbatp8DYEyQS xZkMKsobZsquXV3wrz5j65qCdvai/30t8GRuLdYEuFRYYzK7p8khGbw/tPnZVvh5O/1t Cm3icwCdiNZzJS0PoNbX3/STlfJqWMVKd5CDAYuvpnDIy/fpAW10zG7r/na50FGmOg3K b50aFcsySHBE/2Zl8KGRCoP3G2BxoqhogSoZQmK8wJALW46b3kS87Fa/wkz3nPdGAyK7 BoLzQsJz83TVwxVWuMqWqo52HKf4/cNzMexjYTrN0IDVdq6GwgcZetICbTZ7qEJaCDZ2 qxEQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=WNV0WuL9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i10-20020a170902c94a00b001990992d68fsi463277pla.518.2023.02.15.21.19.08; Wed, 15 Feb 2023 21:19:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=WNV0WuL9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229607AbjBPFSU (ORCPT + 99 others); Thu, 16 Feb 2023 00:18:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229571AbjBPFSF (ORCPT ); Thu, 16 Feb 2023 00:18:05 -0500 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0CBF41BACE for ; Wed, 15 Feb 2023 21:18:05 -0800 (PST) Received: by mail-yb1-xb49.google.com with SMTP id u2-20020a25ab02000000b0090f2c84a6a4so856822ybi.13 for ; Wed, 15 Feb 2023 21:18:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=bYTu7nw04Y/eGAN3i9eCzY/Ke38OAVixcrHXlu+jNFw=; b=WNV0WuL9vmXLIvOmuVEVNJHnS2Qfi+AtiXnEC8qLvBZk4nQfRysiQv+n6V2TYm/oOI 8PVrbtoCrNJAR827RYRUq+srgPH7ettT9CkewSYs2c20qjx3DSR6OCNLU8I9VtlWJ1vK BTnTnTmkn3I2d2LJu6019qpcNY3Rtyhwbcu+BTERQU4CpKL9XQ+m6KDQOlEen5oxaVLd mpn44+vsVlTTH8ejjgOPKl/5T26Yr75D1Q+Pk5P8P+e6MTdUqg4koF2LdV4PYx+3j32Q lvmdVkZra/AZy5zB6Ynbz9xE0KdiJ+yp/dRpPvAGFlnQDPvuVze/cOT0f1MBvOftG1xW MgmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bYTu7nw04Y/eGAN3i9eCzY/Ke38OAVixcrHXlu+jNFw=; b=Ania1ZLP9q/F4RNkOFXcdEJbZv56ecwm5AGJQ9BhMAx+judzw6GBWo1HF92JV9TOB4 bjILJPSGNkUO7RbZir+GuL9z6gheQem6474yDRPwhbbaDTvHToXpHlX7eQflngYsMFHo XnDDNy2/dZAViLuSu38r5WcJh5Ps4LQY2KXaDOkscenI5vFz8RszXUrGF+cDoLm32rs2 dvrjjr9M9kU34QdZmqTlH9OtRkQCMoI6GbV90CoSPJV25R/UdX//B5ikj55lEXfRdtWU gZgSu81xF/ByoTH9sRWxPFB7FBKiR8BLCTCmbxgIo3OLs4iI+mdoZO6MrJu2uPoXmib2 Usvg== X-Gm-Message-State: AO0yUKVXkf08Q0JCIBm+kndP+PICAZpCLDEP/kIwL2fle1gCqMH2c/dP 0O/EA20CYPlT0fEyvO9HxerCba7I4NY= X-Received: from surenb-desktop.mtv.corp.google.com ([2620:15c:211:200:f781:d5ed:1806:6ebb]) (user=surenb job=sendgmr) by 2002:a05:6902:1024:b0:8fc:686c:cf87 with SMTP id x4-20020a056902102400b008fc686ccf87mr15ybt.4.1676524683783; Wed, 15 Feb 2023 21:18:03 -0800 (PST) Date: Wed, 15 Feb 2023 21:17:19 -0800 In-Reply-To: <20230216051750.3125598-1-surenb@google.com> Mime-Version: 1.0 References: <20230216051750.3125598-1-surenb@google.com> X-Mailer: git-send-email 2.39.1.581.gbfd45094c4-goog Message-ID: <20230216051750.3125598-5-surenb@google.com> Subject: [PATCH v3 04/35] maple_tree: remove extra smp_wmb() from mas_dead_leaves() From: Suren Baghdasaryan To: akpm@linux-foundation.org Cc: michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, mingo@redhat.com, will@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, chriscli@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, rppt@kernel.org, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, gurua@google.com, arjunroy@google.com, soheil@google.com, leewalsh@google.com, posk@google.com, michalechner92@googlemail.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com, Liam Howlett , Suren Baghdasaryan X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757963627905620510?= X-GMAIL-MSGID: =?utf-8?q?1757963627905620510?= From: Liam Howlett The call to mte_set_dead_node() before the smp_wmb() already calls smp_wmb() so this is not needed. This is an optimization for the RCU mode of the maple tree. Fixes: 54a611b60590 ("Maple Tree: add new data structure") Signed-off-by: Liam Howlett Signed-off-by: Suren Baghdasaryan --- lib/maple_tree.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/maple_tree.c b/lib/maple_tree.c index 44d6ce30b28e..3d5ab02f981a 100644 --- a/lib/maple_tree.c +++ b/lib/maple_tree.c @@ -5517,7 +5517,6 @@ unsigned char mas_dead_leaves(struct ma_state *mas, void __rcu **slots, break; mte_set_node_dead(entry); - smp_wmb(); /* Needed for RCU */ node->type = type; rcu_assign_pointer(slots[offset], node); }