From patchwork Thu Feb 16 05:17:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suren Baghdasaryan X-Patchwork-Id: 57859 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp117371wrn; Wed, 15 Feb 2023 21:21:20 -0800 (PST) X-Google-Smtp-Source: AK7set9i6nbBwyFgXDOU/QVzEJH+5pZW8kbOsGFvnhu0avX//8bEJmGOoBCN6kTbjU/oGphcXfl5 X-Received: by 2002:a17:906:4d49:b0:88f:87f0:c919 with SMTP id b9-20020a1709064d4900b0088f87f0c919mr5453449ejv.64.1676524880748; Wed, 15 Feb 2023 21:21:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676524880; cv=none; d=google.com; s=arc-20160816; b=nQrAuAd5sANNzev/XzbEKaHrFASEBH+QxnZ1OvpKb2VjymvMsTrlO7pcpcLAhYd2XZ qODiULFa0lq9A0j8PsjLJN7vdl60Cv/koKyJ/Z9gzbIIn1x9bHVKD2gRQL41imZbCOcd 2MMQ+WcEEHuBPjHJBnjklY2oMpx4fsXqeQdqv6cv2YtKvxhEq4NRyZIDRC72nSKLdghh uSBfRyQqq9JKIGjB3KCK4s5NQ+bpEov2ZPeTKQNMjklhVZdEtX41gxCpauWuHhAlo0nA F4mO+nVlO6GPuHQ2NgWrvLn1Cfz89hqptHZAu79jWBgSFHOtI1yvO7u2F7I75UCb3/NW GNCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:dkim-signature; bh=Cy3b4YdYe1JheypyM1qEqlntx+LNPOiVtlvqoTpRTGk=; b=qJ99wmWBKnJtO6smofqCXb1d0h8tR0zf8ItLeLjP9NGwXDioC642tibGwM54kqOm74 MKMoSj59XRrPCn+HesG+hxrSBRUjm6LQAmYeOoja3jPKXnOatw2b1SNOMONot0KsmvM3 1BDYI6pFaQex0O+WjRc7uaEClyxGDZUIP6NgArTockTYjxDxZd6TlUeW2+inAhPg1f0l wCPZQcfuqG807Jj4kDrlf0cppd8+EouI8mZeAF2tpzznDbM+CrliL6wu0aAzOdANngVG pNkAqus+bpCpnUWOb8n4gh0goGzp8rfpC7LXnMK/yXNq64INPdqewHKhpdoXnuTUbNsH BzFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=ee09VaaN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ex20-20020a170907955400b008b143bc84ebsi718814ejc.380.2023.02.15.21.20.57; Wed, 15 Feb 2023 21:21:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=ee09VaaN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229677AbjBPFU3 (ORCPT + 99 others); Thu, 16 Feb 2023 00:20:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229672AbjBPFT3 (ORCPT ); Thu, 16 Feb 2023 00:19:29 -0500 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88CC1457D5 for ; Wed, 15 Feb 2023 21:18:49 -0800 (PST) Received: by mail-yb1-xb49.google.com with SMTP id r17-20020a258291000000b008ee1c76c25dso857450ybk.11 for ; Wed, 15 Feb 2023 21:18:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=Cy3b4YdYe1JheypyM1qEqlntx+LNPOiVtlvqoTpRTGk=; b=ee09VaaNfMCXdTYs7ho4FL1rz+7Jau0hVrpqtPJwR0LOjVJOOKMHcMbwd/rGxak63H BRVuTQ9tdXJzSR+6NhiK4KAEy3orTDG5A6ugcB1Mu/JZ3TtJ8rFlU/MHE4DwjmulfLqA 4lbez5vLr44VvmK0HXNKetjG61FmR5dtu/ffCFjZaMQfVdd6yPZ6Vqs7cSoCFmCWN2ej U7UJuLArjVJJvFA58VBbTFzUGAlbxAZVBV5EE2zVq6EhbmHffJxz6yeGBWtLnffH9zfX I0SKmeE3zn9vqZPVYyRXu1tk/VZ/LisV9OyoAUd6iOjxLewnK1RWOS7bKO/6E67varMh DYqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Cy3b4YdYe1JheypyM1qEqlntx+LNPOiVtlvqoTpRTGk=; b=S9oRNMN53hXvJ2u1o7n8WUTsVPHgF6cCHA3DtHB81BbxgFZtLfiESNINvU+MrQlQTl 2OQI5aBIlbXTepj2OvGFJy/NxbAg/D2XM9ATKRNyocDpu83/sPUO+aMTUXiMHYwMYhsu s7viF2fnSNjy2HCFJ7RkGPHKAp8Ss1MuTFjQK+KL9rw1EBJpjtFnw/64M0BfxmMu9RRq xzzVmaVRZG63cXb7Kvfjc8EqozIab4Hqa7EdAxGbaAG9/oyXLbYGAnd82croe6EQ396q f3rScoWmoAKeTcCZb0cVCntKD8dMZ2lAwHZXSUOx1q8G0mCya+Dc4SxPLUpeXChTQUAw CafA== X-Gm-Message-State: AO0yUKUz8GvR4fi84hr3SHgZZVjuQxXZI6fJuvveD+V0xnJx0/jIwh/4 Soh49U9H69yCtRj4ZMAt220Ni4XVSXc= X-Received: from surenb-desktop.mtv.corp.google.com ([2620:15c:211:200:f781:d5ed:1806:6ebb]) (user=surenb job=sendgmr) by 2002:a0d:c347:0:b0:52f:1923:4f9d with SMTP id f68-20020a0dc347000000b0052f19234f9dmr562132ywd.366.1676524727987; Wed, 15 Feb 2023 21:18:47 -0800 (PST) Date: Wed, 15 Feb 2023 21:17:37 -0800 In-Reply-To: <20230216051750.3125598-1-surenb@google.com> Mime-Version: 1.0 References: <20230216051750.3125598-1-surenb@google.com> X-Mailer: git-send-email 2.39.1.581.gbfd45094c4-goog Message-ID: <20230216051750.3125598-23-surenb@google.com> Subject: [PATCH v3 22/35] kernel/fork: assert no VMA readers during its destruction From: Suren Baghdasaryan To: akpm@linux-foundation.org Cc: michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, mingo@redhat.com, will@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, chriscli@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, rppt@kernel.org, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, gurua@google.com, arjunroy@google.com, soheil@google.com, leewalsh@google.com, posk@google.com, michalechner92@googlemail.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com, Suren Baghdasaryan X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757963753331622624?= X-GMAIL-MSGID: =?utf-8?q?1757963753331622624?= Assert there are no holders of VMA lock for reading when it is about to be destroyed. Signed-off-by: Suren Baghdasaryan --- kernel/fork.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/kernel/fork.c b/kernel/fork.c index 9141427a98b2..a08cc0e2bfde 100644 --- a/kernel/fork.c +++ b/kernel/fork.c @@ -491,6 +491,9 @@ static void vm_area_free_rcu_cb(struct rcu_head *head) { struct vm_area_struct *vma = container_of(head, struct vm_area_struct, vm_rcu); + + /* The vma should not be locked while being destroyed. */ + VM_BUG_ON_VMA(rwsem_is_locked(&vma->lock), vma); __vm_area_free(vma); } #endif