Message ID | 20230216013230.22978-12-ansuelsmth@gmail.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp42415wrn; Wed, 15 Feb 2023 17:39:33 -0800 (PST) X-Google-Smtp-Source: AK7set+C5ouWcqKAECFZDdav7Mq88DId0QpE4VLttexF+FnrgOmLna0+3/5lnCDU07L11hlzZcTw X-Received: by 2002:a17:906:a193:b0:872:82d3:4162 with SMTP id s19-20020a170906a19300b0087282d34162mr4029913ejy.44.1676511573448; Wed, 15 Feb 2023 17:39:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676511573; cv=none; d=google.com; s=arc-20160816; b=DcnD8DN323gq/8dJe434YrXi5D87wQUdSzHscLwlFbJ79RE16YMMbOffXRxnj6jpPt t1INPCx2jRhZuWhaYWSsF2/Z0ukcioP0de7cj2Kxm+juZRGImsOZ8R2ET2qrL7LNlEvO 5t2XZqNwY+edXz7hC6hLtoyr9gQrpOlBowubRrKSrpKoTv6syCCwsChK9v2j7GV8h6B/ SfOz4s6++Bv0p2qGzvqQPvfoHkrlylERhZAUruV+8LDncERQ+0u64AQT+O5um+bTjIER USLGA2wESs7y++LiYc/83mMymOdEjG7z2Z+qmwsKONaCoSPG8jw0DSTwtHaKLWbDwZko 8kvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=UXjDXVBhPh+t9c62wIxQrMzlmx5/oPRIL9dFvo3+Emc=; b=z9tpP+7+cl1sEwcfSh8i20UyXV/uaLEDYyThUB7OVoA0gg8mVZgMAHUfqrgjXSAtuL XbAkYszw1QHs8IXlkewOM65I6GYTvl/GTf038DCcqxSUWuHvn0hxVKh+Ef+GNJdLnhze QqrrfJhLk4j7jVLBv64p6WXRGv8vM6MxvDG6DDBQw3c7OJeEiN0FWOR2VP9TKAbGfJ0Y UuFHaYFlfBNRuhPPTT/a23Z7sAhTZdRUNVhtdaUU7DugtPw37oQOhf7QTL3oWQB+vmLy EdMyX/chfapjO7xIHSpYnG6iJyLlUixXQPXVGqrVhmUX5oMr4+L/3eJ1wKZw+jAaqajN wL2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=eSPyZlmn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 18-20020a170906209200b008b1345a13a8si482301ejq.169.2023.02.15.17.39.10; Wed, 15 Feb 2023 17:39:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=eSPyZlmn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229794AbjBPBhh (ORCPT <rfc822;hadasmailinglist@gmail.com> + 99 others); Wed, 15 Feb 2023 20:37:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229751AbjBPBhX (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 15 Feb 2023 20:37:23 -0500 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF08646159; Wed, 15 Feb 2023 17:36:33 -0800 (PST) Received: by mail-wm1-x32c.google.com with SMTP id s13-20020a05600c45cd00b003ddca7a2bcbso436587wmo.3; Wed, 15 Feb 2023 17:36:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=UXjDXVBhPh+t9c62wIxQrMzlmx5/oPRIL9dFvo3+Emc=; b=eSPyZlmnVMuk7xkgaR5rAsNsQHXeLwRWwy9mGle9Ba0+6mFf7vasHk1mk7gtlNhv+g Otp8kwMuIP2+Y0g5vRF9lQJU9B4VvAGnmiaddUS9Av+LwHdtxzejBxiRH8rlnlMe1mwq LvSkPsj+II+gNmlXvSQ2c+EoYzR+5BmcWwR+j153Tm2ATh1P6VYQyEy0HuZuuIJBsA0w ED8pnbZnzuC2OBDmNfZdTHgtjBqKGtkR9udEHnDm40plgvE2FJhR85VrmRG87HSYRn6g 1zoVDF9Vp/Zh8T4uNOh/5TNqrdXt+AHWOo9Mx7UzcvNPXF7dWY9DontZIrQRnJUez1sj d39g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UXjDXVBhPh+t9c62wIxQrMzlmx5/oPRIL9dFvo3+Emc=; b=I02yUd+RLc0hMogeMFBzas3Dc7+4l2WteA28AEsKqogf7zsF3bLGkPR+uyXgEnhUxm OsmufbAUaGojfmvVDNIyXksVa9Kzr1HTniMmE2kXFHalp9/3p8OnvQzqyQ8zJ/dlTaG1 EnroR8gT0HQ0/KiBy9yUwwYqeb0zedXPSVXs8yDTZQfgHK1oe0/6JADQFq2wn9IW5MpY O5A0SRSY5YsniUo3IeIfdGDJ3ld8bums3ayMw2TQH5Vcz2FCpNk/bdc0wX9SdOijXtJ8 MdbMxLdeL+SdAmvoxmdVbegltBh3/Vwmd0dzqVltIma1zMVCFvZmFm23wmsrcZ3ldHTo FISQ== X-Gm-Message-State: AO0yUKVC/4B15VpxmxjVxQm0yf4MHdsXAWfhC1mcBN1nfg4+opwYEffT Sv4nnOtsxdzJ8ySFVy/lTaI= X-Received: by 2002:a05:600c:708:b0:3dc:1687:9ba2 with SMTP id i8-20020a05600c070800b003dc16879ba2mr3525748wmn.35.1676511391667; Wed, 15 Feb 2023 17:36:31 -0800 (PST) Received: from localhost.localdomain (93-34-91-73.ip49.fastwebnet.it. [93.34.91.73]) by smtp.googlemail.com with ESMTPSA id v15-20020a05600c214f00b003e1fb31fc2bsm64189wml.37.2023.02.15.17.36.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Feb 2023 17:36:31 -0800 (PST) From: Christian Marangi <ansuelsmth@gmail.com> To: Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Andrew Lunn <andrew@lunn.ch>, Florian Fainelli <f.fainelli@gmail.com>, Vladimir Oltean <olteanv@gmail.com>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Heiner Kallweit <hkallweit1@gmail.com>, Russell King <linux@armlinux.org.uk>, Jonathan Corbet <corbet@lwn.net>, Christian Marangi <ansuelsmth@gmail.com>, "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>, Jacek Anaszewski <jacek.anaszewski@gmail.com>, John Crispin <john@phrozen.org>, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-doc@vger.kernel.org, Tim Harvey <tharvey@gateworks.com>, Alexander Stein <alexander.stein@ew.tq-group.com>, Rasmus Villemoes <rasmus.villemoes@prevas.dk>, Bagas Sanjaya <bagasdotme@gmail.com>, Arun.Ramadoss@microchip.com Subject: [PATCH v8 11/13] dt-bindings: leds: Document netdev trigger Date: Thu, 16 Feb 2023 02:32:28 +0100 Message-Id: <20230216013230.22978-12-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230216013230.22978-1-ansuelsmth@gmail.com> References: <20230216013230.22978-1-ansuelsmth@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757949799445240220?= X-GMAIL-MSGID: =?utf-8?q?1757949799445240220?= |
Series |
Adds support for PHY LEDs with offload triggers
|
|
Commit Message
Christian Marangi
Feb. 16, 2023, 1:32 a.m. UTC
Document the netdev trigger that makes the LED blink or turn on based on
switch/phy events or an attached network interface.
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
---
Documentation/devicetree/bindings/leds/common.yaml | 2 ++
1 file changed, 2 insertions(+)
Comments
On Fri, Feb 17, 2023 at 05:03:46PM -0600, Rob Herring wrote: > On Thu, Feb 16, 2023 at 02:32:28AM +0100, Christian Marangi wrote: > > Document the netdev trigger that makes the LED blink or turn on based on > > switch/phy events or an attached network interface. > > NAK. What is netdev? But netdev is a trigger, nothing new. Actually it was never documented. Is the linux,default-trigger getting deprecated? > > Don't add new linux,default-trigger entries either. We have better ways > to define trigger sources, namely 'trigger-sources'. > > > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> > > --- > > Documentation/devicetree/bindings/leds/common.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml > > index d34bb58c0037..6e016415a4d8 100644 > > --- a/Documentation/devicetree/bindings/leds/common.yaml > > +++ b/Documentation/devicetree/bindings/leds/common.yaml > > @@ -98,6 +98,8 @@ properties: > > # LED alters the brightness for the specified duration with one software > > # timer (requires "led-pattern" property) > > - pattern > > + # LED blink and turns on based on netdev events > > + - netdev > > - pattern: "^cpu[0-9]*$" > > - pattern: "^hci[0-9]+-power$" > > # LED is triggered by Bluetooth activity > > -- > > 2.38.1 > >
On Thu, Feb 16, 2023 at 02:32:28AM +0100, Christian Marangi wrote: > Document the netdev trigger that makes the LED blink or turn on based on > switch/phy events or an attached network interface. NAK. What is netdev? Don't add new linux,default-trigger entries either. We have better ways to define trigger sources, namely 'trigger-sources'. > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> > --- > Documentation/devicetree/bindings/leds/common.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml > index d34bb58c0037..6e016415a4d8 100644 > --- a/Documentation/devicetree/bindings/leds/common.yaml > +++ b/Documentation/devicetree/bindings/leds/common.yaml > @@ -98,6 +98,8 @@ properties: > # LED alters the brightness for the specified duration with one software > # timer (requires "led-pattern" property) > - pattern > + # LED blink and turns on based on netdev events > + - netdev > - pattern: "^cpu[0-9]*$" > - pattern: "^hci[0-9]+-power$" > # LED is triggered by Bluetooth activity > -- > 2.38.1 >
On Fri, Feb 17, 2023 at 06:58:39AM +0100, Christian Marangi wrote: > On Fri, Feb 17, 2023 at 05:03:46PM -0600, Rob Herring wrote: > > On Thu, Feb 16, 2023 at 02:32:28AM +0100, Christian Marangi wrote: > > > Document the netdev trigger that makes the LED blink or turn on based on > > > switch/phy events or an attached network interface. > > > > NAK. What is netdev? > > But netdev is a trigger, nothing new. Actually it was never documented. Okay, please state that in the commit message. > Is the linux,default-trigger getting deprecated? Not quite, but it shouldn't be used for anything tied to a device IMO. Rob
diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml index d34bb58c0037..6e016415a4d8 100644 --- a/Documentation/devicetree/bindings/leds/common.yaml +++ b/Documentation/devicetree/bindings/leds/common.yaml @@ -98,6 +98,8 @@ properties: # LED alters the brightness for the specified duration with one software # timer (requires "led-pattern" property) - pattern + # LED blink and turns on based on netdev events + - netdev - pattern: "^cpu[0-9]*$" - pattern: "^hci[0-9]+-power$" # LED is triggered by Bluetooth activity