diff mbox series

mm/uffd: Fix comment in handling pte markers

Message ID 20230215205800.223549-1-peterx@redhat.com
State New
Headers
Series mm/uffd: Fix comment in handling pte markers |

Commit Message

Peter Xu Feb. 15, 2023, 8:58 p.m. UTC 
  The comment is obsolete after f369b07c8614 ("mm/uffd: reset write
protection when unregister with wp-mode", 2022-08-20).  Remove it.

Signed-off-by: Peter Xu <peterx@redhat.com>
---
 mm/memory.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

David Hildenbrand Feb. 15, 2023, 8:59 p.m. UTC | #1 
On 15.02.23 21:58, Peter Xu wrote:
> The comment is obsolete after f369b07c8614 ("mm/uffd: reset write
> protection when unregister with wp-mode", 2022-08-20).  Remove it.
> 
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>   mm/memory.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/mm/memory.c b/mm/memory.c
> index 7a04a1130ec1..f456f3b5049c 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -3627,9 +3627,7 @@ static vm_fault_t pte_marker_handle_uffd_wp(struct vm_fault *vmf)
>   {
>   	/*
>   	 * Just in case there're leftover special ptes even after the region
> -	 * got unregistered - we can simply clear them.  We can also do that
> -	 * proactively when e.g. when we do UFFDIO_UNREGISTER upon some uffd-wp
> -	 * ranges, but it should be more efficient to be done lazily here.
> +	 * got unregistered - we can simply clear them.
>   	 */
>   	if (unlikely(!userfaultfd_wp(vmf->vma) || vma_is_anonymous(vmf->vma)))
>   		return pte_marker_clear(vmf);

Reviewed-by: David Hildenbrand <david@redhat.com>
diff mbox series

Patch

diff --git a/mm/memory.c b/mm/memory.c
index 7a04a1130ec1..f456f3b5049c 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -3627,9 +3627,7 @@  static vm_fault_t pte_marker_handle_uffd_wp(struct vm_fault *vmf)
 {
 	/*
 	 * Just in case there're leftover special ptes even after the region
-	 * got unregistered - we can simply clear them.  We can also do that
-	 * proactively when e.g. when we do UFFDIO_UNREGISTER upon some uffd-wp
-	 * ranges, but it should be more efficient to be done lazily here.
+	 * got unregistered - we can simply clear them.
 	 */
 	if (unlikely(!userfaultfd_wp(vmf->vma) || vma_is_anonymous(vmf->vma)))
 		return pte_marker_clear(vmf);