From patchwork Wed Feb 15 13:23:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 57539 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp190165wrn; Wed, 15 Feb 2023 05:29:24 -0800 (PST) X-Google-Smtp-Source: AK7set+oH0SUrb+Os0weq7luGUVI4ZIaiLGIqY4jaEpFLDpe6MZzfqWwbj+ktzlee6EOwcFezo3w X-Received: by 2002:a17:90a:930b:b0:233:f98a:8513 with SMTP id p11-20020a17090a930b00b00233f98a8513mr2900163pjo.8.1676467764566; Wed, 15 Feb 2023 05:29:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676467764; cv=none; d=google.com; s=arc-20160816; b=ZR5MNsDbe0cg/rVXMGWWTO6895peQEadSwhGqd+Ng10+6o6NVWKZySUnvWfMhppaEp f6P3DKD7w9+Q4GVVVj7KmZFLtiN5+RQepuF16WH7aEqqACamxhaBPe6h35bXru/vGnjE zBnjjsQaNlQS6wVcyjF+0IBA6SftNGx/Q5q0ahg1MQwT0Z+x1p01hUX+MblcE0zYB2XF iT3fcyP+9Bdv4wfUinrqI2B0vufDkru/S2UoROO/Ej39cWhX8bgKBS33z0NAAw+NxGJd kk0CQIsj8EMyC65i8059IMcYnqFtpOVvEmLtVxxgE5s9YgtTZVxB3QsZJ+t5wWXIVj+2 oayw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=eqDyefNl57rq8WHDciIZ5UWNviyMq09cPsfD60aF4Jc=; b=sOSMGdSbcnBA/5/HSVBQ8VjHKta0jqgKharvqmUq1xIsO6/pMQK8YC64tVJzR3SABh ypru8j+lhZj/8kMbPd0osWOD2snubHCJjzUW7G+0+iSa5xmfjAWiu/m15TZ/6+OgnS8P jrhq/zDj3xtBQLM2w8gzQX6lXG31csq2RM8O96nDATioNuL9V4FnaJkT6dWHS/JLOMIt L/h4qs4kRhfIRn5OagwjrHy3tM59I4LUt3cVIRIe2XTb66sI3zb+jqIRMe7IXkPBdeI1 iobT3hV5bP+paY7a4+9cwrvrMbviu8FYKSVg0fq4rMfNf7zqhAzqIv2iDZcFXCNEAx0P IdAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Tq9qBiRs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mq9-20020a17090b380900b002340f45c0ffsi2522340pjb.90.2023.02.15.05.29.12; Wed, 15 Feb 2023 05:29:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Tq9qBiRs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234216AbjBONXP (ORCPT + 99 others); Wed, 15 Feb 2023 08:23:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234207AbjBONXL (ORCPT ); Wed, 15 Feb 2023 08:23:11 -0500 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 019BF5593 for ; Wed, 15 Feb 2023 05:23:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676467388; x=1708003388; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=WUgNwUhbHaN9HZCnYj8+XtWA1iYsv49O9uBI9FvhwpY=; b=Tq9qBiRsOUg14CVe0EygwbCIpdRKvw4VLU61YtAa+SePYm+OPKhZbald RKiuMV6vDIhfTeEsQ77lZTId+K+boWTl1mQQEJZf53xVxbALol7f6IlFI +5yjNzerPAjWYO8ZWpLLjrCAutJ+eQp+uDfbhy4AxnGsvY5AnnGupospF pFttnMpekwrV7AraBpQRMyaaepTOgpd0+HVxpuPLRY+GCDnByVOpJei5g FeyMdOHaT//6pbXRHEgKDAGqugW0fWBkcE77hMcJBnl+23XtvJ2vLBysV QaSs9kOipnEcVaE+VHuynQEQBFixxyqclXwdmy/2JT3e2w5xnMf+YS3u7 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10621"; a="333563901" X-IronPort-AV: E=Sophos;i="5.97,299,1669104000"; d="scan'208";a="333563901" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2023 05:23:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10621"; a="733281649" X-IronPort-AV: E=Sophos;i="5.97,299,1669104000"; d="scan'208";a="733281649" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga008.fm.intel.com with ESMTP; 15 Feb 2023 05:23:05 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 56FC51A6; Wed, 15 Feb 2023 15:23:45 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , kernel test robot , Dan Carpenter Subject: [PATCH v1 1/1] ASoC: soc-ac97: Return correct error codes Date: Wed, 15 Feb 2023 15:23:43 +0200 Message-Id: <20230215132343.35547-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757903862790953150?= X-GMAIL-MSGID: =?utf-8?q?1757903862790953150?= With the switching to dev_err_probe(), during the conversion of GPIO calls, the return code is passed is a paratemer to it. At the same time a copy'n'paste mistake was made, so the wrong variable has been taken for the error reporting. Fix this. Fixes: 3ee0d39c50dc ("ASoC: soc-ac97: Convert to agnostic GPIO API") Reported-by: kernel test robot Reported-by: Dan Carpenter Signed-off-by: Andy Shevchenko --- sound/soc/soc-ac97.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/soc-ac97.c b/sound/soc/soc-ac97.c index 40051f513c6a..4e4fe29ade50 100644 --- a/sound/soc/soc-ac97.c +++ b/sound/soc/soc-ac97.c @@ -336,12 +336,12 @@ static int snd_soc_ac97_parse_pinctl(struct device *dev, cfg->sdata_gpio = devm_gpiod_get_index(dev, "ac97", 1, GPIOD_ASIS); if (IS_ERR(cfg->sdata_gpio)) - return dev_err_probe(dev, PTR_ERR(cfg->sync_gpio), "Can't find ac97-sdata gpio\n"); + return dev_err_probe(dev, PTR_ERR(cfg->sdata_gpio), "Can't find ac97-sdata gpio\n"); gpiod_set_consumer_name(cfg->sdata_gpio, "AC97 link sdata"); cfg->reset_gpio = devm_gpiod_get_index(dev, "ac97", 2, GPIOD_ASIS); if (IS_ERR(cfg->reset_gpio)) - return dev_err_probe(dev, PTR_ERR(cfg->sync_gpio), "Can't find ac97-reset gpio\n"); + return dev_err_probe(dev, PTR_ERR(cfg->reset_gpio), "Can't find ac97-reset gpio\n"); gpiod_set_consumer_name(cfg->reset_gpio, "AC97 link reset"); return 0;