From patchwork Wed Feb 15 13:05:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ilpo_J=C3=A4rvinen?= X-Patchwork-Id: 57528 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp179824wrn; Wed, 15 Feb 2023 05:08:16 -0800 (PST) X-Google-Smtp-Source: AK7set/Q60wkIuIsJwpG443IqKuNrIaEgYG1cldfglwX45nN31gB66UTItEqASrTII917owN6T6U X-Received: by 2002:a05:6a20:c5a9:b0:c6:d84a:ce1c with SMTP id gn41-20020a056a20c5a900b000c6d84ace1cmr1113796pzb.35.1676466496593; Wed, 15 Feb 2023 05:08:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676466496; cv=none; d=google.com; s=arc-20160816; b=diCcZNExT4iP2/QvjkJcNCtXjzN+dnT3VyC8nysA6rP1NuMu614TOMDrxJ9cHzwsbb A4Hu3+Pv4vcIb7IVPNI+iclGVVGufSK4DW5sNbQF2EYFzWX1O3vnRKpSXP6ALfoz/CCU 8nDxTiRR5UmalfagWXhsW+CeHJmkq7ZtXjHWjDxGXY2tVau5UHGPJ5lGhopXydNk7akO +NTnbIbMD/MgzxkLVYsGvGoZLviUggXti5x1BShvmWjryKJOJGS5bl35KsMMukzGhLjy KdDvxXVTtt46EIjYR4n1XXpaBjo/LibKxZpYzYViaxsRZMorszZZcONDXOtCx0dhnqB/ BZuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=K3SQXe++tBfpe3sczDsyeqgKawxCx6wcARY6zJ82Q/4=; b=CCapzd9uWdD6hQrentmp/lE8QSOY3YArLvzWCl3Jd49QQzlgPqPTqJMIxCrxeTtFPm 0uF/3P2kN+umBLG/iFsvWunC70CpSgKUqihKs/z+hdawjygfjFCcCW4qjE0alZ2LFzJ6 3yU2X7AVHpn0O1+mswnn+eO0O4JEcIfu9JcabSlcRGw58ByDlz3mPs2ARil+B1yX+X8Q eJdMKQCIN/9GPNkf4d3YfIz/T1P7/pdQ/ScW5NJ68LCln+HIonCnQBMejdx81S14CDi9 rksL+y/xWU/JMM2LNda7FVMj9TkDZT94h/FJ8eJcgfWEFRhRmhOr01Pm7G2FXb58TLT5 C20g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=NiSIyHx7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q7-20020aa78427000000b005a8cf0d93cbsi6520198pfn.3.2023.02.15.05.08.03; Wed, 15 Feb 2023 05:08:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=NiSIyHx7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234013AbjBONG1 (ORCPT + 99 others); Wed, 15 Feb 2023 08:06:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233926AbjBONGX (ORCPT ); Wed, 15 Feb 2023 08:06:23 -0500 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 446F238B43; Wed, 15 Feb 2023 05:06:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676466383; x=1708002383; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=MRld6On45bu0R7Xy8hDi8ba43WkFZqsxPMer/O6B9x8=; b=NiSIyHx7AXzh9Z5feKZRPvHpIICO+NoaIdapaYI8XQxoBDwPI2JOQ3/X JZg7ACyh8nXHiF2jMyDTTl5vHuJ0wyqp7ZLqPo7gFm2UEt8ivY4zpyaIX i/BpyfuX4jfPCcDmBBTT5yJKbDBx3GUoQ98m//WVAju+TYKXBZPtO+vvS Ii0Tai++geX8dtYSVohk1o73TQm1rlmZESimPHkmosqgpPKpU0QsBr0Tt I8YbLHlFLEh1HXjtLUFrpAciHf6IM2KPJfO8uAk6RzMtnPlOYDK91PfFP cNeeDv8fb5wRQdDu3vvk3nO10PnO3JhKTfyQ1DyQXJ5s540D13j+edJHD A==; X-IronPort-AV: E=McAfee;i="6500,9779,10621"; a="319456237" X-IronPort-AV: E=Sophos;i="5.97,299,1669104000"; d="scan'208";a="319456237" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2023 05:06:23 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10621"; a="812436017" X-IronPort-AV: E=Sophos;i="5.97,299,1669104000"; d="scan'208";a="812436017" Received: from hshannan-mobl1.ger.corp.intel.com (HELO ijarvine-MOBL2.ger.corp.intel.com) ([10.252.49.120]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2023 05:06:20 -0800 From: =?utf-8?q?Ilpo_J=C3=A4rvinen?= To: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Reinette Chatre , Fenghua Yu , Shuah Khan , Sai Praneeth Prakhya , Babu Moger Cc: =?utf-8?q?Ilpo_J=C3=A4rvinen?= Subject: [PATCH v2 1/9] selftests/resctrl: Return NULL if malloc_and_init_memory() did not alloc mem Date: Wed, 15 Feb 2023 15:05:57 +0200 Message-Id: <20230215130605.31583-2-ilpo.jarvinen@linux.intel.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230215130605.31583-1-ilpo.jarvinen@linux.intel.com> References: <20230215130605.31583-1-ilpo.jarvinen@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757902533518650897?= X-GMAIL-MSGID: =?utf-8?q?1757902533518650897?= malloc_and_init_memory() in fill_buf isn't checking if memalign() successfully allocated memory or not before accessing the memory. Check the return value of memalign() and return NULL if allocating aligned memory fails. Fixes: a2561b12fe39 ("selftests/resctrl: Add built in benchmark") Co-developed-by: Fenghua Yu Signed-off-by: Fenghua Yu Signed-off-by: Ilpo Järvinen Reviewed-by: Reinette Chatre --- tools/testing/selftests/resctrl/fill_buf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/testing/selftests/resctrl/fill_buf.c b/tools/testing/selftests/resctrl/fill_buf.c index 56ccbeae0638..c20d0a7ecbe6 100644 --- a/tools/testing/selftests/resctrl/fill_buf.c +++ b/tools/testing/selftests/resctrl/fill_buf.c @@ -68,6 +68,8 @@ static void *malloc_and_init_memory(size_t s) size_t s64; void *p = memalign(PAGE_SIZE, s); + if (!p) + return NULL; p64 = (uint64_t *)p; s64 = s / sizeof(uint64_t);